FindBugs Bug Detector Report

The following document contains the results of FindBugs

FindBugs Version is 3.0.1

Threshold is medium

Effort is min

Summary

Classes Bugs Errors Missing Classes
55 63 0 0

org.mycore.backend.hibernate.tables.MCRFSNODES_

Bug Category Details Line Priority
Unused public or protected field: org.mycore.backend.hibernate.tables.MCRFSNODES_.date STYLE UUF_UNUSED_PUBLIC_OR_PROTECTED_FIELD Not available Medium
Unused public or protected field: org.mycore.backend.hibernate.tables.MCRFSNODES_.fctid STYLE UUF_UNUSED_PUBLIC_OR_PROTECTED_FIELD Not available Medium
Unused public or protected field: org.mycore.backend.hibernate.tables.MCRFSNODES_.id STYLE UUF_UNUSED_PUBLIC_OR_PROTECTED_FIELD Not available Medium
Unused public or protected field: org.mycore.backend.hibernate.tables.MCRFSNODES_.label STYLE UUF_UNUSED_PUBLIC_OR_PROTECTED_FIELD Not available Medium
Unused public or protected field: org.mycore.backend.hibernate.tables.MCRFSNODES_.md5 STYLE UUF_UNUSED_PUBLIC_OR_PROTECTED_FIELD Not available Medium
Unused public or protected field: org.mycore.backend.hibernate.tables.MCRFSNODES_.numchdd STYLE UUF_UNUSED_PUBLIC_OR_PROTECTED_FIELD Not available Medium
Unused public or protected field: org.mycore.backend.hibernate.tables.MCRFSNODES_.numchdf STYLE UUF_UNUSED_PUBLIC_OR_PROTECTED_FIELD Not available Medium
Unused public or protected field: org.mycore.backend.hibernate.tables.MCRFSNODES_.numchtd STYLE UUF_UNUSED_PUBLIC_OR_PROTECTED_FIELD Not available Medium
Unused public or protected field: org.mycore.backend.hibernate.tables.MCRFSNODES_.numchtf STYLE UUF_UNUSED_PUBLIC_OR_PROTECTED_FIELD Not available Medium
Unused public or protected field: org.mycore.backend.hibernate.tables.MCRFSNODES_.pid STYLE UUF_UNUSED_PUBLIC_OR_PROTECTED_FIELD Not available Medium
Unused public or protected field: org.mycore.backend.hibernate.tables.MCRFSNODES_.size STYLE UUF_UNUSED_PUBLIC_OR_PROTECTED_FIELD Not available Medium

org.mycore.backend.realhelix.MCRAVExtRealHelix

Bug Category Details Line Priority
instanceof will always return true for all non-null values in org.mycore.backend.realhelix.MCRAVExtRealHelix.getPlayerStarter(String, String), since all org.mycore.datamodel.ifs.MCRFile are instances of org.mycore.datamodel.ifs.MCRFile STYLE BC_VACUOUS_INSTANCEOF 184 Medium
Exception is caught when Exception is not thrown in org.mycore.backend.realhelix.MCRAVExtRealHelix.init(MCRFile) STYLE REC_CATCH_EXCEPTION 151 Medium

org.mycore.datamodel.ifs.MCRContentStore

Bug Category Details Line Priority
org.mycore.datamodel.ifs.MCRContentStore.lastTimestamp should be package protected MALICIOUS_CODE MS_PKGPROTECT 236 Medium
org.mycore.datamodel.ifs.MCRContentStore.formatter isn't final but should be MALICIOUS_CODE MS_SHOULD_BE_FINAL 217 High
org.mycore.datamodel.ifs.MCRContentStore.formatter is a static field of type java.text.DateFormat, which isn't thread safe MT_CORRECTNESS STCAL_STATIC_SIMPLE_DATE_FORMAT_INSTANCE Not available High

org.mycore.datamodel.ifs.MCRContentStoreFactory

Bug Category Details Line Priority
Incorrect lazy initialization of static field org.mycore.datamodel.ifs.MCRContentStoreFactory.EXTENDER_CLASSES in org.mycore.datamodel.ifs.MCRContentStoreFactory.getExtenderClass(String) MT_CORRECTNESS LI_LAZY_INIT_STATIC 160-161 Medium
Public static org.mycore.datamodel.ifs.MCRContentStoreFactory.getAvailableStores() may expose internal representation by returning MCRContentStoreFactory.STORES MALICIOUS_CODE MS_EXPOSE_REP 66 Medium
org.mycore.datamodel.ifs.MCRContentStoreFactory.STORES is a mutable collection which should be package protected MALICIOUS_CODE MS_MUTABLE_COLLECTION_PKGPROTECT 47 Medium
org.mycore.datamodel.ifs.MCRContentStoreFactory.EXTENDER_CLASSES should be package protected MALICIOUS_CODE MS_PKGPROTECT Not available Medium
org.mycore.datamodel.ifs.MCRContentStoreFactory.STORE_SELECTOR should be package protected MALICIOUS_CODE MS_PKGPROTECT Not available Medium

org.mycore.datamodel.ifs.MCRDirectoryXML

Bug Category Details Line Priority
org.mycore.datamodel.ifs.MCRDirectoryXML.SINGLETON isn't final but should be MALICIOUS_CODE MS_SHOULD_BE_FINAL 54 High
Call to method of static java.text.DateFormat in org.mycore.datamodel.ifs.MCRDirectoryXML.addDate(Element, String, GregorianCalendar) MT_CORRECTNESS STCAL_INVOKE_ON_STATIC_DATE_FORMAT_INSTANCE 186 Medium
Call to method of static java.text.DateFormat in org.mycore.datamodel.ifs.MCRDirectoryXML.addTime(Element, String, int, int, int) MT_CORRECTNESS STCAL_INVOKE_ON_STATIC_DATE_FORMAT_INSTANCE 223 Medium

org.mycore.datamodel.ifs.MCRFileContentTypeFactory

Bug Category Details Line Priority
org.mycore.datamodel.ifs.MCRFileContentTypeFactory.typesTable should be both final and package protected MALICIOUS_CODE MS_FINAL_PKGPROTECT 55 Medium
org.mycore.datamodel.ifs.MCRFileContentTypeFactory.defaultType isn't final but should be MALICIOUS_CODE MS_SHOULD_BE_FINAL 98 High
org.mycore.datamodel.ifs.MCRFileContentTypeFactory.detector isn't final but should be MALICIOUS_CODE MS_SHOULD_BE_FINAL 66 High

org.mycore.datamodel.ifs.MCRFileImportExport

Bug Category Details Line Priority
Possible null pointer dereference in org.mycore.datamodel.ifs.MCRFileImportExport.importFiles(File, MCRDirectory) due to return value of called method STYLE NP_NULL_ON_SOME_PATH_FROM_RETURN_VALUE 173 Medium
Exceptional return value of java.io.File.mkdir() ignored in org.mycore.datamodel.ifs.MCRFileImportExport.exportFiles(MCRDirectory, File) BAD_PRACTICE RV_RETURN_VALUE_IGNORED_BAD_PRACTICE 246 Medium

org.mycore.datamodel.ifs.MCRFilesystemNode

Bug Category Details Line Priority
org.mycore.datamodel.ifs.MCRFilesystemNode.formatter isn't final but should be MALICIOUS_CODE MS_SHOULD_BE_FINAL 547 High
org.mycore.datamodel.ifs.MCRFilesystemNode.manager isn't final but should be MALICIOUS_CODE MS_SHOULD_BE_FINAL 57 High
Redundant nullcheck of name, which is known to be non-null in org.mycore.datamodel.ifs.MCRFilesystemNode.checkName(String, boolean) STYLE RCN_REDUNDANT_NULLCHECK_OF_NONNULL_VALUE 182 Medium
Call to method of static java.text.DateFormat in org.mycore.datamodel.ifs.MCRFilesystemNode.toString() MT_CORRECTNESS STCAL_INVOKE_ON_STATIC_DATE_FORMAT_INSTANCE 551 Medium
org.mycore.datamodel.ifs.MCRFilesystemNode.formatter is a static field of type java.text.DateFormat, which isn't thread safe MT_CORRECTNESS STCAL_STATIC_SIMPLE_DATE_FORMAT_INSTANCE Not available Medium

org.mycore.datamodel.ifs.MCRSimpleContentStoreSelector

Bug Category Details Line Priority
org.mycore.datamodel.ifs.MCRSimpleContentStoreSelector.getAvailableStoreIDs() may expose internal representation by returning MCRSimpleContentStoreSelector.storeIDs MALICIOUS_CODE EI_EXPOSE_REP 101 Medium

org.mycore.datamodel.ifs.MCRSimpleFCTDetector$MCRDetectionRule

Bug Category Details Line Priority
Double assignment of field MCRSimpleFCTDetector$MCRDetectionRule.score in new org.mycore.datamodel.ifs.MCRSimpleFCTDetector$MCRDetectionRule(MCRSimpleFCTDetector, double) STYLE SA_FIELD_DOUBLE_ASSIGNMENT 178 Medium

org.mycore.datamodel.ifs2.MCRCStoreIFS2

Bug Category Details Line Priority
Possible null pointer dereference in org.mycore.datamodel.ifs2.MCRCStoreIFS2.getParentDirectory(String) due to return value of called method STYLE NP_NULL_ON_SOME_PATH_FROM_RETURN_VALUE 236 Medium

org.mycore.datamodel.niofs.ifs1.MCRFileSystemProvider

Bug Category Details Line Priority
Possible doublecheck on org.mycore.datamodel.niofs.ifs1.MCRFileSystemProvider.FILE_SYSTEM_INSTANCE in org.mycore.datamodel.niofs.ifs1.MCRFileSystemProvider.getFileSystem(URI) MT_CORRECTNESS DC_DOUBLECHECK 151-153 Medium
Dead store to tgtDir in org.mycore.datamodel.niofs.ifs1.MCRFileSystemProvider.copy(Path, Path, CopyOption[]) STYLE DLS_DEAD_LOCAL_STORE 350 High
Dead store to rootDirectory in org.mycore.datamodel.niofs.ifs1.MCRFileSystemProvider.createDirectory(Path, FileAttribute[]) STYLE DLS_DEAD_LOCAL_STORE 255 High
Possible null pointer dereference in org.mycore.datamodel.niofs.ifs1.MCRFileSystemProvider.copy(Path, Path, CopyOption[]) due to return value of called method STYLE NP_NULL_ON_SOME_PATH_FROM_RETURN_VALUE 354 Medium
Possible null pointer dereference in org.mycore.datamodel.niofs.ifs1.MCRFileSystemProvider.copy(Path, Path, CopyOption[]) due to return value of called method STYLE NP_NULL_ON_SOME_PATH_FROM_RETURN_VALUE 372 Medium
Possible null pointer dereference in org.mycore.datamodel.niofs.ifs1.MCRFileSystemProvider.copy(Path, Path, CopyOption[]) due to return value of called method STYLE NP_NULL_ON_SOME_PATH_FROM_RETURN_VALUE 375 Medium
Possible null pointer dereference in org.mycore.datamodel.niofs.ifs1.MCRFileSystemProvider.copy(Path, Path, CopyOption[]) due to return value of called method STYLE NP_NULL_ON_SOME_PATH_FROM_RETURN_VALUE 388 Medium
Possible null pointer dereference in org.mycore.datamodel.niofs.ifs1.MCRFileSystemProvider.createDirectory(Path, FileAttribute[]) due to return value of called method STYLE NP_NULL_ON_SOME_PATH_FROM_RETURN_VALUE 263 Medium
Possible null pointer dereference in org.mycore.datamodel.niofs.ifs1.MCRFileSystemProvider.createDirectory(Path, FileAttribute[]) due to return value of called method STYLE NP_NULL_ON_SOME_PATH_FROM_RETURN_VALUE 270 Medium
Possible null pointer dereference in org.mycore.datamodel.niofs.ifs1.MCRFileSystemProvider.createDirectory(Path, FileAttribute[]) due to return value of called method STYLE NP_NULL_ON_SOME_PATH_FROM_RETURN_VALUE 260 Medium
Possible null pointer dereference in org.mycore.datamodel.niofs.ifs1.MCRFileSystemProvider.doResolvePath(MCRPath) due to return value of called method STYLE NP_NULL_ON_SOME_PATH_FROM_RETURN_VALUE 625 Medium
Possible null pointer dereference in org.mycore.datamodel.niofs.ifs1.MCRFileSystemProvider.getParentDirectory(MCRPath) due to return value of called method STYLE NP_NULL_ON_SOME_PATH_FROM_RETURN_VALUE 313 Medium
Switch statement found in org.mycore.datamodel.niofs.ifs1.MCRFileSystemProvider.readAttributes(Path, String, LinkOption[]) where default case is missing STYLE SF_SWITCH_NO_DEFAULT 548-553 Medium

org.mycore.datamodel.niofs.ifs1.MCRFileSystemProvider$1

Bug Category Details Line Priority
Possible null pointer dereference in org.mycore.datamodel.niofs.ifs1.MCRFileSystemProvider$1.load(MCRPath) due to return value of called method STYLE NP_NULL_ON_SOME_PATH_FROM_RETURN_VALUE 109 Medium
Possible null pointer dereference in org.mycore.datamodel.niofs.ifs1.MCRFileSystemProvider$1.load(MCRPath) due to return value of called method STYLE NP_NULL_ON_SOME_PATH_FROM_RETURN_VALUE 110 Medium

org.mycore.datamodel.niofs.ifs1.MCRFileSystemUtils

Bug Category Details Line Priority
Possible null pointer dereference in org.mycore.datamodel.niofs.ifs1.MCRFileSystemUtils.getMCRFile(MCRDirectory, MCRPath, boolean, boolean) due to return value of called method STYLE NP_NULL_ON_SOME_PATH_FROM_RETURN_VALUE 125 Medium

org.mycore.datamodel.niofs.ifs1.MCRFileTypeDetector

Bug Category Details Line Priority
Possible null pointer dereference in org.mycore.datamodel.niofs.ifs1.MCRFileTypeDetector.probeContentType(Path) due to return value of called method STYLE NP_NULL_ON_SOME_PATH_FROM_RETURN_VALUE 73 Medium

org.mycore.datamodel.niofs.ifs1.MCRIFSFileSystem

Bug Category Details Line Priority
Dead store to rootDirectory in org.mycore.datamodel.niofs.ifs1.MCRIFSFileSystem.createRoot(String) STYLE DLS_DEAD_LOCAL_STORE 97 High

org.mycore.frontend.cli.MCRIFS2Commands

Bug Category Details Line Priority
Possible null pointer dereference in org.mycore.frontend.cli.MCRIFS2Commands.fixMCRFSNODESForNode(File, String, String, String, boolean) due to return value of called method STYLE NP_NULL_ON_SOME_PATH_FROM_RETURN_VALUE 267 Medium
Possible null pointer dereference in org.mycore.frontend.cli.MCRIFS2Commands.searchRecurive(ArrayList, File, int, int, String) due to return value of called method STYLE NP_NULL_ON_SOME_PATH_FROM_RETURN_VALUE 520 Medium
Nullcheck of tx at line 285 of value previously dereferenced in org.mycore.frontend.cli.MCRIFS2Commands.fixDirectoryEntry(File, String, String, boolean) CORRECTNESS RCN_REDUNDANT_NULLCHECK_WOULD_HAVE_BEEN_A_NPE 285 Medium

org.mycore.frontend.cli.MCRIFS2Commands$MCRUnicodeFilenameNormalizer

Bug Category Details Line Priority
Possible null pointer dereference in org.mycore.frontend.cli.MCRIFS2Commands$MCRUnicodeFilenameNormalizer.canNormalize(Path) due to return value of called method STYLE NP_NULL_ON_SOME_PATH_FROM_RETURN_VALUE 575 Medium
Possible null pointer dereference in org.mycore.frontend.cli.MCRIFS2Commands$MCRUnicodeFilenameNormalizer.getNormalizedPath(Path) due to return value of called method STYLE NP_NULL_ON_SOME_PATH_FROM_RETURN_VALUE 581 Medium
Possible null pointer dereference in org.mycore.frontend.cli.MCRIFS2Commands$MCRUnicodeFilenameNormalizer.getNormalizedPath(Path) due to return value of called method STYLE NP_NULL_ON_SOME_PATH_FROM_RETURN_VALUE 583 Medium

org.mycore.frontend.cli.MCRIFSCommands

Bug Category Details Line Priority
Dead store to to_store in org.mycore.frontend.cli.MCRIFSCommands.moveContentToNewStore(String, String, String, String) STYLE DLS_DEAD_LOCAL_STORE 669 Medium

org.mycore.frontend.cli.MCRIFSCommands$FileStoreIterator$1

Bug Category Details Line Priority
Possible null pointer dereference in org.mycore.frontend.cli.MCRIFSCommands$FileStoreIterator$1.getInitialList(File) due to return value of called method STYLE NP_NULL_ON_SOME_PATH_FROM_RETURN_VALUE 246 Medium