FindBugs Bug Detector Report

The following document contains the results of FindBugs

FindBugs Version is 3.0.1

Threshold is medium

Effort is min

Summary

Classes Bugs Errors Missing Classes
42 9 0 67

org.mycore.mets.frontend.MCRMetsCommands

Bug Category Details Line Priority
org.mycore.mets.frontend.MCRMetsCommands.invalidMetsQueue isn't final but should be MALICIOUS_CODE MS_SHOULD_BE_FINAL 57 High

org.mycore.mets.model.MCRMETSHierarchyGenerator$FileRef

Bug Category Details Line Priority
Should org.mycore.mets.model.MCRMETSHierarchyGenerator$FileRef be a _static_ inner class? PERFORMANCE SIC_INNER_SHOULD_BE_STATIC 581-605 Medium

org.mycore.mets.model.converter.MCRAltoLinkTypeAdapter

Bug Category Details Line Priority
Switch statement found in org.mycore.mets.model.converter.MCRAltoLinkTypeAdapter.read(JsonReader) where default case is missing STYLE SF_SWITCH_NO_DEFAULT 54-62 Medium

org.mycore.mets.model.converter.MCRMetsLinkTypeAdapter

Bug Category Details Line Priority
Switch statement found in org.mycore.mets.model.converter.MCRMetsLinkTypeAdapter.read(JsonReader) where default case is missing STYLE SF_SWITCH_NO_DEFAULT 51-56 Medium

org.mycore.mets.model.converter.MCRMetsLinkTypeAdapter$MCRMetsLinkPlaceholder

Bug Category Details Line Priority
Should org.mycore.mets.model.converter.MCRMetsLinkTypeAdapter$MCRMetsLinkPlaceholder be a _static_ inner class? PERFORMANCE SIC_INNER_SHOULD_BE_STATIC 65-105 Medium

org.mycore.mets.model.simple.MCRMetsPage

Bug Category Details Line Priority
Comparison of String parameter using == or != in org.mycore.mets.model.simple.MCRMetsPage.setContentIds(String) BAD_PRACTICE ES_COMPARING_PARAMETER_STRING_WITH_EQ 74 High
Comparison of String parameter using == or != in org.mycore.mets.model.simple.MCRMetsPage.setOrderLabel(String) BAD_PRACTICE ES_COMPARING_PARAMETER_STRING_WITH_EQ 63 High

org.mycore.mets.servlets.MCRMETSServlet

Bug Category Details Line Priority
Write to static field org.mycore.mets.servlets.MCRMETSServlet.CACHE_TIME from instance method org.mycore.mets.servlets.MCRMETSServlet.init() STYLE ST_WRITE_TO_STATIC_FROM_INSTANCE_METHOD 158 Medium

org.mycore.mets.tools.MCRMetsLock

Bug Category Details Line Priority
Comparison of String objects using == or != in org.mycore.mets.tools.MCRMetsLock.doLock(String) BAD_PRACTICE ES_COMPARING_STRINGS_WITH_EQ 69 Medium