SpotBugs Bug Detector Report
The following document contains the results of SpotBugs
SpotBugs Version is 4.7.1
Threshold is medium
Effort is default
Summary
| Classes |
Bugs |
Errors |
Missing Classes |
| 22 |
28 |
0 |
0 |
org.mycore.frontend.classeditor.json.MCRJSONCategoriesSaveList$CategorySaveElement
| Bug |
Category |
Details |
Line |
Priority |
| Should org.mycore.frontend.classeditor.json.MCRJSONCategoriesSaveList$CategorySaveElement be a _static_ inner class? |
PERFORMANCE |
SIC_INNER_SHOULD_BE_STATIC |
51-55 |
Medium |
| Unread field: org.mycore.frontend.classeditor.json.MCRJSONCategoriesSaveList$CategorySaveElement.categ |
PERFORMANCE |
URF_UNREAD_FIELD |
52 |
Medium |
| Unread field: org.mycore.frontend.classeditor.json.MCRJSONCategoriesSaveList$CategorySaveElement.index |
PERFORMANCE |
URF_UNREAD_FIELD |
54 |
Medium |
| Unread field: org.mycore.frontend.classeditor.json.MCRJSONCategoriesSaveList$CategorySaveElement.parentID |
PERFORMANCE |
URF_UNREAD_FIELD |
53 |
Medium |
org.mycore.frontend.classeditor.json.MCRJSONCategory
| Bug |
Category |
Details |
Line |
Priority |
| org.mycore.frontend.classeditor.json.MCRJSONCategory.asMCRImpl() may expose internal representation by returning MCRJSONCategory.category |
MALICIOUS_CODE |
EI_EXPOSE_REP |
150 |
Medium |
| org.mycore.frontend.classeditor.json.MCRJSONCategory.getParentID() may expose internal representation by returning MCRJSONCategory.parentID |
MALICIOUS_CODE |
EI_EXPOSE_REP |
136 |
Medium |
| new org.mycore.frontend.classeditor.json.MCRJSONCategory(MCRCategory) may expose internal representation by storing an externally mutable object into MCRJSONCategory.category |
MALICIOUS_CODE |
EI_EXPOSE_REP2 |
57 |
Medium |
| org.mycore.frontend.classeditor.json.MCRJSONCategory.setParentID(MCRCategoryID) may expose internal representation by storing an externally mutable object into MCRJSONCategory.parentID |
MALICIOUS_CODE |
EI_EXPOSE_REP2 |
132 |
Medium |
org.mycore.frontend.classeditor.json.MCRJSONCategoryHelper
| Bug |
Category |
Details |
Line |
Priority |
| org.mycore.frontend.classeditor.json.MCRJSONCategoryHelper.PROP_CATEGID isn't final but should be |
MALICIOUS_CODE |
MS_SHOULD_BE_FINAL |
30 |
High |
| org.mycore.frontend.classeditor.json.MCRJSONCategoryHelper.PROP_CHILDREN isn't final but should be |
MALICIOUS_CODE |
MS_SHOULD_BE_FINAL |
36 |
High |
| org.mycore.frontend.classeditor.json.MCRJSONCategoryHelper.PROP_DESCRIPTION isn't final but should be |
MALICIOUS_CODE |
MS_SHOULD_BE_FINAL |
46 |
High |
| org.mycore.frontend.classeditor.json.MCRJSONCategoryHelper.PROP_HAS_CHILDREN isn't final but should be |
MALICIOUS_CODE |
MS_SHOULD_BE_FINAL |
38 |
High |
| org.mycore.frontend.classeditor.json.MCRJSONCategoryHelper.PROP_HAS_LINK isn't final but should be |
MALICIOUS_CODE |
MS_SHOULD_BE_FINAL |
40 |
High |
| org.mycore.frontend.classeditor.json.MCRJSONCategoryHelper.PROP_ID isn't final but should be |
MALICIOUS_CODE |
MS_SHOULD_BE_FINAL |
22 |
High |
| org.mycore.frontend.classeditor.json.MCRJSONCategoryHelper.PROP_LABELS isn't final but should be |
MALICIOUS_CODE |
MS_SHOULD_BE_FINAL |
32 |
High |
| org.mycore.frontend.classeditor.json.MCRJSONCategoryHelper.PROP_LANG isn't final but should be |
MALICIOUS_CODE |
MS_SHOULD_BE_FINAL |
42 |
High |
| org.mycore.frontend.classeditor.json.MCRJSONCategoryHelper.PROP_PARENTID isn't final but should be |
MALICIOUS_CODE |
MS_SHOULD_BE_FINAL |
24 |
High |
| org.mycore.frontend.classeditor.json.MCRJSONCategoryHelper.PROP_POSITION isn't final but should be |
MALICIOUS_CODE |
MS_SHOULD_BE_FINAL |
26 |
High |
| org.mycore.frontend.classeditor.json.MCRJSONCategoryHelper.PROP_ROOTID isn't final but should be |
MALICIOUS_CODE |
MS_SHOULD_BE_FINAL |
28 |
High |
| org.mycore.frontend.classeditor.json.MCRJSONCategoryHelper.PROP_TEXT isn't final but should be |
MALICIOUS_CODE |
MS_SHOULD_BE_FINAL |
44 |
High |
| org.mycore.frontend.classeditor.json.MCRJSONCategoryHelper.PROP_URISTR isn't final but should be |
MALICIOUS_CODE |
MS_SHOULD_BE_FINAL |
34 |
High |
org.mycore.frontend.classeditor.resources.MCRClassificationEditorResource$DeleteOp
| Bug |
Category |
Details |
Line |
Priority |
| Should org.mycore.frontend.classeditor.resources.MCRClassificationEditorResource$DeleteOp be a _static_ inner class? |
PERFORMANCE |
SIC_INNER_SHOULD_BE_STATIC |
453-478 |
Medium |
org.mycore.frontend.classeditor.resources.MCRClassificationEditorResource$IndexComperator
| Bug |
Category |
Details |
Line |
Priority |
| org.mycore.frontend.classeditor.resources.MCRClassificationEditorResource$IndexComperator implements Comparator but not Serializable |
BAD_PRACTICE |
SE_COMPARATOR_SHOULD_BE_SERIALIZABLE |
409-439 |
Medium |
org.mycore.frontend.classeditor.wrapper.MCRCategoryListWrapper
| Bug |
Category |
Details |
Line |
Priority |
| org.mycore.frontend.classeditor.wrapper.MCRCategoryListWrapper.getLinkMap() may expose internal representation by returning MCRCategoryListWrapper.linkMap |
MALICIOUS_CODE |
EI_EXPOSE_REP |
47 |
Medium |
| org.mycore.frontend.classeditor.wrapper.MCRCategoryListWrapper.getList() may expose internal representation by returning MCRCategoryListWrapper.categList |
MALICIOUS_CODE |
EI_EXPOSE_REP |
43 |
Medium |
| new org.mycore.frontend.classeditor.wrapper.MCRCategoryListWrapper(List) may expose internal representation by storing an externally mutable object into MCRCategoryListWrapper.categList |
MALICIOUS_CODE |
EI_EXPOSE_REP2 |
34 |
Medium |
| new org.mycore.frontend.classeditor.wrapper.MCRCategoryListWrapper(List, Map) may expose internal representation by storing an externally mutable object into MCRCategoryListWrapper.categList |
MALICIOUS_CODE |
EI_EXPOSE_REP2 |
38 |
Medium |
| new org.mycore.frontend.classeditor.wrapper.MCRCategoryListWrapper(List, Map) may expose internal representation by storing an externally mutable object into MCRCategoryListWrapper.linkMap |
MALICIOUS_CODE |
EI_EXPOSE_REP2 |
39 |
Medium |
