SpotBugs Bug Detector Report
The following document contains the results of SpotBugs
SpotBugs Version is 4.7.1
Threshold is medium
Effort is default
Summary
| Classes |
Bugs |
Errors |
Missing Classes |
| 75 |
31 |
0 |
0 |
org.mycore.solr.MCRSolrCore
| Bug |
Category |
Details |
Line |
Priority |
| org.mycore.solr.MCRSolrCore.getClient() may expose internal representation by returning MCRSolrCore.solrClient |
MALICIOUS_CODE |
EI_EXPOSE_REP |
181 |
Medium |
org.mycore.solr.classification.MCRSolrCategory
| Bug |
Category |
Details |
Line |
Priority |
| new org.mycore.solr.classification.MCRSolrCategory(MCRCategory) may expose internal representation by storing an externally mutable object into MCRSolrCategory.category |
MALICIOUS_CODE |
EI_EXPOSE_REP2 |
34 |
Medium |
org.mycore.solr.classification.MCRSolrCategoryDAO
| Bug |
Category |
Details |
Line |
Priority |
| Exception is caught when Exception is not thrown in org.mycore.solr.classification.MCRSolrCategoryDAO.solrDelete(MCRCategoryID, MCRCategory) |
STYLE |
REC_CATCH_EXCEPTION |
101 |
Medium |
org.mycore.solr.classification.MCRSolrCategoryLink
| Bug |
Category |
Details |
Line |
Priority |
| new org.mycore.solr.classification.MCRSolrCategoryLink(MCRCategoryID, MCRCategLinkReference) may expose internal representation by storing an externally mutable object into MCRSolrCategoryLink.categoryId |
MALICIOUS_CODE |
EI_EXPOSE_REP2 |
43 |
Medium |
| new org.mycore.solr.classification.MCRSolrCategoryLink(MCRCategoryID, MCRCategLinkReference) may expose internal representation by storing an externally mutable object into MCRSolrCategoryLink.linkReference |
MALICIOUS_CODE |
EI_EXPOSE_REP2 |
44 |
Medium |
org.mycore.solr.index.MCRSolrIndexTask
| Bug |
Category |
Details |
Line |
Priority |
| new org.mycore.solr.index.MCRSolrIndexTask(MCRSolrIndexHandler) may expose internal representation by storing an externally mutable object into MCRSolrIndexTask.indexHandler |
MALICIOUS_CODE |
EI_EXPOSE_REP2 |
43 |
Medium |
org.mycore.solr.index.document.jaxb.MCRSolrInputDocument
| Bug |
Category |
Details |
Line |
Priority |
| org.mycore.solr.index.document.jaxb.MCRSolrInputDocument.getFieldOrDoc() may expose internal representation by returning MCRSolrInputDocument.fieldOrDoc |
MALICIOUS_CODE |
EI_EXPOSE_REP |
110 |
Medium |
org.mycore.solr.index.document.jaxb.MCRSolrInputDocumentList
| Bug |
Category |
Details |
Line |
Priority |
| org.mycore.solr.index.document.jaxb.MCRSolrInputDocumentList.getDoc() may expose internal representation by returning MCRSolrInputDocumentList.doc |
MALICIOUS_CODE |
EI_EXPOSE_REP |
100 |
Medium |
org.mycore.solr.index.document.jaxb.MCRSolrInputField
| Bug |
Category |
Details |
Line |
Priority |
| Unused public or protected field: org.mycore.solr.index.document.jaxb.MCRSolrInputField.boost |
STYLE |
UUF_UNUSED_PUBLIC_OR_PROTECTED_FIELD |
Not available |
Medium |
org.mycore.solr.index.file.MCRSolrFileIndexBaseAccumulator
| Bug |
Category |
Details |
Line |
Priority |
| Possible null pointer dereference in org.mycore.solr.index.file.MCRSolrFileIndexBaseAccumulator.accumulate(SolrInputDocument, Path, BasicFileAttributes) due to return value of called method |
STYLE |
NP_NULL_ON_SOME_PATH_FROM_RETURN_VALUE |
93 |
Medium |
| Possible null pointer dereference in org.mycore.solr.index.file.MCRSolrFileIndexBaseAccumulator.accumulate(SolrInputDocument, Path, BasicFileAttributes) due to return value of called method |
STYLE |
NP_NULL_ON_SOME_PATH_FROM_RETURN_VALUE |
99 |
Medium |
org.mycore.solr.index.handlers.MCRSolrAbstractIndexHandler
| Bug |
Category |
Details |
Line |
Priority |
| org.mycore.solr.index.handlers.MCRSolrAbstractIndexHandler.getSolrClient() may expose internal representation by returning MCRSolrAbstractIndexHandler.solrClient |
MALICIOUS_CODE |
EI_EXPOSE_REP |
47 |
Medium |
| org.mycore.solr.index.handlers.MCRSolrAbstractIndexHandler.setSolrServer(SolrClient) may expose internal representation by storing an externally mutable object into MCRSolrAbstractIndexHandler.solrClient |
MALICIOUS_CODE |
EI_EXPOSE_REP2 |
71 |
Medium |
org.mycore.solr.index.handlers.content.MCRSolrMCRContentIndexHandler
| Bug |
Category |
Details |
Line |
Priority |
| new org.mycore.solr.index.handlers.content.MCRSolrMCRContentIndexHandler(MCRObjectID, MCRContent, SolrClient) may expose internal representation by storing an externally mutable object into MCRSolrMCRContentIndexHandler.content |
MALICIOUS_CODE |
EI_EXPOSE_REP2 |
58 |
Medium |
| new org.mycore.solr.index.handlers.content.MCRSolrMCRContentIndexHandler(MCRObjectID, MCRContent, SolrClient) may expose internal representation by storing an externally mutable object into MCRSolrMCRContentIndexHandler.id |
MALICIOUS_CODE |
EI_EXPOSE_REP2 |
57 |
Medium |
org.mycore.solr.index.handlers.content.MCRSolrMCRContentMapIndexHandler
| Bug |
Category |
Details |
Line |
Priority |
| org.mycore.solr.index.handlers.content.MCRSolrMCRContentMapIndexHandler.getSubHandlers() may expose internal representation by returning MCRSolrMCRContentMapIndexHandler.subhandlers |
MALICIOUS_CODE |
EI_EXPOSE_REP |
139 |
Medium |
| new org.mycore.solr.index.handlers.content.MCRSolrMCRContentMapIndexHandler(Map, SolrClient) may expose internal representation by storing an externally mutable object into MCRSolrMCRContentMapIndexHandler.contentMap |
MALICIOUS_CODE |
EI_EXPOSE_REP2 |
63 |
Medium |
org.mycore.solr.index.handlers.document.MCRSolrInputDocumentHandler
| Bug |
Category |
Details |
Line |
Priority |
| new org.mycore.solr.index.handlers.document.MCRSolrInputDocumentHandler(SolrInputDocument) may expose internal representation by storing an externally mutable object into MCRSolrInputDocumentHandler.document |
MALICIOUS_CODE |
EI_EXPOSE_REP2 |
48 |
Medium |
| new org.mycore.solr.index.handlers.document.MCRSolrInputDocumentHandler(SolrInputDocument, SolrClient) may expose internal representation by storing an externally mutable object into MCRSolrInputDocumentHandler.document |
MALICIOUS_CODE |
EI_EXPOSE_REP2 |
53 |
Medium |
org.mycore.solr.index.handlers.document.MCRSolrInputDocumentsHandler
| Bug |
Category |
Details |
Line |
Priority |
| new org.mycore.solr.index.handlers.document.MCRSolrInputDocumentsHandler(Collection, SolrClient) may expose internal representation by storing an externally mutable object into MCRSolrInputDocumentsHandler.documents |
MALICIOUS_CODE |
EI_EXPOSE_REP2 |
58 |
Medium |
org.mycore.solr.index.handlers.stream.MCRSolrFilesIndexHandler
| Bug |
Category |
Details |
Line |
Priority |
| org.mycore.solr.index.handlers.stream.MCRSolrFilesIndexHandler.getSubHandlers() may expose internal representation by returning MCRSolrFilesIndexHandler.subHandlerList |
MALICIOUS_CODE |
EI_EXPOSE_REP |
130 |
Medium |
org.mycore.solr.index.statistic.MCRSolrIndexStatistic
| Bug |
Category |
Details |
Line |
Priority |
| Synchronization performed on java.util.concurrent.atomic.AtomicInteger in org.mycore.solr.index.statistic.MCRSolrIndexStatistic.reset() |
MT_CORRECTNESS |
JLM_JSR166_UTILCONCURRENT_MONITORENTER |
70 |
Medium |
| Synchronization performed on java.util.concurrent.atomic.AtomicLong in org.mycore.solr.index.statistic.MCRSolrIndexStatistic.reset() |
MT_CORRECTNESS |
JLM_JSR166_UTILCONCURRENT_MONITORENTER |
69 |
Medium |
org.mycore.solr.index.strategy.MCRSolrMimeTypeStrategy
| Bug |
Category |
Details |
Line |
Priority |
| Possible null pointer dereference in org.mycore.solr.index.strategy.MCRSolrMimeTypeStrategy.check(Path, BasicFileAttributes) due to return value of called method |
STYLE |
NP_NULL_ON_SOME_PATH_FROM_RETURN_VALUE |
51 |
Medium |
org.mycore.solr.proxy.MCRSolrProxyServlet
| Bug |
Category |
Details |
Line |
Priority |
| Class org.mycore.solr.proxy.MCRSolrProxyServlet defines non-transient non-serializable instance field httpClient |
BAD_PRACTICE |
SE_BAD_FIELD |
Not available |
Medium |
| Class org.mycore.solr.proxy.MCRSolrProxyServlet defines non-transient non-serializable instance field httpClientConnectionManager |
BAD_PRACTICE |
SE_BAD_FIELD |
Not available |
Medium |
| Class org.mycore.solr.proxy.MCRSolrProxyServlet defines non-transient non-serializable instance field idleConnectionMonitorThread |
BAD_PRACTICE |
SE_BAD_FIELD |
Not available |
Medium |
org.mycore.solr.search.MCRSolrSearchUtils$SolrDocumentSpliterator
| Bug |
Category |
Details |
Line |
Priority |
| new org.mycore.solr.search.MCRSolrSearchUtils$SolrDocumentSpliterator(SolrClient, SolrParams, long, long, Long) may expose internal representation by storing an externally mutable object into MCRSolrSearchUtils$SolrDocumentSpliterator.params |
MALICIOUS_CODE |
EI_EXPOSE_REP2 |
167 |
Medium |
| new org.mycore.solr.search.MCRSolrSearchUtils$SolrDocumentSpliterator(SolrClient, SolrParams, long, long, Long) may expose internal representation by storing an externally mutable object into MCRSolrSearchUtils$SolrDocumentSpliterator.solrClient |
MALICIOUS_CODE |
EI_EXPOSE_REP2 |
166 |
Medium |
org.mycore.solr.search.MCRSolrURL
| Bug |
Category |
Details |
Line |
Priority |
| new org.mycore.solr.search.MCRSolrURL(HttpSolrClient) may expose internal representation by storing an externally mutable object into MCRSolrURL.solrClient |
MALICIOUS_CODE |
EI_EXPOSE_REP2 |
69 |
Medium |
| new org.mycore.solr.search.MCRSolrURL(HttpSolrClient, String) may expose internal representation by storing an externally mutable object into MCRSolrURL.solrClient |
MALICIOUS_CODE |
EI_EXPOSE_REP2 |
88 |
Medium |
