PMD Results
The following document contains the results of PMD 6.49.0.
Violations By Priority
Priority 1
org/mycore/datamodel/common/MCRMarkManager.java
| Rule | Violation | Line |
|---|---|---|
| DoubleCheckedLocking | Double checked locking is not thread safe in Java. | 94–104 |
Priority 2
org/mycore/datamodel/metadata/validator/MCREditorOutValidator.java
| Rule | Violation | Line |
|---|---|---|
| BrokenNullCheck | Method call on object which may be null | 205–208 |
Priority 3
org/mycore/backend/jpa/access/MCRJPAAccessStore.java
| Rule | Violation | Line |
|---|---|---|
| EmptyCatchBlock | Avoid empty catch blocks | 181–183 |
org/mycore/common/MCRSessionMgr.java
| Rule | Violation | Line |
|---|---|---|
| UnusedPrivateMethod | Avoid unused private methods such as 'checkSessionLock()'. | 91 |
org/mycore/common/config/MCRConfigurationDir.java
| Rule | Violation | Line |
|---|---|---|
| EmptyCatchBlock | Avoid empty catch blocks | 238–240 |
org/mycore/common/content/MCRPathContent.java
| Rule | Violation | Line |
|---|---|---|
| UnusedPrivateField | Avoid unused private fields such as 'LOGGER'. | 47 |
| UnusedPrivateField | Avoid unused private fields such as 'BUFFER_SIZE'. | 53 |
org/mycore/common/content/transformer/MCRXSLTransformer.java
| Rule | Violation | Line |
|---|---|---|
| UnusedFormalParameter | Avoid unused method parameters such as 'content'. | 387 |
| EmptyCatchBlock | Avoid empty catch blocks | 423–425 |
org/mycore/common/content/util/MCRRestContentHelper.java
| Rule | Violation | Line |
|---|---|---|
| EmptyCatchBlock | Avoid empty catch blocks | 173–175 |
org/mycore/common/content/util/MCRServletContentHelper.java
| Rule | Violation | Line |
|---|---|---|
| EmptyCatchBlock | Avoid empty catch blocks | 174–176 |
| CollapsibleIfStatements | These nested if statements could be combined | 267–285 |
| CollapsibleIfStatements | These nested if statements could be combined | 303–308 |
| CollapsibleIfStatements | These nested if statements could be combined | 365–369 |
| EmptyCatchBlock | Avoid empty catch blocks | 426–428 |
org/mycore/common/xml/MCRLayoutService.java
| Rule | Violation | Line |
|---|---|---|
| UnusedFormalParameter | Avoid unused method parameters such as 'filename'. | 230 |
org/mycore/common/xml/MCRURIResolver.java
| Rule | Violation | Line |
|---|---|---|
| EmptyCatchBlock | Avoid empty catch blocks | 795–797 |
org/mycore/common/xsl/MCRParameterCollector.java
| Rule | Violation | Line |
|---|---|---|
| OverrideBothEqualsAndHashcode | Ensure you override both equals() and hashCode() | 357 |
org/mycore/datamodel/classifications2/impl/MCRCategoryDAOImpl.java
| Rule | Violation | Line |
|---|---|---|
| EmptyCatchBlock | Avoid empty catch blocks | 144–147 |
org/mycore/datamodel/common/MCRDataURL.java
| Rule | Violation | Line |
|---|---|---|
| CollapsibleIfStatements | These nested if statements could be combined | 183–189 |
| UnusedFormalParameter | Avoid unused constructor parameters such as 'mimeType'. | 419 |
org/mycore/datamodel/common/MCRISO8601Date.java
| Rule | Violation | Line |
|---|---|---|
| OverrideBothEqualsAndHashcode | Ensure you override both equals() and hashCode() | 282 |
org/mycore/datamodel/ifs2/MCRFileCollection.java
| Rule | Violation | Line |
|---|---|---|
| EmptyCatchBlock | Avoid empty catch blocks | 143–145 |
org/mycore/datamodel/ifs2/MCRStore.java
| Rule | Violation | Line |
|---|---|---|
| EmptyCatchBlock | Avoid empty catch blocks | 487–489 |
org/mycore/datamodel/ifs/MCRFileNodeServlet.java
| Rule | Violation | Line |
|---|---|---|
| UnusedFormalParameter | Avoid unused method parameters such as 'request'. | 160 |
| UnusedFormalParameter | Avoid unused method parameters such as 'response'. | 160 |
org/mycore/datamodel/language/MCRLanguageFactory.java
| Rule | Violation | Line |
|---|---|---|
| UnusedLocalVariable | Avoid unused local variables such as 'session'. | 232 |
org/mycore/datamodel/metadata/MCRMetaAddress.java
| Rule | Violation | Line |
|---|---|---|
| OverrideBothEqualsAndHashcode | Ensure you override both equals() and hashCode() | 216 |
org/mycore/datamodel/metadata/MCRMetaBoolean.java
| Rule | Violation | Line |
|---|---|---|
| UnusedFormalParameter | Avoid unused constructor parameters such as 'lang'. | 74 |
| OverrideBothEqualsAndHashcode | Ensure you override both equals() and hashCode() | 233 |
org/mycore/datamodel/metadata/MCRMetaClassification.java
| Rule | Violation | Line |
|---|---|---|
| OverrideBothEqualsAndHashcode | Ensure you override both equals() and hashCode() | 242 |
org/mycore/datamodel/metadata/MCRMetaDateLangText.java
| Rule | Violation | Line |
|---|---|---|
| OverrideBothEqualsAndHashcode | Ensure you override both equals() and hashCode() | 195 |
org/mycore/datamodel/metadata/MCRMetaHistoryDate.java
| Rule | Violation | Line |
|---|---|---|
| OverrideBothEqualsAndHashcode | Ensure you override both equals() and hashCode() | 534 |
| EmptyCatchBlock | Avoid empty catch blocks | 667–669 |
org/mycore/datamodel/metadata/MCRMetaIFS.java
| Rule | Violation | Line |
|---|---|---|
| OverrideBothEqualsAndHashcode | Ensure you override both equals() and hashCode() | 230 |
org/mycore/datamodel/metadata/MCRMetaISO8601Date.java
| Rule | Violation | Line |
|---|---|---|
| OverrideBothEqualsAndHashcode | Ensure you override both equals() and hashCode() | 256 |
org/mycore/datamodel/metadata/MCRMetaInstitutionName.java
| Rule | Violation | Line |
|---|---|---|
| OverrideBothEqualsAndHashcode | Ensure you override both equals() and hashCode() | 249 |
org/mycore/datamodel/metadata/MCRMetaLangText.java
| Rule | Violation | Line |
|---|---|---|
| OverrideBothEqualsAndHashcode | Ensure you override both equals() and hashCode() | 285 |
org/mycore/datamodel/metadata/MCRMetaLink.java
| Rule | Violation | Line |
|---|---|---|
| CollapsibleIfStatements | These nested if statements could be combined | 238–240 |
| CollapsibleIfStatements | These nested if statements could be combined | 408–410 |
| CollapsibleIfStatements | These nested if statements could be combined | 432–434 |
org/mycore/datamodel/metadata/MCRMetaLinkID.java
| Rule | Violation | Line |
|---|---|---|
| OverrideBothEqualsAndHashcode | Ensure you override both equals() and hashCode() | 241 |
org/mycore/datamodel/metadata/MCRMetaNumber.java
| Rule | Violation | Line |
|---|---|---|
| BigIntegerInstantiation | Dont create instances of already existing BigInteger and BigDecimal (ZERO, ONE, TEN) | 105 |
| OverrideBothEqualsAndHashcode | Ensure you override both equals() and hashCode() | 351 |
org/mycore/datamodel/metadata/MCRMetaPersonName.java
| Rule | Violation | Line |
|---|---|---|
| OverrideBothEqualsAndHashcode | Ensure you override both equals() and hashCode() | 444 |
org/mycore/datamodel/metadata/MCRMetaXML.java
| Rule | Violation | Line |
|---|---|---|
| OverrideBothEqualsAndHashcode | Ensure you override both equals() and hashCode() | 185 |
org/mycore/datamodel/niofs/MCRPathUtils.java
| Rule | Violation | Line |
|---|---|---|
| EmptyCatchBlock | Avoid empty catch blocks | 64–66 |
org/mycore/datamodel/niofs/utils/MCRTreeCopier.java
| Rule | Violation | Line |
|---|---|---|
| EmptyCatchBlock | Avoid empty catch blocks | 78–81 |
org/mycore/frontend/MCRFrontendUtil.java
| Rule | Violation | Line |
|---|---|---|
| AvoidUsingHardCodedIP | Do not hard code the IP address | 72 |
| AvoidUsingHardCodedIP | Do not hard code the IP address | 75 |
org/mycore/frontend/cli/MCRBatchEditorCommands.java
| Rule | Violation | Line |
|---|---|---|
| CollapsibleIfStatements | These nested if statements could be combined | 140–142 |
org/mycore/frontend/cli/MCRCommandLineInterface.java
| Rule | Violation | Line |
|---|---|---|
| AvoidUsingHardCodedIP | Do not hard code the IP address | 175 |
| UnusedFormalParameter | Avoid unused method parameters such as 'session'. | 233 |
org/mycore/frontend/fileupload/MCRUploadViaFormServlet.java
| Rule | Violation | Line |
|---|---|---|
| UnusedLocalVariable | Avoid unused local variables such as 'session'. | 97 |
org/mycore/frontend/filter/MCRSecureTokenV2Filter.java
| Rule | Violation | Line |
|---|---|---|
| CollapsibleIfStatements | These nested if statements could be combined | 85–89 |
org/mycore/frontend/jersey/filter/MCRDBTransactionFilter.java
| Rule | Violation | Line |
|---|---|---|
| UnusedLocalVariable | Avoid unused local variables such as 'session'. | 34 |
org/mycore/frontend/servlets/MCRObjectServlet.java
| Rule | Violation | Line |
|---|---|---|
| UnusedPrivateField | Avoid unused private fields such as 'REV_CURRENT'. | 50 |
org/mycore/frontend/servlets/MCRServlet.java
| Rule | Violation | Line |
|---|---|---|
| UnusedFormalParameter | Avoid unused method parameters such as 'context'. | 122 |
| UnusedLocalVariable | Avoid unused local variables such as 'session'. | 299 |
| UnusedLocalVariable | Avoid unused local variables such as 'session'. | 410 |
| UnusedLocalVariable | Avoid unused local variables such as 'session'. | 449 |
org/mycore/frontend/servlets/MCRServletJob.java
| Rule | Violation | Line |
|---|---|---|
| AvoidUsingHardCodedIP | Do not hard code the IP address | 75 |
org/mycore/services/i18n/MCRTranslation.java
| Rule | Violation | Line |
|---|---|---|
| EmptyCatchBlock | Avoid empty catch blocks | 173–174 |
org/mycore/services/queuedjob/MCRJobMaster.java
| Rule | Violation | Line |
|---|---|---|
| AvoidThreadGroup | Avoid using java.lang.ThreadGroup; it is not thread safe | 156 |
org/mycore/tools/MCRTopologicalSort.java
| Rule | Violation | Line |
|---|---|---|
| CollapsibleIfStatements | These nested if statements could be combined | 306–309 |
Priority 4
org/mycore/access/mcrimpl/MCRGroupClause.java
| Rule | Violation | Line |
|---|---|---|
| UselessParentheses | Useless parentheses. | 62 |
org/mycore/access/mcrimpl/MCRRuleParser.java
| Rule | Violation | Line |
|---|---|---|
| UnnecessaryFullyQualifiedName | Unnecessary use of fully qualified name 'java.text.ParseException' due to existing import 'java.text.ParseException' | 43 |
org/mycore/access/mcrimpl/MCRUserClause.java
| Rule | Violation | Line |
|---|---|---|
| UselessParentheses | Useless parentheses. | 85 |
org/mycore/common/MCRCalendar.java
| Rule | Violation | Line |
|---|---|---|
| UselessParentheses | Useless parentheses. | 283 |
| UselessParentheses | Useless parentheses. | 286 |
| UselessParentheses | Useless parentheses. | 286 |
| UselessParentheses | Useless parentheses. | 288 |
| UselessParentheses | Useless parentheses. | 288 |
| UselessParentheses | Useless parentheses. | 808 |
| UselessParentheses | Useless parentheses. | 855 |
org/mycore/common/MCRConstants.java
| Rule | Violation | Line |
|---|---|---|
| UselessParentheses | Useless parentheses. | 157 |
org/mycore/common/MCRExceptionCauseFinder.java
| Rule | Violation | Line |
|---|---|---|
| UselessParentheses | Useless parentheses. | 36 |
| UselessParentheses | Useless parentheses. | 41 |
org/mycore/common/MCRGeoUtilities.java
| Rule | Violation | Line |
|---|---|---|
| UselessParentheses | Useless parentheses. | 35 |
| UselessParentheses | Useless parentheses. | 35 |
| UselessParentheses | Useless parentheses. | 44 |
| UselessParentheses | Useless parentheses. | 61 |
| UselessParentheses | Useless parentheses. | 61 |
| UselessParentheses | Useless parentheses. | 84 |
org/mycore/common/MCRMailer.java
| Rule | Violation | Line |
|---|---|---|
| UselessParentheses | Useless parentheses. | 395 |
| UnnecessaryFullyQualifiedName | Unnecessary use of fully qualified name 'jakarta.mail.Authenticator' due to existing import 'jakarta.mail.Authenticator' | 778 |
org/mycore/common/content/transformer/MCRToPrettyXML.java
| Rule | Violation | Line |
|---|---|---|
| UselessParentheses | Useless parentheses. | 41 |
org/mycore/common/content/transformer/MCRXSLTransformer.java
| Rule | Violation | Line |
|---|---|---|
| UselessParentheses | Useless parentheses. | 367 |
org/mycore/common/events/MCRServletContainerInitializer.java
| Rule | Violation | Line |
|---|---|---|
| UselessParentheses | Useless parentheses. | 95 |
org/mycore/common/xml/MCRAttributeValueFilter.java
| Rule | Violation | Line |
|---|---|---|
| UselessParentheses | Useless parentheses. | 49 |
org/mycore/common/xml/MCRNodeBuilder.java
| Rule | Violation | Line |
|---|---|---|
| UselessParentheses | Useless parentheses. | 203 |
| UselessParentheses | Useless parentheses. | 203 |
| UselessParentheses | Useless parentheses. | 205 |
| UselessParentheses | Useless parentheses. | 205 |
| UselessParentheses | Useless parentheses. | 252 |
| UselessParentheses | Useless parentheses. | 252 |
| UselessParentheses | Useless parentheses. | 262 |
org/mycore/common/xml/MCRURIResolver.java
| Rule | Violation | Line |
|---|---|---|
| UnnecessaryFullyQualifiedName | Unnecessary use of fully qualified name 'org.apache.logging.log4j.Logger' due to existing import 'org.apache.logging.log4j.Logger' | 451 |
org/mycore/common/xml/MCRXPathBuilder.java
| Rule | Violation | Line |
|---|---|---|
| UselessParentheses | Useless parentheses. | 85 |
| UselessParentheses | Useless parentheses. | 85 |
| UselessParentheses | Useless parentheses. | 111 |
| UselessParentheses | Useless parentheses. | 120 |
| UselessParentheses | Useless parentheses. | 120 |
org/mycore/common/xsl/MCRParameterCollector.java
| Rule | Violation | Line |
|---|---|---|
| UselessParentheses | Useless parentheses. | 168 |
org/mycore/crypt/MCRAESCipher.java
| Rule | Violation | Line |
|---|---|---|
| UselessParentheses | Useless parentheses. | 96 |
org/mycore/datamodel/classifications2/impl/MCRCategLinkServiceImpl.java
| Rule | Violation | Line |
|---|---|---|
| UnnecessaryFullyQualifiedName | Unnecessary use of fully qualified name 'jakarta.persistence.Query' due to existing import 'jakarta.persistence.Query' | 157 |
org/mycore/datamodel/common/MCRDefaultXMLMetadataManager.java
| Rule | Violation | Line |
|---|---|---|
| UselessParentheses | Useless parentheses. | 180 |
org/mycore/datamodel/ifs2/MCRVersioningMetadataStore.java
| Rule | Violation | Line |
|---|---|---|
| UselessParentheses | Useless parentheses. | 103 |
org/mycore/datamodel/language/MCRLanguageFactory.java
| Rule | Violation | Line |
|---|---|---|
| UselessParentheses | Useless parentheses. | 119 |
| UselessParentheses | Useless parentheses. | 162 |
| UselessParentheses | Useless parentheses. | 163 |
org/mycore/datamodel/language/MCRLanguageXML.java
| Rule | Violation | Line |
|---|---|---|
| UselessParentheses | Useless parentheses. | 54 |
| UselessParentheses | Useless parentheses. | 58 |
org/mycore/datamodel/metadata/MCRMetaElement.java
| Rule | Violation | Line |
|---|---|---|
| UselessParentheses | Useless parentheses. | 129 |
| UselessParentheses | Useless parentheses. | 129 |
| UselessParentheses | Useless parentheses. | 252 |
| UselessParentheses | Useless parentheses. | 252 |
| UselessParentheses | Useless parentheses. | 355 |
| UselessParentheses | Useless parentheses. | 386 |
| UselessParentheses | Useless parentheses. | 456 |
org/mycore/datamodel/metadata/MCRMetaEnrichedLinkID.java
| Rule | Violation | Line |
|---|---|---|
| UselessParentheses | Useless parentheses. | 181–182 |
org/mycore/datamodel/metadata/MCRMetaHistoryDate.java
| Rule | Violation | Line |
|---|---|---|
| UselessParentheses | Useless parentheses. | 229 |
org/mycore/datamodel/metadata/MCRMetadataManager.java
| Rule | Violation | Line |
|---|---|---|
| UselessParentheses | Useless parentheses. | 854 |
org/mycore/datamodel/metadata/MCRObjectDerivate.java
| Rule | Violation | Line |
|---|---|---|
| UselessParentheses | Useless parentheses. | 195 |
| UselessParentheses | Useless parentheses. | 195 |
| UselessParentheses | Useless parentheses. | 217 |
| UselessParentheses | Useless parentheses. | 217 |
| UselessParentheses | Useless parentheses. | 459 |
| UselessParentheses | Useless parentheses. | 459 |
org/mycore/datamodel/metadata/MCRObjectID.java
| Rule | Violation | Line |
|---|---|---|
| UselessParentheses | Useless parentheses. | 403 |
org/mycore/datamodel/niofs/MCRPath.java
| Rule | Violation | Line |
|---|---|---|
| UselessParentheses | Useless parentheses. | 319 |
| UselessParentheses | Useless parentheses. | 523 |
org/mycore/datamodel/niofs/MCRPathXML.java
| Rule | Violation | Line |
|---|---|---|
| UselessParentheses | Useless parentheses. | 79 |
org/mycore/datamodel/niofs/MCRPaths.java
| Rule | Violation | Line |
|---|---|---|
| UselessParentheses | Useless parentheses. | 60 |
org/mycore/frontend/MCRFrontendUtil.java
| Rule | Violation | Line |
|---|---|---|
| UselessParentheses | Useless parentheses. | 265 |
| UselessParentheses | Useless parentheses. | 268 |
org/mycore/frontend/MCRLayoutUtilities.java
| Rule | Violation | Line |
|---|---|---|
| UselessParentheses | Useless parentheses. | 512 |
org/mycore/frontend/basket/MCRBasket.java
| Rule | Violation | Line |
|---|---|---|
| UselessParentheses | Useless parentheses. | 208 |
| UselessParentheses | Useless parentheses. | 256 |
| UselessParentheses | Useless parentheses. | 256 |
org/mycore/frontend/basket/MCRBasketEntry.java
| Rule | Violation | Line |
|---|---|---|
| UselessParentheses | Useless parentheses. | 78 |
org/mycore/frontend/basket/MCRBasketManager.java
| Rule | Violation | Line |
|---|---|---|
| UselessParentheses | Useless parentheses. | 80 |
org/mycore/frontend/cli/MCRDeveloperCommands.java
| Rule | Violation | Line |
|---|---|---|
| UselessParentheses | Useless parentheses. | 55 |
org/mycore/frontend/export/MCRExportCollection.java
| Rule | Violation | Line |
|---|---|---|
| UselessParentheses | Useless parentheses. | 54 |
| UselessParentheses | Useless parentheses. | 54 |
org/mycore/frontend/export/MCRExportServlet.java
| Rule | Violation | Line |
|---|---|---|
| UselessParentheses | Useless parentheses. | 120 |
org/mycore/frontend/fileupload/MCRUploadHandlerIFS.java
| Rule | Violation | Line |
|---|---|---|
| UselessParentheses | Useless parentheses. | 302 |
| UselessParentheses | Useless parentheses. | 302–303 |
| UselessParentheses | Useless parentheses. | 302–303 |
| UselessParentheses | Useless parentheses. | 304 |
org/mycore/frontend/jersey/resources/MCRLocaleResource.java
| Rule | Violation | Line |
|---|---|---|
| UselessParentheses | Useless parentheses. | 54 |
org/mycore/frontend/servlets/MCRDerivateServlet.java
| Rule | Violation | Line |
|---|---|---|
| UselessParentheses | Useless parentheses. | 62 |
org/mycore/frontend/servlets/MCRDisplayHideDerivateServlet.java
| Rule | Violation | Line |
|---|---|---|
| UselessParentheses | Useless parentheses. | 48 |
org/mycore/frontend/servlets/MCRStaticXMLFileServlet.java
| Rule | Violation | Line |
|---|---|---|
| UnnecessaryFullyQualifiedName | Unnecessary use of fully qualified name 'java.io.IOException' due to existing import 'java.io.IOException' | 58 |
org/mycore/parsers/bool/MCRBooleanClauseParser.java
| Rule | Violation | Line |
|---|---|---|
| UselessParentheses | Useless parentheses. | 232 |
| UselessParentheses | Useless parentheses. | 232 |
org/mycore/services/i18n/MCRTranslation.java
| Rule | Violation | Line |
|---|---|---|
| UnnecessaryFullyQualifiedName | Unnecessary use of fully qualified name 'java.util.MissingResourceException' due to existing import 'java.util.MissingResourceException' | 173 |
org/mycore/services/packaging/MCRPackerServlet.java
| Rule | Violation | Line |
|---|---|---|
| UselessParentheses | Useless parentheses. | 83 |
org/mycore/services/queuedjob/MCRJobMaster.java
| Rule | Violation | Line |
|---|---|---|
| UselessParentheses | Useless parentheses. | 326 |
org/mycore/services/queuedjob/MCRJobQueue.java
| Rule | Violation | Line |
|---|---|---|
| UselessParentheses | Useless parentheses. | 208 |
| UselessParentheses | Useless parentheses. | 208 |
Files
org/mycore/access/mcrimpl/MCRGroupClause.java
| Rule | Violation | Priority | Line |
|---|---|---|---|
| UselessParentheses | Useless parentheses. | 4 | 62 |
org/mycore/access/mcrimpl/MCRRuleParser.java
| Rule | Violation | Priority | Line |
|---|---|---|---|
| UnnecessaryFullyQualifiedName | Unnecessary use of fully qualified name 'java.text.ParseException' due to existing import 'java.text.ParseException' | 4 | 43 |
org/mycore/access/mcrimpl/MCRUserClause.java
| Rule | Violation | Priority | Line |
|---|---|---|---|
| UselessParentheses | Useless parentheses. | 4 | 85 |
org/mycore/backend/jpa/access/MCRJPAAccessStore.java
| Rule | Violation | Priority | Line |
|---|---|---|---|
| EmptyCatchBlock | Avoid empty catch blocks | 3 | 181–183 |
org/mycore/common/MCRCalendar.java
| Rule | Violation | Priority | Line |
|---|---|---|---|
| UselessParentheses | Useless parentheses. | 4 | 283 |
| UselessParentheses | Useless parentheses. | 4 | 286 |
| UselessParentheses | Useless parentheses. | 4 | 286 |
| UselessParentheses | Useless parentheses. | 4 | 288 |
| UselessParentheses | Useless parentheses. | 4 | 288 |
| UselessParentheses | Useless parentheses. | 4 | 808 |
| UselessParentheses | Useless parentheses. | 4 | 855 |
org/mycore/common/MCRConstants.java
| Rule | Violation | Priority | Line |
|---|---|---|---|
| UselessParentheses | Useless parentheses. | 4 | 157 |
org/mycore/common/MCRExceptionCauseFinder.java
| Rule | Violation | Priority | Line |
|---|---|---|---|
| UselessParentheses | Useless parentheses. | 4 | 36 |
| UselessParentheses | Useless parentheses. | 4 | 41 |
org/mycore/common/MCRGeoUtilities.java
| Rule | Violation | Priority | Line |
|---|---|---|---|
| UselessParentheses | Useless parentheses. | 4 | 35 |
| UselessParentheses | Useless parentheses. | 4 | 35 |
| UselessParentheses | Useless parentheses. | 4 | 44 |
| UselessParentheses | Useless parentheses. | 4 | 61 |
| UselessParentheses | Useless parentheses. | 4 | 61 |
| UselessParentheses | Useless parentheses. | 4 | 84 |
org/mycore/common/MCRMailer.java
| Rule | Violation | Priority | Line |
|---|---|---|---|
| UselessParentheses | Useless parentheses. | 4 | 395 |
| UnnecessaryFullyQualifiedName | Unnecessary use of fully qualified name 'jakarta.mail.Authenticator' due to existing import 'jakarta.mail.Authenticator' | 4 | 778 |
org/mycore/common/MCRSessionMgr.java
| Rule | Violation | Priority | Line |
|---|---|---|---|
| UnusedPrivateMethod | Avoid unused private methods such as 'checkSessionLock()'. | 3 | 91 |
org/mycore/common/config/MCRConfigurationDir.java
| Rule | Violation | Priority | Line |
|---|---|---|---|
| EmptyCatchBlock | Avoid empty catch blocks | 3 | 238–240 |
org/mycore/common/content/MCRPathContent.java
| Rule | Violation | Priority | Line |
|---|---|---|---|
| UnusedPrivateField | Avoid unused private fields such as 'LOGGER'. | 3 | 47 |
| UnusedPrivateField | Avoid unused private fields such as 'BUFFER_SIZE'. | 3 | 53 |
org/mycore/common/content/transformer/MCRToPrettyXML.java
| Rule | Violation | Priority | Line |
|---|---|---|---|
| UselessParentheses | Useless parentheses. | 4 | 41 |
org/mycore/common/content/transformer/MCRXSLTransformer.java
| Rule | Violation | Priority | Line |
|---|---|---|---|
| UselessParentheses | Useless parentheses. | 4 | 367 |
| UnusedFormalParameter | Avoid unused method parameters such as 'content'. | 3 | 387 |
| EmptyCatchBlock | Avoid empty catch blocks | 3 | 423–425 |
org/mycore/common/content/util/MCRRestContentHelper.java
| Rule | Violation | Priority | Line |
|---|---|---|---|
| EmptyCatchBlock | Avoid empty catch blocks | 3 | 173–175 |
org/mycore/common/content/util/MCRServletContentHelper.java
| Rule | Violation | Priority | Line |
|---|---|---|---|
| EmptyCatchBlock | Avoid empty catch blocks | 3 | 174–176 |
| CollapsibleIfStatements | These nested if statements could be combined | 3 | 267–285 |
| CollapsibleIfStatements | These nested if statements could be combined | 3 | 303–308 |
| CollapsibleIfStatements | These nested if statements could be combined | 3 | 365–369 |
| EmptyCatchBlock | Avoid empty catch blocks | 3 | 426–428 |
org/mycore/common/events/MCRServletContainerInitializer.java
| Rule | Violation | Priority | Line |
|---|---|---|---|
| UselessParentheses | Useless parentheses. | 4 | 95 |
org/mycore/common/xml/MCRAttributeValueFilter.java
| Rule | Violation | Priority | Line |
|---|---|---|---|
| UselessParentheses | Useless parentheses. | 4 | 49 |
org/mycore/common/xml/MCRLayoutService.java
| Rule | Violation | Priority | Line |
|---|---|---|---|
| UnusedFormalParameter | Avoid unused method parameters such as 'filename'. | 3 | 230 |
org/mycore/common/xml/MCRNodeBuilder.java
| Rule | Violation | Priority | Line |
|---|---|---|---|
| UselessParentheses | Useless parentheses. | 4 | 203 |
| UselessParentheses | Useless parentheses. | 4 | 203 |
| UselessParentheses | Useless parentheses. | 4 | 205 |
| UselessParentheses | Useless parentheses. | 4 | 205 |
| UselessParentheses | Useless parentheses. | 4 | 252 |
| UselessParentheses | Useless parentheses. | 4 | 252 |
| UselessParentheses | Useless parentheses. | 4 | 262 |
org/mycore/common/xml/MCRURIResolver.java
| Rule | Violation | Priority | Line |
|---|---|---|---|
| UnnecessaryFullyQualifiedName | Unnecessary use of fully qualified name 'org.apache.logging.log4j.Logger' due to existing import 'org.apache.logging.log4j.Logger' | 4 | 451 |
| EmptyCatchBlock | Avoid empty catch blocks | 3 | 795–797 |
org/mycore/common/xml/MCRXPathBuilder.java
| Rule | Violation | Priority | Line |
|---|---|---|---|
| UselessParentheses | Useless parentheses. | 4 | 85 |
| UselessParentheses | Useless parentheses. | 4 | 85 |
| UselessParentheses | Useless parentheses. | 4 | 111 |
| UselessParentheses | Useless parentheses. | 4 | 120 |
| UselessParentheses | Useless parentheses. | 4 | 120 |
org/mycore/common/xsl/MCRParameterCollector.java
| Rule | Violation | Priority | Line |
|---|---|---|---|
| UselessParentheses | Useless parentheses. | 4 | 168 |
| OverrideBothEqualsAndHashcode | Ensure you override both equals() and hashCode() | 3 | 357 |
org/mycore/crypt/MCRAESCipher.java
| Rule | Violation | Priority | Line |
|---|---|---|---|
| UselessParentheses | Useless parentheses. | 4 | 96 |
org/mycore/datamodel/classifications2/impl/MCRCategLinkServiceImpl.java
| Rule | Violation | Priority | Line |
|---|---|---|---|
| UnnecessaryFullyQualifiedName | Unnecessary use of fully qualified name 'jakarta.persistence.Query' due to existing import 'jakarta.persistence.Query' | 4 | 157 |
org/mycore/datamodel/classifications2/impl/MCRCategoryDAOImpl.java
| Rule | Violation | Priority | Line |
|---|---|---|---|
| EmptyCatchBlock | Avoid empty catch blocks | 3 | 144–147 |
org/mycore/datamodel/common/MCRDataURL.java
| Rule | Violation | Priority | Line |
|---|---|---|---|
| CollapsibleIfStatements | These nested if statements could be combined | 3 | 183–189 |
| UnusedFormalParameter | Avoid unused constructor parameters such as 'mimeType'. | 3 | 419 |
org/mycore/datamodel/common/MCRDefaultXMLMetadataManager.java
| Rule | Violation | Priority | Line |
|---|---|---|---|
| UselessParentheses | Useless parentheses. | 4 | 180 |
org/mycore/datamodel/common/MCRISO8601Date.java
| Rule | Violation | Priority | Line |
|---|---|---|---|
| OverrideBothEqualsAndHashcode | Ensure you override both equals() and hashCode() | 3 | 282 |
org/mycore/datamodel/common/MCRMarkManager.java
| Rule | Violation | Priority | Line |
|---|---|---|---|
| DoubleCheckedLocking | Double checked locking is not thread safe in Java. | 1 | 94–104 |
org/mycore/datamodel/ifs2/MCRFileCollection.java
| Rule | Violation | Priority | Line |
|---|---|---|---|
| EmptyCatchBlock | Avoid empty catch blocks | 3 | 143–145 |
org/mycore/datamodel/ifs2/MCRStore.java
| Rule | Violation | Priority | Line |
|---|---|---|---|
| EmptyCatchBlock | Avoid empty catch blocks | 3 | 487–489 |
org/mycore/datamodel/ifs2/MCRVersioningMetadataStore.java
| Rule | Violation | Priority | Line |
|---|---|---|---|
| UselessParentheses | Useless parentheses. | 4 | 103 |
org/mycore/datamodel/ifs/MCRFileNodeServlet.java
| Rule | Violation | Priority | Line |
|---|---|---|---|
| UnusedFormalParameter | Avoid unused method parameters such as 'request'. | 3 | 160 |
| UnusedFormalParameter | Avoid unused method parameters such as 'response'. | 3 | 160 |
org/mycore/datamodel/language/MCRLanguageFactory.java
| Rule | Violation | Priority | Line |
|---|---|---|---|
| UselessParentheses | Useless parentheses. | 4 | 119 |
| UselessParentheses | Useless parentheses. | 4 | 162 |
| UselessParentheses | Useless parentheses. | 4 | 163 |
| UnusedLocalVariable | Avoid unused local variables such as 'session'. | 3 | 232 |
org/mycore/datamodel/language/MCRLanguageXML.java
| Rule | Violation | Priority | Line |
|---|---|---|---|
| UselessParentheses | Useless parentheses. | 4 | 54 |
| UselessParentheses | Useless parentheses. | 4 | 58 |
org/mycore/datamodel/metadata/MCRMetaAddress.java
| Rule | Violation | Priority | Line |
|---|---|---|---|
| OverrideBothEqualsAndHashcode | Ensure you override both equals() and hashCode() | 3 | 216 |
org/mycore/datamodel/metadata/MCRMetaBoolean.java
| Rule | Violation | Priority | Line |
|---|---|---|---|
| UnusedFormalParameter | Avoid unused constructor parameters such as 'lang'. | 3 | 74 |
| OverrideBothEqualsAndHashcode | Ensure you override both equals() and hashCode() | 3 | 233 |
org/mycore/datamodel/metadata/MCRMetaClassification.java
| Rule | Violation | Priority | Line |
|---|---|---|---|
| OverrideBothEqualsAndHashcode | Ensure you override both equals() and hashCode() | 3 | 242 |
org/mycore/datamodel/metadata/MCRMetaDateLangText.java
| Rule | Violation | Priority | Line |
|---|---|---|---|
| OverrideBothEqualsAndHashcode | Ensure you override both equals() and hashCode() | 3 | 195 |
org/mycore/datamodel/metadata/MCRMetaElement.java
| Rule | Violation | Priority | Line |
|---|---|---|---|
| UselessParentheses | Useless parentheses. | 4 | 129 |
| UselessParentheses | Useless parentheses. | 4 | 129 |
| UselessParentheses | Useless parentheses. | 4 | 252 |
| UselessParentheses | Useless parentheses. | 4 | 252 |
| UselessParentheses | Useless parentheses. | 4 | 355 |
| UselessParentheses | Useless parentheses. | 4 | 386 |
| UselessParentheses | Useless parentheses. | 4 | 456 |
org/mycore/datamodel/metadata/MCRMetaEnrichedLinkID.java
| Rule | Violation | Priority | Line |
|---|---|---|---|
| UselessParentheses | Useless parentheses. | 4 | 181–182 |
org/mycore/datamodel/metadata/MCRMetaHistoryDate.java
| Rule | Violation | Priority | Line |
|---|---|---|---|
| UselessParentheses | Useless parentheses. | 4 | 229 |
| OverrideBothEqualsAndHashcode | Ensure you override both equals() and hashCode() | 3 | 534 |
| EmptyCatchBlock | Avoid empty catch blocks | 3 | 667–669 |
org/mycore/datamodel/metadata/MCRMetaIFS.java
| Rule | Violation | Priority | Line |
|---|---|---|---|
| OverrideBothEqualsAndHashcode | Ensure you override both equals() and hashCode() | 3 | 230 |
org/mycore/datamodel/metadata/MCRMetaISO8601Date.java
| Rule | Violation | Priority | Line |
|---|---|---|---|
| OverrideBothEqualsAndHashcode | Ensure you override both equals() and hashCode() | 3 | 256 |
org/mycore/datamodel/metadata/MCRMetaInstitutionName.java
| Rule | Violation | Priority | Line |
|---|---|---|---|
| OverrideBothEqualsAndHashcode | Ensure you override both equals() and hashCode() | 3 | 249 |
org/mycore/datamodel/metadata/MCRMetaLangText.java
| Rule | Violation | Priority | Line |
|---|---|---|---|
| OverrideBothEqualsAndHashcode | Ensure you override both equals() and hashCode() | 3 | 285 |
org/mycore/datamodel/metadata/MCRMetaLink.java
| Rule | Violation | Priority | Line |
|---|---|---|---|
| CollapsibleIfStatements | These nested if statements could be combined | 3 | 238–240 |
| CollapsibleIfStatements | These nested if statements could be combined | 3 | 408–410 |
| CollapsibleIfStatements | These nested if statements could be combined | 3 | 432–434 |
org/mycore/datamodel/metadata/MCRMetaLinkID.java
| Rule | Violation | Priority | Line |
|---|---|---|---|
| OverrideBothEqualsAndHashcode | Ensure you override both equals() and hashCode() | 3 | 241 |
org/mycore/datamodel/metadata/MCRMetaNumber.java
| Rule | Violation | Priority | Line |
|---|---|---|---|
| BigIntegerInstantiation | Dont create instances of already existing BigInteger and BigDecimal (ZERO, ONE, TEN) | 3 | 105 |
| OverrideBothEqualsAndHashcode | Ensure you override both equals() and hashCode() | 3 | 351 |
org/mycore/datamodel/metadata/MCRMetaPersonName.java
| Rule | Violation | Priority | Line |
|---|---|---|---|
| OverrideBothEqualsAndHashcode | Ensure you override both equals() and hashCode() | 3 | 444 |
org/mycore/datamodel/metadata/MCRMetaXML.java
| Rule | Violation | Priority | Line |
|---|---|---|---|
| OverrideBothEqualsAndHashcode | Ensure you override both equals() and hashCode() | 3 | 185 |
org/mycore/datamodel/metadata/MCRMetadataManager.java
| Rule | Violation | Priority | Line |
|---|---|---|---|
| UselessParentheses | Useless parentheses. | 4 | 854 |
org/mycore/datamodel/metadata/MCRObjectDerivate.java
| Rule | Violation | Priority | Line |
|---|---|---|---|
| UselessParentheses | Useless parentheses. | 4 | 195 |
| UselessParentheses | Useless parentheses. | 4 | 195 |
| UselessParentheses | Useless parentheses. | 4 | 217 |
| UselessParentheses | Useless parentheses. | 4 | 217 |
| UselessParentheses | Useless parentheses. | 4 | 459 |
| UselessParentheses | Useless parentheses. | 4 | 459 |
org/mycore/datamodel/metadata/MCRObjectID.java
| Rule | Violation | Priority | Line |
|---|---|---|---|
| UselessParentheses | Useless parentheses. | 4 | 403 |
org/mycore/datamodel/metadata/validator/MCREditorOutValidator.java
| Rule | Violation | Priority | Line |
|---|---|---|---|
| BrokenNullCheck | Method call on object which may be null | 2 | 205–208 |
org/mycore/datamodel/niofs/MCRPath.java
| Rule | Violation | Priority | Line |
|---|---|---|---|
| UselessParentheses | Useless parentheses. | 4 | 319 |
| UselessParentheses | Useless parentheses. | 4 | 523 |
org/mycore/datamodel/niofs/MCRPathUtils.java
| Rule | Violation | Priority | Line |
|---|---|---|---|
| EmptyCatchBlock | Avoid empty catch blocks | 3 | 64–66 |
org/mycore/datamodel/niofs/MCRPathXML.java
| Rule | Violation | Priority | Line |
|---|---|---|---|
| UselessParentheses | Useless parentheses. | 4 | 79 |
org/mycore/datamodel/niofs/MCRPaths.java
| Rule | Violation | Priority | Line |
|---|---|---|---|
| UselessParentheses | Useless parentheses. | 4 | 60 |
org/mycore/datamodel/niofs/utils/MCRTreeCopier.java
| Rule | Violation | Priority | Line |
|---|---|---|---|
| EmptyCatchBlock | Avoid empty catch blocks | 3 | 78–81 |
org/mycore/frontend/MCRFrontendUtil.java
| Rule | Violation | Priority | Line |
|---|---|---|---|
| AvoidUsingHardCodedIP | Do not hard code the IP address | 3 | 72 |
| AvoidUsingHardCodedIP | Do not hard code the IP address | 3 | 75 |
| UselessParentheses | Useless parentheses. | 4 | 265 |
| UselessParentheses | Useless parentheses. | 4 | 268 |
org/mycore/frontend/MCRLayoutUtilities.java
| Rule | Violation | Priority | Line |
|---|---|---|---|
| UselessParentheses | Useless parentheses. | 4 | 512 |
org/mycore/frontend/basket/MCRBasket.java
| Rule | Violation | Priority | Line |
|---|---|---|---|
| UselessParentheses | Useless parentheses. | 4 | 208 |
| UselessParentheses | Useless parentheses. | 4 | 256 |
| UselessParentheses | Useless parentheses. | 4 | 256 |
org/mycore/frontend/basket/MCRBasketEntry.java
| Rule | Violation | Priority | Line |
|---|---|---|---|
| UselessParentheses | Useless parentheses. | 4 | 78 |
org/mycore/frontend/basket/MCRBasketManager.java
| Rule | Violation | Priority | Line |
|---|---|---|---|
| UselessParentheses | Useless parentheses. | 4 | 80 |
org/mycore/frontend/cli/MCRBatchEditorCommands.java
| Rule | Violation | Priority | Line |
|---|---|---|---|
| CollapsibleIfStatements | These nested if statements could be combined | 3 | 140–142 |
org/mycore/frontend/cli/MCRCommandLineInterface.java
| Rule | Violation | Priority | Line |
|---|---|---|---|
| AvoidUsingHardCodedIP | Do not hard code the IP address | 3 | 175 |
| UnusedFormalParameter | Avoid unused method parameters such as 'session'. | 3 | 233 |
org/mycore/frontend/cli/MCRDeveloperCommands.java
| Rule | Violation | Priority | Line |
|---|---|---|---|
| UselessParentheses | Useless parentheses. | 4 | 55 |
org/mycore/frontend/export/MCRExportCollection.java
| Rule | Violation | Priority | Line |
|---|---|---|---|
| UselessParentheses | Useless parentheses. | 4 | 54 |
| UselessParentheses | Useless parentheses. | 4 | 54 |
org/mycore/frontend/export/MCRExportServlet.java
| Rule | Violation | Priority | Line |
|---|---|---|---|
| UselessParentheses | Useless parentheses. | 4 | 120 |
org/mycore/frontend/fileupload/MCRUploadHandlerIFS.java
| Rule | Violation | Priority | Line |
|---|---|---|---|
| UselessParentheses | Useless parentheses. | 4 | 302 |
| UselessParentheses | Useless parentheses. | 4 | 302–303 |
| UselessParentheses | Useless parentheses. | 4 | 302–303 |
| UselessParentheses | Useless parentheses. | 4 | 304 |
org/mycore/frontend/fileupload/MCRUploadViaFormServlet.java
| Rule | Violation | Priority | Line |
|---|---|---|---|
| UnusedLocalVariable | Avoid unused local variables such as 'session'. | 3 | 97 |
org/mycore/frontend/filter/MCRSecureTokenV2Filter.java
| Rule | Violation | Priority | Line |
|---|---|---|---|
| CollapsibleIfStatements | These nested if statements could be combined | 3 | 85–89 |
org/mycore/frontend/jersey/filter/MCRDBTransactionFilter.java
| Rule | Violation | Priority | Line |
|---|---|---|---|
| UnusedLocalVariable | Avoid unused local variables such as 'session'. | 3 | 34 |
org/mycore/frontend/jersey/resources/MCRLocaleResource.java
| Rule | Violation | Priority | Line |
|---|---|---|---|
| UselessParentheses | Useless parentheses. | 4 | 54 |
org/mycore/frontend/servlets/MCRDerivateServlet.java
| Rule | Violation | Priority | Line |
|---|---|---|---|
| UselessParentheses | Useless parentheses. | 4 | 62 |
org/mycore/frontend/servlets/MCRDisplayHideDerivateServlet.java
| Rule | Violation | Priority | Line |
|---|---|---|---|
| UselessParentheses | Useless parentheses. | 4 | 48 |
org/mycore/frontend/servlets/MCRObjectServlet.java
| Rule | Violation | Priority | Line |
|---|---|---|---|
| UnusedPrivateField | Avoid unused private fields such as 'REV_CURRENT'. | 3 | 50 |
org/mycore/frontend/servlets/MCRServlet.java
| Rule | Violation | Priority | Line |
|---|---|---|---|
| UnusedFormalParameter | Avoid unused method parameters such as 'context'. | 3 | 122 |
| UnusedLocalVariable | Avoid unused local variables such as 'session'. | 3 | 299 |
| UnusedLocalVariable | Avoid unused local variables such as 'session'. | 3 | 410 |
| UnusedLocalVariable | Avoid unused local variables such as 'session'. | 3 | 449 |
org/mycore/frontend/servlets/MCRServletJob.java
| Rule | Violation | Priority | Line |
|---|---|---|---|
| AvoidUsingHardCodedIP | Do not hard code the IP address | 3 | 75 |
org/mycore/frontend/servlets/MCRStaticXMLFileServlet.java
| Rule | Violation | Priority | Line |
|---|---|---|---|
| UnnecessaryFullyQualifiedName | Unnecessary use of fully qualified name 'java.io.IOException' due to existing import 'java.io.IOException' | 4 | 58 |
org/mycore/parsers/bool/MCRBooleanClauseParser.java
| Rule | Violation | Priority | Line |
|---|---|---|---|
| UselessParentheses | Useless parentheses. | 4 | 232 |
| UselessParentheses | Useless parentheses. | 4 | 232 |
org/mycore/services/i18n/MCRTranslation.java
| Rule | Violation | Priority | Line |
|---|---|---|---|
| UnnecessaryFullyQualifiedName | Unnecessary use of fully qualified name 'java.util.MissingResourceException' due to existing import 'java.util.MissingResourceException' | 4 | 173 |
| EmptyCatchBlock | Avoid empty catch blocks | 3 | 173–174 |
org/mycore/services/packaging/MCRPackerServlet.java
| Rule | Violation | Priority | Line |
|---|---|---|---|
| UselessParentheses | Useless parentheses. | 4 | 83 |
org/mycore/services/queuedjob/MCRJobMaster.java
| Rule | Violation | Priority | Line |
|---|---|---|---|
| AvoidThreadGroup | Avoid using java.lang.ThreadGroup; it is not thread safe | 3 | 156 |
| UselessParentheses | Useless parentheses. | 4 | 326 |
org/mycore/services/queuedjob/MCRJobQueue.java
| Rule | Violation | Priority | Line |
|---|---|---|---|
| UselessParentheses | Useless parentheses. | 4 | 208 |
| UselessParentheses | Useless parentheses. | 4 | 208 |
org/mycore/tools/MCRTopologicalSort.java
| Rule | Violation | Priority | Line |
|---|---|---|---|
| CollapsibleIfStatements | These nested if statements could be combined | 3 | 306–309 |