SpotBugs Bug Detector Report
The following document contains the results of SpotBugs
SpotBugs Version is 4.7.1
Threshold is medium
Effort is default
Summary
| Classes |
Bugs |
Errors |
Missing Classes |
| 769 |
450 |
0 |
0 |
org.mycore.access.facts.MCRFactsAccessSystem
| Bug |
Category |
Details |
Line |
Priority |
| org.mycore.access.facts.MCRFactsAccessSystem.getProperties() may expose internal representation by returning MCRFactsAccessSystem.properties |
MALICIOUS_CODE |
EI_EXPOSE_REP |
114 |
Medium |
| org.mycore.access.facts.MCRFactsAccessSystem.setProperties(Map) may expose internal representation by storing an externally mutable object into MCRFactsAccessSystem.properties |
MALICIOUS_CODE |
EI_EXPOSE_REP2 |
119 |
Medium |
org.mycore.access.facts.MCRFactsHolder
| Bug |
Category |
Details |
Line |
Priority |
| new org.mycore.access.facts.MCRFactsHolder(Collection) may expose internal representation by storing an externally mutable object into MCRFactsHolder.computers |
MALICIOUS_CODE |
EI_EXPOSE_REP2 |
47 |
Medium |
org.mycore.access.facts.condition.MCRAbstractCondition
| Bug |
Category |
Details |
Line |
Priority |
| org.mycore.access.facts.condition.MCRAbstractCondition.getBoundElement() may expose internal representation by returning MCRAbstractCondition.boundElement |
MALICIOUS_CODE |
EI_EXPOSE_REP |
49 |
Medium |
| org.mycore.access.facts.condition.MCRAbstractCondition.parse(Element) may expose internal representation by storing an externally mutable object into MCRAbstractCondition.boundElement |
MALICIOUS_CODE |
EI_EXPOSE_REP2 |
44 |
Medium |
org.mycore.access.facts.condition.combined.MCRAbstractCombinedCondition
| Bug |
Category |
Details |
Line |
Priority |
| org.mycore.access.facts.condition.combined.MCRAbstractCombinedCondition.getChildConditions() may expose internal representation by returning MCRAbstractCombinedCondition.conditions |
MALICIOUS_CODE |
EI_EXPOSE_REP |
55 |
Medium |
org.mycore.access.mcrimpl.MCRAccessControlSystem
| Bug |
Category |
Details |
Line |
Priority |
| org.mycore.access.mcrimpl.MCRAccessControlSystem.getAccessRule(String, String) may expose internal representation by returning MCRAccessControlSystem.dummyRule |
MALICIOUS_CODE |
EI_EXPOSE_REP |
263 |
Medium |
| Public static org.mycore.access.mcrimpl.MCRAccessControlSystem.instance() may expose internal representation by returning MCRAccessControlSystem.singleton |
MALICIOUS_CODE |
MS_EXPOSE_REP |
90 |
Medium |
org.mycore.access.mcrimpl.MCRAccessDefinition
| Bug |
Category |
Details |
Line |
Priority |
| org.mycore.access.mcrimpl.MCRAccessDefinition.getPool() may expose internal representation by returning MCRAccessDefinition.pools |
MALICIOUS_CODE |
EI_EXPOSE_REP |
47 |
Medium |
| org.mycore.access.mcrimpl.MCRAccessDefinition.setPool(HashMap) may expose internal representation by storing an externally mutable object into MCRAccessDefinition.pools |
MALICIOUS_CODE |
EI_EXPOSE_REP2 |
51 |
Medium |
org.mycore.access.mcrimpl.MCRAccessRule
| Bug |
Category |
Details |
Line |
Priority |
| The class name org.mycore.access.mcrimpl.MCRAccessRule shadows the simple name of implemented interface org.mycore.access.MCRAccessRule |
BAD_PRACTICE |
NM_SAME_SIMPLE_NAME_AS_INTERFACE |
37-168 |
Medium |
org.mycore.access.mcrimpl.MCRAccessStore
| Bug |
Category |
Details |
Line |
Priority |
| Public static org.mycore.access.mcrimpl.MCRAccessStore.getInstance() may expose internal representation by returning MCRAccessStore.implementation |
MALICIOUS_CODE |
MS_EXPOSE_REP |
89 |
Medium |
org.mycore.access.mcrimpl.MCRIPAddress
| Bug |
Category |
Details |
Line |
Priority |
| org.mycore.access.mcrimpl.MCRIPAddress.getAddress() may expose internal representation by returning MCRIPAddress.address |
MALICIOUS_CODE |
EI_EXPOSE_REP |
82 |
Medium |
org.mycore.access.mcrimpl.MCRRuleStore
| Bug |
Category |
Details |
Line |
Priority |
| Public static org.mycore.access.mcrimpl.MCRRuleStore.getInstance() may expose internal representation by returning MCRRuleStore.implementation |
MALICIOUS_CODE |
MS_EXPOSE_REP |
72 |
Medium |
org.mycore.backend.jpa.MCREntityManagerProvider
| Bug |
Category |
Details |
Line |
Priority |
| Public static org.mycore.backend.jpa.MCREntityManagerProvider.getEntityManagerFactory() may expose internal representation by returning MCREntityManagerProvider.factory |
MALICIOUS_CODE |
MS_EXPOSE_REP |
34 |
Medium |
| Possible null pointer dereference of MCREntityManagerProvider.context in org.mycore.backend.jpa.MCREntityManagerProvider.getCurrentEntityManager() |
CORRECTNESS |
NP_NULL_ON_SOME_PATH |
41 |
Medium |
org.mycore.backend.jpa.MCRObjectIDPK
| Bug |
Category |
Details |
Line |
Priority |
| Class org.mycore.backend.jpa.MCRObjectIDPK defines non-transient non-serializable instance field id |
BAD_PRACTICE |
SE_BAD_FIELD |
Not available |
High |
org.mycore.backend.jpa.access.MCRACCESS
| Bug |
Category |
Details |
Line |
Priority |
| org.mycore.backend.jpa.access.MCRACCESS.getCreationdate() may expose internal representation by returning MCRACCESS.creationdate |
MALICIOUS_CODE |
EI_EXPOSE_REP |
69 |
Medium |
| org.mycore.backend.jpa.access.MCRACCESS.getKey() may expose internal representation by returning MCRACCESS.key |
MALICIOUS_CODE |
EI_EXPOSE_REP |
61 |
Medium |
| org.mycore.backend.jpa.access.MCRACCESS.getRule() may expose internal representation by returning MCRACCESS.rule |
MALICIOUS_CODE |
EI_EXPOSE_REP |
85 |
Medium |
| new org.mycore.backend.jpa.access.MCRACCESS(MCRACCESSRULE, String, String, String, Timestamp) may expose internal representation by storing an externally mutable object into MCRACCESS.creationdate |
MALICIOUS_CODE |
EI_EXPOSE_REP2 |
57 |
Medium |
| new org.mycore.backend.jpa.access.MCRACCESS(MCRACCESSRULE, String, String, String, Timestamp) may expose internal representation by storing an externally mutable object into MCRACCESS.rule |
MALICIOUS_CODE |
EI_EXPOSE_REP2 |
55 |
Medium |
| org.mycore.backend.jpa.access.MCRACCESS.setCreationdate(Timestamp) may expose internal representation by storing an externally mutable object into MCRACCESS.creationdate |
MALICIOUS_CODE |
EI_EXPOSE_REP2 |
73 |
Medium |
| org.mycore.backend.jpa.access.MCRACCESS.setKey(MCRACCESSPK) may expose internal representation by storing an externally mutable object into MCRACCESS.key |
MALICIOUS_CODE |
EI_EXPOSE_REP2 |
65 |
Medium |
| org.mycore.backend.jpa.access.MCRACCESS.setRule(MCRACCESSRULE) may expose internal representation by storing an externally mutable object into MCRACCESS.rule |
MALICIOUS_CODE |
EI_EXPOSE_REP2 |
89 |
Medium |
org.mycore.backend.jpa.access.MCRACCESSRULE
| Bug |
Category |
Details |
Line |
Priority |
| org.mycore.backend.jpa.access.MCRACCESSRULE.getCreationdate() may expose internal representation by returning MCRACCESSRULE.creationdate |
MALICIOUS_CODE |
EI_EXPOSE_REP |
49 |
Medium |
| org.mycore.backend.jpa.access.MCRACCESSRULE.setCreationdate(Timestamp) may expose internal representation by storing an externally mutable object into MCRACCESSRULE.creationdate |
MALICIOUS_CODE |
EI_EXPOSE_REP2 |
53 |
Medium |
org.mycore.backend.jpa.access.MCRACCESSRULE_
org.mycore.backend.jpa.access.MCRACCESS_
org.mycore.backend.jpa.access.MCRJPAAccessStore
| Bug |
Category |
Details |
Line |
Priority |
org.mycore.backend.jpa.access.MCRJPARuleStore
| Bug |
Category |
Details |
Line |
Priority |
org.mycore.backend.jpa.access.MCRJPARuleStore$1
| Bug |
Category |
Details |
Line |
Priority |
| org.mycore.backend.jpa.access.MCRJPARuleStore$1.load(String) may return null, but is declared @Nonnull |
CORRECTNESS |
NP_NONNULL_RETURN_VIOLATION |
72 |
Medium |
org.mycore.backend.jpa.dnbtransfer.MCRDNBTRANSFERRESULTS
| Bug |
Category |
Details |
Line |
Priority |
| org.mycore.backend.jpa.dnbtransfer.MCRDNBTRANSFERRESULTS.getDate() may expose internal representation by returning MCRDNBTRANSFERRESULTS.date |
MALICIOUS_CODE |
EI_EXPOSE_REP |
188 |
Medium |
| org.mycore.backend.jpa.dnbtransfer.MCRDNBTRANSFERRESULTS.setDate(Date) may expose internal representation by storing an externally mutable object into MCRDNBTRANSFERRESULTS.date |
MALICIOUS_CODE |
EI_EXPOSE_REP2 |
196 |
Medium |
org.mycore.backend.jpa.dnbtransfer.MCRDNBTRANSFERRESULTS_
org.mycore.backend.jpa.links.MCRLINKHREF
| Bug |
Category |
Details |
Line |
Priority |
| org.mycore.backend.jpa.links.MCRLINKHREF.getKey() may expose internal representation by returning MCRLINKHREF.key |
MALICIOUS_CODE |
EI_EXPOSE_REP |
97 |
Medium |
| org.mycore.backend.jpa.links.MCRLINKHREF.setKey(MCRLINKHREFPK) may expose internal representation by storing an externally mutable object into MCRLINKHREF.key |
MALICIOUS_CODE |
EI_EXPOSE_REP2 |
107 |
Medium |
org.mycore.backend.jpa.links.MCRLINKHREFPK_
org.mycore.backend.jpa.links.MCRLINKHREF_
org.mycore.backend.jpa.objectinfo.MCRObjectInfoEntity
| Bug |
Category |
Details |
Line |
Priority |
| org.mycore.backend.jpa.objectinfo.MCRObjectInfoEntity.getId() may expose internal representation by returning MCRObjectInfoEntity.id |
MALICIOUS_CODE |
EI_EXPOSE_REP |
57 |
Medium |
| org.mycore.backend.jpa.objectinfo.MCRObjectInfoEntity.setId(MCRObjectID) may expose internal representation by storing an externally mutable object into MCRObjectInfoEntity.id |
MALICIOUS_CODE |
EI_EXPOSE_REP2 |
61 |
Medium |
org.mycore.backend.jpa.objectinfo.MCRObjectInfoEntityQueryResolver
| Bug |
Category |
Details |
Line |
Priority |
org.mycore.common.MCRCache
| Bug |
Category |
Details |
Line |
Priority |
| org.mycore.common.MCRCache.getCapacity() is unsynchronized, org.mycore.common.MCRCache.setCapacity(long) is synchronized |
MT_CORRECTNESS |
UG_SYNC_SET_UNSYNC_GET |
230 |
Medium |
org.mycore.common.MCRCacheManager
| Bug |
Category |
Details |
Line |
Priority |
| new org.mycore.common.MCRCacheManager(MCRCache) may expose internal representation by storing an externally mutable object into MCRCacheManager.cache |
MALICIOUS_CODE |
EI_EXPOSE_REP2 |
34 |
Medium |
org.mycore.common.MCRCalendar
| Bug |
Category |
Details |
Line |
Priority |
| org.mycore.common.MCRCalendar.getCalendarDateToFormattedString(Calendar, String) uses the same code for two branches |
STYLE |
DB_DUPLICATE_BRANCHES |
928 |
Medium |
| Check for oddness that won't work for negative numbers in org.mycore.common.MCRCalendar.getCalendarFromIslamicDate(String, boolean) |
STYLE |
IM_BAD_CHECK_FOR_ODD |
418 |
Medium |
org.mycore.common.MCRClassTools
| Bug |
Category |
Details |
Line |
Priority |
| org.mycore.common.MCRClassTools.loadClassFromURL(File, String) creates a java.net.URLClassLoader classloader, which should be performed within a doPrivileged block |
MALICIOUS_CODE |
DP_CREATE_CLASSLOADER_INSIDE_DO_PRIVILEGED |
43 |
Medium |
| Public static org.mycore.common.MCRClassTools.getClassLoader() may expose internal representation by returning MCRClassTools.extendedClassLoader |
MALICIOUS_CODE |
MS_EXPOSE_REP |
74 |
Medium |
org.mycore.common.MCRCrypt
org.mycore.common.MCRExceptionCauseFinder
| Bug |
Category |
Details |
Line |
Priority |
| Unchecked/unconfirmed cast from Throwable to Exception in org.mycore.common.MCRExceptionCauseFinder.getCause(Throwable) |
STYLE |
BC_UNCONFIRMED_CAST |
41 |
Medium |
org.mycore.common.MCRGeoUtilities
org.mycore.common.MCRJSONManager
| Bug |
Category |
Details |
Line |
Priority |
| org.mycore.common.MCRJSONManager.getGsonBuilder() may expose internal representation by returning MCRJSONManager.gsonBuilder |
MALICIOUS_CODE |
EI_EXPOSE_REP |
45 |
Medium |
org.mycore.common.MCRLanguageDetector
| Bug |
Category |
Details |
Line |
Priority |
| org.mycore.common.MCRLanguageDetector.getCodeWithMaxScore(Map) makes inefficient use of keySet iterator instead of entrySet iterator |
PERFORMANCE |
WMI_WRONG_MAP_ITERATOR |
141 |
Medium |
org.mycore.common.MCRMailer
| Bug |
Category |
Details |
Line |
Priority |
| org.mycore.common.MCRMailer.numTries isn't final but should be |
MALICIOUS_CODE |
MS_SHOULD_BE_FINAL |
120 |
Medium |
org.mycore.common.MCRSession
| Bug |
Category |
Details |
Line |
Priority |
| Class org.mycore.common.MCRSession implements Cloneable but does not define or use clone method |
BAD_PRACTICE |
CN_IDIOM |
69-485 |
Medium |
| org.mycore.common.MCRSession.getConstructingStackTrace() may expose internal representation by returning MCRSession.constructingStackTrace |
MALICIOUS_CODE |
EI_EXPOSE_REP |
410 |
Medium |
| org.mycore.common.MCRSession.getMapEntries() may expose internal representation by returning MCRSession.mapEntries |
MALICIOUS_CODE |
EI_EXPOSE_REP |
210 |
Medium |
org.mycore.common.MCRSessionMgr
| Bug |
Category |
Details |
Line |
Priority |
| Public static org.mycore.common.MCRSessionMgr.getAllSessions() may expose internal representation by returning MCRSessionMgr.sessions |
MALICIOUS_CODE |
MS_EXPOSE_REP |
259 |
Medium |
org.mycore.common.MCRTextResolver
| Bug |
Category |
Details |
Line |
Priority |
| org.mycore.common.MCRTextResolver.getVariables() may expose internal representation by returning MCRTextResolver.variablesMap |
MALICIOUS_CODE |
EI_EXPOSE_REP |
292 |
Medium |
org.mycore.common.MCRTextResolver$CircularDependencyExecption
| Bug |
Category |
Details |
Line |
Priority |
| org.mycore.common.MCRTextResolver$CircularDependencyExecption.getDependencyList() may expose internal representation by returning MCRTextResolver$CircularDependencyExecption.dependencyList |
MALICIOUS_CODE |
EI_EXPOSE_REP |
737 |
Medium |
| new org.mycore.common.MCRTextResolver$CircularDependencyExecption(List, String) may expose internal representation by storing an externally mutable object into MCRTextResolver$CircularDependencyExecption.dependencyList |
MALICIOUS_CODE |
EI_EXPOSE_REP2 |
717 |
Medium |
org.mycore.common.MCRTextResolver$CircularDependencyTracker
| Bug |
Category |
Details |
Line |
Priority |
| new org.mycore.common.MCRTextResolver$CircularDependencyTracker(MCRTextResolver) may expose internal representation by storing an externally mutable object into MCRTextResolver$CircularDependencyTracker.textResolver |
MALICIOUS_CODE |
EI_EXPOSE_REP2 |
681 |
Medium |
| Unread public/protected field: org.mycore.common.MCRTextResolver$CircularDependencyTracker.textResolver |
STYLE |
URF_UNREAD_PUBLIC_OR_PROTECTED_FIELD |
681 |
Medium |
org.mycore.common.MCRTextResolver$Term
| Bug |
Category |
Details |
Line |
Priority |
| org.mycore.common.MCRTextResolver$Term.getTextResolver() may expose internal representation by returning MCRTextResolver$Term.textResolver |
MALICIOUS_CODE |
EI_EXPOSE_REP |
427 |
Medium |
| new org.mycore.common.MCRTextResolver$Term(MCRTextResolver) may expose internal representation by storing an externally mutable object into MCRTextResolver$Term.textResolver |
MALICIOUS_CODE |
EI_EXPOSE_REP2 |
329 |
Medium |
org.mycore.common.MCRTextResolver$TermContainer
| Bug |
Category |
Details |
Line |
Priority |
| new org.mycore.common.MCRTextResolver$TermContainer(MCRTextResolver) may expose internal representation by storing an externally mutable object into MCRTextResolver$TermContainer.textResolver |
MALICIOUS_CODE |
EI_EXPOSE_REP2 |
648 |
Medium |
org.mycore.common.MCRUtils
org.mycore.common.config.MCRComponent
| Bug |
Category |
Details |
Line |
Priority |
| new org.mycore.common.config.MCRComponent(String, Manifest, File) may expose internal representation by storing an externally mutable object into MCRComponent.manifest |
MALICIOUS_CODE |
EI_EXPOSE_REP2 |
96 |
Medium |
org.mycore.common.config.MCRConfigurationBase
| Bug |
Category |
Details |
Line |
Priority |
| Comparison of String objects using == or != in org.mycore.common.config.MCRConfigurationBase.getString(String) |
BAD_PRACTICE |
ES_COMPARING_STRINGS_WITH_EQ |
235 |
High |
| Exceptional return value of java.io.File.setWritable(boolean, boolean) ignored in org.mycore.common.config.MCRConfigurationBase.createLastModifiedFile() |
BAD_PRACTICE |
RV_RETURN_VALUE_IGNORED_BAD_PRACTICE |
150 |
Medium |
| Exceptional return value of java.io.File.setWritable(boolean, boolean) ignored in org.mycore.common.config.MCRConfigurationBase.systemModified() |
BAD_PRACTICE |
RV_RETURN_VALUE_IGNORED_BAD_PRACTICE |
103 |
Medium |
org.mycore.common.config.MCRConfigurationDirSetup
| Bug |
Category |
Details |
Line |
Priority |
| org.mycore.common.config.MCRConfigurationDirSetup.lambda$loadExternalLibs$1(Set, URL) is or uses a map or set of URLs, which can be a performance hog |
PERFORMANCE |
DMI_COLLECTION_OF_URLS |
95 |
High |
| Possible null pointer dereference in org.mycore.common.config.MCRConfigurationDirSetup.getFileStream(File, File) due to return value of called method |
STYLE |
NP_NULL_ON_SOME_PATH_FROM_RETURN_VALUE |
156 |
Medium |
org.mycore.common.config.MCRConfigurationInputStream
| Bug |
Category |
Details |
Line |
Priority |
| org.mycore.common.config.MCRConfigurationInputStream.getPropertyInputStreams(String, InputStream) may fail to clean up java.io.InputStream |
EXPERIMENTAL |
OBL_UNSATISFIED_OBLIGATION |
145 |
Medium |
org.mycore.common.config.MCRRuntimeComponentDetector
| Bug |
Category |
Details |
Line |
Priority |
| Load of known null value in org.mycore.common.config.MCRRuntimeComponentDetector.buildComponent(Manifest, URL) |
STYLE |
NP_LOAD_OF_KNOWN_NULL_VALUE |
132 |
Medium |
| Redundant nullcheck of pi which is known to be null in org.mycore.common.config.MCRRuntimeComponentDetector.buildComponent(Manifest, URL) |
STYLE |
RCN_REDUNDANT_NULLCHECK_OF_NULL_VALUE |
132 |
Medium |
org.mycore.common.content.MCRByteContent
| Bug |
Category |
Details |
Line |
Priority |
| org.mycore.common.content.MCRByteContent.asByteArray() may expose internal representation by returning MCRByteContent.bytes |
MALICIOUS_CODE |
EI_EXPOSE_REP |
75 |
Medium |
| new org.mycore.common.content.MCRByteContent(byte[], int, int, long) may expose internal representation by storing an externally mutable object into MCRByteContent.bytes |
MALICIOUS_CODE |
EI_EXPOSE_REP2 |
56 |
Medium |
| Inconsistent synchronization of org.mycore.common.content.MCRByteContent.bytes; locked 55% of time |
MT_CORRECTNESS |
IS2_INCONSISTENT_SYNC |
101 |
Medium |
| Inconsistent synchronization of org.mycore.common.content.MCRByteContent.offset; locked 57% of time |
MT_CORRECTNESS |
IS2_INCONSISTENT_SYNC |
101 |
Medium |
org.mycore.common.content.MCRDOMContent
| Bug |
Category |
Details |
Line |
Priority |
| new org.mycore.common.content.MCRDOMContent(Document) may expose internal representation by storing an externally mutable object into MCRDOMContent.dom |
MALICIOUS_CODE |
EI_EXPOSE_REP2 |
46 |
Medium |
org.mycore.common.content.MCRJDOMContent
| Bug |
Category |
Details |
Line |
Priority |
| org.mycore.common.content.MCRJDOMContent.asXML() may expose internal representation by returning MCRJDOMContent.jdom |
MALICIOUS_CODE |
EI_EXPOSE_REP |
79 |
Medium |
| new org.mycore.common.content.MCRJDOMContent(Document) may expose internal representation by storing an externally mutable object into MCRJDOMContent.jdom |
MALICIOUS_CODE |
EI_EXPOSE_REP2 |
45 |
Medium |
org.mycore.common.content.MCRPathContent
| Bug |
Category |
Details |
Line |
Priority |
| Possible null pointer dereference in org.mycore.common.content.MCRPathContent.getName() due to return value of called method |
STYLE |
NP_NULL_ON_SOME_PATH_FROM_RETURN_VALUE |
125 |
Medium |
org.mycore.common.content.MCRSAXContent
| Bug |
Category |
Details |
Line |
Priority |
| new org.mycore.common.content.MCRSAXContent(XMLReader, InputSource) may expose internal representation by storing an externally mutable object into MCRSAXContent.inputSource |
MALICIOUS_CODE |
EI_EXPOSE_REP2 |
48 |
Medium |
| new org.mycore.common.content.MCRSAXContent(XMLReader, InputSource) may expose internal representation by storing an externally mutable object into MCRSAXContent.xmlReader |
MALICIOUS_CODE |
EI_EXPOSE_REP2 |
47 |
Medium |
org.mycore.common.content.MCRSourceContent
| Bug |
Category |
Details |
Line |
Priority |
| org.mycore.common.content.MCRSourceContent.getSource() may expose internal representation by returning MCRSourceContent.source |
MALICIOUS_CODE |
EI_EXPOSE_REP |
143 |
Medium |
| new org.mycore.common.content.MCRSourceContent(Source) may expose internal representation by storing an externally mutable object into MCRSourceContent.source |
MALICIOUS_CODE |
EI_EXPOSE_REP2 |
56 |
Medium |
org.mycore.common.content.MCRWrappedContent
| Bug |
Category |
Details |
Line |
Priority |
| org.mycore.common.content.MCRWrappedContent.getBaseContent() may expose internal representation by returning MCRWrappedContent.baseContent |
MALICIOUS_CODE |
EI_EXPOSE_REP |
50 |
Medium |
org.mycore.common.content.MCRXMLContent
| Bug |
Category |
Details |
Line |
Priority |
| org.mycore.common.content.MCRXMLContent.setFormat(Format) may expose internal representation by storing an externally mutable object into MCRXMLContent.format |
MALICIOUS_CODE |
EI_EXPOSE_REP2 |
70 |
Medium |
| org.mycore.common.content.MCRXMLContent.defaultFormat isn't final but should be |
MALICIOUS_CODE |
MS_SHOULD_BE_FINAL |
49 |
High |
org.mycore.common.content.streams.MCRByteArrayOutputStream
| Bug |
Category |
Details |
Line |
Priority |
| org.mycore.common.content.streams.MCRByteArrayOutputStream.getBuffer() may expose internal representation by returning java.io.ByteArrayOutputStream.buf |
MALICIOUS_CODE |
EI_EXPOSE_REP |
41 |
Medium |
org.mycore.common.content.streams.MCRHeaderInputStream
| Bug |
Category |
Details |
Line |
Priority |
| org.mycore.common.content.streams.MCRHeaderInputStream.getHeader() may expose internal representation by returning MCRHeaderInputStream.header |
MALICIOUS_CODE |
EI_EXPOSE_REP |
66 |
Medium |
org.mycore.common.content.transformer.MCRXSLTransformer
| Bug |
Category |
Details |
Line |
Priority |
| Dead store to el in org.mycore.common.content.transformer.MCRXSLTransformer.transform(MCRContent, OutputStream, MCRParameterCollector) |
STYLE |
DLS_DEAD_LOCAL_STORE |
232 |
Medium |
org.mycore.common.content.util.MCRServletContentHelper
| Bug |
Category |
Details |
Line |
Priority |
| content could be null and is guaranteed to be dereferenced in org.mycore.common.content.util.MCRServletContentHelper.serveContent(MCRContent, HttpServletRequest, HttpServletResponse, ServletContext, MCRServletContentHelper$Config, boolean) |
CORRECTNESS |
NP_GUARANTEED_DEREF |
121 |
Medium |
| Suspicious comparison of Boolean references in org.mycore.common.content.util.MCRServletContentHelper.isServeContent(HttpServletRequest) |
BAD_PRACTICE |
RC_REF_COMPARISON_BAD_PRACTICE_BOOLEAN |
76 |
Medium |
org.mycore.common.events.MCREventManager$EventHandlerProperty
| Bug |
Category |
Details |
Line |
Priority |
| Should org.mycore.common.events.MCREventManager$EventHandlerProperty be a _static_ inner class? |
PERFORMANCE |
SIC_INNER_SHOULD_BE_STATIC |
268-292 |
Medium |
org.mycore.common.events.MCRSessionEvent
| Bug |
Category |
Details |
Line |
Priority |
| org.mycore.common.events.MCRSessionEvent.getSession() may expose internal representation by returning MCRSessionEvent.session |
MALICIOUS_CODE |
EI_EXPOSE_REP |
59 |
Medium |
| new org.mycore.common.events.MCRSessionEvent(MCRSession, MCRSessionEvent$Type, int) may expose internal representation by storing an externally mutable object into MCRSessionEvent.session |
MALICIOUS_CODE |
EI_EXPOSE_REP2 |
43 |
Medium |
org.mycore.common.events.MCRShutdownHandler
| Bug |
Category |
Details |
Line |
Priority |
| Public static org.mycore.common.events.MCRShutdownHandler.getInstance() may expose internal representation by returning MCRShutdownHandler.SINGLETON |
MALICIOUS_CODE |
MS_EXPOSE_REP |
80 |
Medium |
| Write to static field org.mycore.common.events.MCRShutdownHandler.SINGLETON from instance method org.mycore.common.events.MCRShutdownHandler.shutDown() |
STYLE |
ST_WRITE_TO_STATIC_FROM_INSTANCE_METHOD |
128 |
Medium |
org.mycore.common.processing.MCRAbstractProcessable
| Bug |
Category |
Details |
Line |
Priority |
| org.mycore.common.processing.MCRAbstractProcessable.getError() may expose internal representation by returning MCRAbstractProcessable.error |
MALICIOUS_CODE |
EI_EXPOSE_REP |
112 |
Medium |
| org.mycore.common.processing.MCRAbstractProcessable.getProperties() may expose internal representation by returning MCRAbstractProcessable.properties |
MALICIOUS_CODE |
EI_EXPOSE_REP |
166 |
Medium |
| org.mycore.common.processing.MCRAbstractProcessable.setError(Throwable) may expose internal representation by storing an externally mutable object into MCRAbstractProcessable.error |
MALICIOUS_CODE |
EI_EXPOSE_REP2 |
121 |
Medium |
org.mycore.common.processing.MCRProcessableDefaultCollection
| Bug |
Category |
Details |
Line |
Priority |
| org.mycore.common.processing.MCRProcessableDefaultCollection.getProperties() may expose internal representation by returning MCRProcessableDefaultCollection.properties |
MALICIOUS_CODE |
EI_EXPOSE_REP |
95 |
Medium |
org.mycore.common.xml.MCRAttributeValueFilter
| Bug |
Category |
Details |
Line |
Priority |
| new org.mycore.common.xml.MCRAttributeValueFilter(String, Namespace, String) may expose internal representation by storing an externally mutable object into MCRAttributeValueFilter.ns |
MALICIOUS_CODE |
EI_EXPOSE_REP2 |
40 |
Medium |
| org.mycore.common.xml.MCRAttributeValueFilter doesn't override org.jdom2.filter.ElementFilter.equals(Object) |
STYLE |
EQ_DOESNT_OVERRIDE_EQUALS |
1 |
Medium |
org.mycore.common.xml.MCREntityResolver
| Bug |
Category |
Details |
Line |
Priority |
| Invocation of java.net.URL.equals(Object), which blocks to do domain name resolution, in org.mycore.common.xml.MCREntityResolver.isAbsoluteURL(String) |
PERFORMANCE |
DMI_BLOCKING_METHODS_ON_URL |
99 |
High |
org.mycore.common.xml.MCRNodeBuilder
| Bug |
Category |
Details |
Line |
Priority |
| new org.mycore.common.xml.MCRNodeBuilder(Map) may expose internal representation by storing an externally mutable object into MCRNodeBuilder.variables |
MALICIOUS_CODE |
EI_EXPOSE_REP2 |
60 |
Medium |
org.mycore.common.xml.MCRURIResolver
| Bug |
Category |
Details |
Line |
Priority |
| org.mycore.common.xml.MCRURIResolver.init(ServletContext) may expose internal static state by storing a mutable object into a static field org.mycore.common.xml.MCRURIResolver.context |
MALICIOUS_CODE |
EI_EXPOSE_STATIC_REP2 |
183 |
Medium |
| Public static org.mycore.common.xml.MCRURIResolver.getServletContext() may expose internal representation by returning MCRURIResolver.context |
MALICIOUS_CODE |
MS_EXPOSE_REP |
206 |
Medium |
| Public static org.mycore.common.xml.MCRURIResolver.instance() may expose internal representation by returning MCRURIResolver.singleton |
MALICIOUS_CODE |
MS_EXPOSE_REP |
173 |
Medium |
org.mycore.common.xml.MCRXMLResource
| Bug |
Category |
Details |
Line |
Priority |
| Invocation of java.net.URL.equals(Object), which blocks to do domain name resolution, in org.mycore.common.xml.MCRXMLResource.getResource(String, ClassLoader) |
PERFORMANCE |
DMI_BLOCKING_METHODS_ON_URL |
145 |
High |
org.mycore.common.xml.MCRXMLResource$ResourceModifiedHandle
| Bug |
Category |
Details |
Line |
Priority |
| new org.mycore.common.xml.MCRXMLResource$ResourceModifiedHandle(String, ClassLoader, long) may expose internal representation by storing an externally mutable object into MCRXMLResource$ResourceModifiedHandle.classLoader |
MALICIOUS_CODE |
EI_EXPOSE_REP2 |
225 |
Medium |
org.mycore.common.xml.MCRXPathEvaluator
| Bug |
Category |
Details |
Line |
Priority |
| new org.mycore.common.xml.MCRXPathEvaluator(Map, List) may expose internal representation by storing an externally mutable object into MCRXPathEvaluator.context |
MALICIOUS_CODE |
EI_EXPOSE_REP2 |
57 |
Medium |
| new org.mycore.common.xml.MCRXPathEvaluator(Map, List) may expose internal representation by storing an externally mutable object into MCRXPathEvaluator.variables |
MALICIOUS_CODE |
EI_EXPOSE_REP2 |
56 |
Medium |
| new org.mycore.common.xml.MCRXPathEvaluator(Map, Parent) may expose internal representation by storing an externally mutable object into MCRXPathEvaluator.variables |
MALICIOUS_CODE |
EI_EXPOSE_REP2 |
61 |
Medium |
org.mycore.common.xsl.MCRErrorListener
| Bug |
Category |
Details |
Line |
Priority |
| org.mycore.common.xsl.MCRErrorListener.getExceptionThrown() may expose internal representation by returning MCRErrorListener.exceptionThrown |
MALICIOUS_CODE |
EI_EXPOSE_REP |
49 |
Medium |
org.mycore.common.xsl.MCRXSLInfoServlet
| Bug |
Category |
Details |
Line |
Priority |
| Class org.mycore.common.xsl.MCRXSLInfoServlet defines non-transient non-serializable instance field stylesheets |
BAD_PRACTICE |
SE_BAD_FIELD |
Not available |
Medium |
org.mycore.common.xsl.MCRXSLInfoServlet$1
| Bug |
Category |
Details |
Line |
Priority |
| Possible null pointer dereference in org.mycore.common.xsl.MCRXSLInfoServlet$1.visitFile(Path, BasicFileAttributes) due to return value of called method |
STYLE |
NP_NULL_ON_SOME_PATH_FROM_RETURN_VALUE |
130 |
Medium |
org.mycore.crypt.MCRAESCipher
org.mycore.datamodel.classifications2.MCRCategLinkReference_
org.mycore.datamodel.classifications2.MCRCategLinkServiceFactory
| Bug |
Category |
Details |
Line |
Priority |
| Public static org.mycore.datamodel.classifications2.MCRCategLinkServiceFactory.getInstance() may expose internal representation by returning MCRCategLinkServiceFactory.instance |
MALICIOUS_CODE |
MS_EXPOSE_REP |
39 |
Medium |
org.mycore.datamodel.classifications2.MCRCategoryDAOFactory
| Bug |
Category |
Details |
Line |
Priority |
| Public static org.mycore.datamodel.classifications2.MCRCategoryDAOFactory.getInstance() may expose internal representation by returning MCRCategoryDAOFactory.INSTANCE |
MALICIOUS_CODE |
MS_EXPOSE_REP |
39 |
Medium |
org.mycore.datamodel.classifications2.MCRCategoryID_
org.mycore.datamodel.classifications2.MCRLabel
| Bug |
Category |
Details |
Line |
Priority |
| Comparison of String objects using == or != in org.mycore.datamodel.classifications2.MCRLabel.compareTo(MCRLabel) |
BAD_PRACTICE |
ES_COMPARING_STRINGS_WITH_EQ |
203 |
Medium |
org.mycore.datamodel.classifications2.MCRLabel_
org.mycore.datamodel.classifications2.impl.MCRAbstractCategoryImpl
| Bug |
Category |
Details |
Line |
Priority |
| org.mycore.datamodel.classifications2.impl.MCRAbstractCategoryImpl.getId() may expose internal representation by returning MCRAbstractCategoryImpl.id |
MALICIOUS_CODE |
EI_EXPOSE_REP |
96 |
Medium |
| org.mycore.datamodel.classifications2.impl.MCRAbstractCategoryImpl.getParent() may expose internal representation by returning MCRAbstractCategoryImpl.parent |
MALICIOUS_CODE |
EI_EXPOSE_REP |
140 |
Medium |
| org.mycore.datamodel.classifications2.impl.MCRAbstractCategoryImpl.getRoot() may expose internal representation by returning MCRAbstractCategoryImpl.root |
MALICIOUS_CODE |
EI_EXPOSE_REP |
114 |
Medium |
| org.mycore.datamodel.classifications2.impl.MCRAbstractCategoryImpl.setId(MCRCategoryID) may expose internal representation by storing an externally mutable object into MCRAbstractCategoryImpl.id |
MALICIOUS_CODE |
EI_EXPOSE_REP2 |
100 |
Medium |
| org.mycore.datamodel.classifications2.impl.MCRAbstractCategoryImpl.setParent(MCRCategory) may expose internal representation by storing an externally mutable object into MCRAbstractCategoryImpl.parent |
MALICIOUS_CODE |
EI_EXPOSE_REP2 |
148 |
Medium |
org.mycore.datamodel.classifications2.impl.MCRCategLinkServiceImpl
| Bug |
Category |
Details |
Line |
Priority |
org.mycore.datamodel.classifications2.impl.MCRCategoryChildList
| Bug |
Category |
Details |
Line |
Priority |
| org.mycore.datamodel.classifications2.impl.MCRCategoryChildList doesn't override java.util.ArrayList.equals(Object) |
STYLE |
EQ_DOESNT_OVERRIDE_EQUALS |
1 |
Medium |
org.mycore.datamodel.classifications2.impl.MCRCategoryDTO
| Bug |
Category |
Details |
Line |
Priority |
| new org.mycore.datamodel.classifications2.impl.MCRCategoryDTO(int, URI, MCRCategoryID, int, int, int) may expose internal representation by storing an externally mutable object into MCRCategoryDTO.id |
MALICIOUS_CODE |
EI_EXPOSE_REP2 |
69 |
Medium |
org.mycore.datamodel.classifications2.impl.MCRCategoryImpl
| Bug |
Category |
Details |
Line |
Priority |
| org.mycore.datamodel.classifications2.impl.MCRCategoryImpl.setRoot(MCRCategory) may expose internal representation by storing an externally mutable object into MCRCategoryImpl.root |
MALICIOUS_CODE |
EI_EXPOSE_REP2 |
327 |
Medium |
org.mycore.datamodel.classifications2.impl.MCRCategoryImpl_
org.mycore.datamodel.classifications2.impl.MCRCategoryLinkImpl
| Bug |
Category |
Details |
Line |
Priority |
| org.mycore.datamodel.classifications2.impl.MCRCategoryLinkImpl.getCategory() may expose internal representation by returning MCRCategoryLinkImpl.category |
MALICIOUS_CODE |
EI_EXPOSE_REP |
141 |
Medium |
| org.mycore.datamodel.classifications2.impl.MCRCategoryLinkImpl.getObjectReference() may expose internal representation by returning MCRCategoryLinkImpl.objectReference |
MALICIOUS_CODE |
EI_EXPOSE_REP |
150 |
Medium |
| org.mycore.datamodel.classifications2.impl.MCRCategoryLinkImpl.setCategory(MCRCategoryImpl) may expose internal representation by storing an externally mutable object into MCRCategoryLinkImpl.category |
MALICIOUS_CODE |
EI_EXPOSE_REP2 |
145 |
Medium |
| org.mycore.datamodel.classifications2.impl.MCRCategoryLinkImpl.setObjectReference(MCRCategLinkReference) may expose internal representation by storing an externally mutable object into MCRCategoryLinkImpl.objectReference |
MALICIOUS_CODE |
EI_EXPOSE_REP2 |
154 |
Medium |
org.mycore.datamodel.classifications2.impl.MCRCategoryLinkImpl_
org.mycore.datamodel.classifications2.model.MCRClass
| Bug |
Category |
Details |
Line |
Priority |
| org.mycore.datamodel.classifications2.model.MCRClass.getCategories() may expose internal representation by returning MCRClass.categories |
MALICIOUS_CODE |
EI_EXPOSE_REP |
92 |
Medium |
| org.mycore.datamodel.classifications2.model.MCRClass.getLabel() may expose internal representation by returning MCRClass.label |
MALICIOUS_CODE |
EI_EXPOSE_REP |
79 |
Medium |
| org.mycore.datamodel.classifications2.model.MCRClass.getUrl() may expose internal representation by returning MCRClass.url |
MALICIOUS_CODE |
EI_EXPOSE_REP |
83 |
Medium |
| org.mycore.datamodel.classifications2.model.MCRClass.setCategories(List) may expose internal representation by storing an externally mutable object into MCRClass.categories |
MALICIOUS_CODE |
EI_EXPOSE_REP2 |
96 |
Medium |
| org.mycore.datamodel.classifications2.model.MCRClass.setUrl(MCRClassURL) may expose internal representation by storing an externally mutable object into MCRClass.url |
MALICIOUS_CODE |
EI_EXPOSE_REP2 |
87 |
Medium |
org.mycore.datamodel.classifications2.model.MCRClassCategory
| Bug |
Category |
Details |
Line |
Priority |
| org.mycore.datamodel.classifications2.model.MCRClassCategory.getCategory() may expose internal representation by returning MCRClassCategory.category |
MALICIOUS_CODE |
EI_EXPOSE_REP |
88 |
Medium |
| org.mycore.datamodel.classifications2.model.MCRClassCategory.getLabel() may expose internal representation by returning MCRClassCategory.label |
MALICIOUS_CODE |
EI_EXPOSE_REP |
72 |
Medium |
| org.mycore.datamodel.classifications2.model.MCRClassCategory.getUrl() may expose internal representation by returning MCRClassCategory.url |
MALICIOUS_CODE |
EI_EXPOSE_REP |
76 |
Medium |
| org.mycore.datamodel.classifications2.model.MCRClassCategory.setUrl(MCRClassURL) may expose internal representation by storing an externally mutable object into MCRClassCategory.url |
MALICIOUS_CODE |
EI_EXPOSE_REP2 |
80 |
Medium |
org.mycore.datamodel.classifications2.utils.MCRXMLTransformer
| Bug |
Category |
Details |
Line |
Priority |
| Do not catch NullPointerException like in org.mycore.datamodel.classifications2.utils.MCRXMLTransformer.buildCategory(String, Element, MCRCategory) |
STYLE |
DCN_NULLPOINTER_EXCEPTION |
69 |
Medium |
| Do not catch NullPointerException like in org.mycore.datamodel.classifications2.utils.MCRXMLTransformer.getCategory(Document) |
STYLE |
DCN_NULLPOINTER_EXCEPTION |
54 |
Medium |
org.mycore.datamodel.common.MCRAbstractMetadataVersion
| Bug |
Category |
Details |
Line |
Priority |
| org.mycore.datamodel.common.MCRAbstractMetadataVersion.getDate() may expose internal representation by returning MCRAbstractMetadataVersion.date |
MALICIOUS_CODE |
EI_EXPOSE_REP |
179 |
Medium |
| new org.mycore.datamodel.common.MCRAbstractMetadataVersion(Object, String, String, Date, char) may expose internal representation by storing an externally mutable object into MCRAbstractMetadataVersion.date |
MALICIOUS_CODE |
EI_EXPOSE_REP2 |
131 |
Medium |
org.mycore.datamodel.common.MCRActiveLinkException
| Bug |
Category |
Details |
Line |
Priority |
| org.mycore.datamodel.common.MCRActiveLinkException.getActiveLinks() may expose internal representation by returning MCRActiveLinkException.linkTable |
MALICIOUS_CODE |
EI_EXPOSE_REP |
51 |
Medium |
org.mycore.datamodel.common.MCRDataURL
| Bug |
Category |
Details |
Line |
Priority |
| org.mycore.datamodel.common.MCRDataURL.getData() may expose internal representation by returning MCRDataURL.data |
MALICIOUS_CODE |
EI_EXPOSE_REP |
477 |
Medium |
| org.mycore.datamodel.common.MCRDataURL.getParameters() may expose internal representation by returning MCRDataURL.parameters |
MALICIOUS_CODE |
EI_EXPOSE_REP |
456 |
Medium |
| new org.mycore.datamodel.common.MCRDataURL(byte[], MCRDataURLEncoding, String, Charset) may expose internal representation by storing an externally mutable object into MCRDataURL.data |
MALICIOUS_CODE |
EI_EXPOSE_REP2 |
385 |
Medium |
| new org.mycore.datamodel.common.MCRDataURL(byte[], MCRDataURLEncoding, String, Map) may expose internal representation by storing an externally mutable object into MCRDataURL.data |
MALICIOUS_CODE |
EI_EXPOSE_REP2 |
349 |
Medium |
| Class org.mycore.datamodel.common.MCRDataURL defines non-transient non-serializable instance field charset |
BAD_PRACTICE |
SE_BAD_FIELD |
Not available |
Medium |
org.mycore.datamodel.common.MCRDefaultXMLMetadataManager
| Bug |
Category |
Details |
Line |
Priority |
| Inconsistent synchronization of org.mycore.datamodel.common.MCRDefaultXMLMetadataManager.defaultClass; locked 50% of time |
MT_CORRECTNESS |
IS2_INCONSISTENT_SYNC |
328 |
Medium |
| Public static org.mycore.datamodel.common.MCRDefaultXMLMetadataManager.instance() may expose internal representation by returning MCRDefaultXMLMetadataManager.SINGLETON |
MALICIOUS_CODE |
MS_EXPOSE_REP |
151 |
Medium |
| Exception is caught when Exception is not thrown in org.mycore.datamodel.common.MCRDefaultXMLMetadataManager.checkAndCreateDirectory(Path, String, String, String, boolean) |
STYLE |
REC_CATCH_EXCEPTION |
374 |
Medium |
org.mycore.datamodel.common.MCRISO8601Date
| Bug |
Category |
Details |
Line |
Priority |
| org.mycore.datamodel.common.MCRISO8601Date defines equals and uses Object.hashCode() |
BAD_PRACTICE |
HE_EQUALS_USE_HASHCODE |
283-290 |
High |
org.mycore.datamodel.common.MCRISO8601FormatChooser
| Bug |
Category |
Details |
Line |
Priority |
| Switch statement found in org.mycore.datamodel.common.MCRISO8601FormatChooser.getFormatterForDuration(String) where one case falls through to the next case |
STYLE |
SF_SWITCH_FALLTHROUGH |
136-138 |
Medium |
org.mycore.datamodel.common.MCRLinkTableManager
| Bug |
Category |
Details |
Line |
Priority |
| Public static org.mycore.datamodel.common.MCRLinkTableManager.instance() may expose internal representation by returning MCRLinkTableManager.singleton |
MALICIOUS_CODE |
MS_EXPOSE_REP |
87 |
Medium |
| org.mycore.datamodel.common.MCRLinkTableManager.singleton should be package protected |
MALICIOUS_CODE |
MS_PKGPROTECT |
Not available |
Medium |
org.mycore.datamodel.common.MCRMarkManager
| Bug |
Category |
Details |
Line |
Priority |
| Possible double-check on org.mycore.datamodel.common.MCRMarkManager.INSTANCE in org.mycore.datamodel.common.MCRMarkManager.instance() |
MT_CORRECTNESS |
DC_DOUBLECHECK |
95-98 |
Medium |
| Public static org.mycore.datamodel.common.MCRMarkManager.instance() may expose internal representation by returning MCRMarkManager.INSTANCE |
MALICIOUS_CODE |
MS_EXPOSE_REP |
103 |
Medium |
org.mycore.datamodel.common.MCRObjectMerger
| Bug |
Category |
Details |
Line |
Priority |
| org.mycore.datamodel.common.MCRObjectMerger.get() may expose internal representation by returning MCRObjectMerger.target |
MALICIOUS_CODE |
EI_EXPOSE_REP |
117 |
Medium |
org.mycore.datamodel.common.MCRXMLMetadataManager
| Bug |
Category |
Details |
Line |
Priority |
| Public static org.mycore.datamodel.common.MCRXMLMetadataManager.instance() may expose internal representation by returning MCRXMLMetadataManager.SINGLETON |
MALICIOUS_CODE |
MS_EXPOSE_REP |
70 |
Medium |
org.mycore.datamodel.ifs.MCRContentInputStream
| Bug |
Category |
Details |
Line |
Priority |
| org.mycore.datamodel.ifs.MCRContentInputStream.getHeader() may expose internal representation by returning MCRContentInputStream.header |
MALICIOUS_CODE |
EI_EXPOSE_REP |
146 |
Medium |
| org.mycore.datamodel.ifs.MCRContentInputStream.getMD5() may expose internal representation by returning MCRContentInputStream.md5 |
MALICIOUS_CODE |
EI_EXPOSE_REP |
168 |
Medium |
org.mycore.datamodel.ifs.MCRFileNodeServlet
| Bug |
Category |
Details |
Line |
Priority |
| Possible null pointer dereference in org.mycore.datamodel.ifs.MCRFileNodeServlet.sendDirectory(HttpServletRequest, HttpServletResponse, MCRPath) due to return value of called method |
STYLE |
NP_NULL_ON_SOME_PATH_FROM_RETURN_VALUE |
175 |
Medium |
| Null passed for non-null parameter of org.mycore.datamodel.metadata.MCRObjectID.getInstance(String) in org.mycore.datamodel.ifs.MCRFileNodeServlet.getContent(HttpServletRequest, HttpServletResponse) |
CORRECTNESS |
NP_NULL_PARAM_DEREF |
82 |
Medium |
org.mycore.datamodel.ifs2.MCRDirectory
| Bug |
Category |
Details |
Line |
Priority |
| Possible null pointer dereference in org.mycore.datamodel.ifs2.MCRDirectory.buildChildNode(Path) due to return value of called method |
STYLE |
NP_NULL_ON_SOME_PATH_FROM_RETURN_VALUE |
121 |
Medium |
org.mycore.datamodel.ifs2.MCRFileCollection
| Bug |
Category |
Details |
Line |
Priority |
| org.mycore.datamodel.ifs2.MCRFileCollection.getStore() may expose internal representation by returning MCRFileCollection.store |
MALICIOUS_CODE |
EI_EXPOSE_REP |
189 |
Medium |
org.mycore.datamodel.ifs2.MCRFileStore
| Bug |
Category |
Details |
Line |
Priority |
| new org.mycore.datamodel.ifs2.MCRFileStore() may expose internal representation by storing an externally mutable object into MCRFileStore.thisInstance |
MALICIOUS_CODE |
EI_EXPOSE_REP2 |
58 |
Medium |
org.mycore.datamodel.ifs2.MCRMetadataStore
| Bug |
Category |
Details |
Line |
Priority |
| Possible null pointer dereference in org.mycore.datamodel.ifs2.MCRMetadataStore.create(MCRContent, int) due to return value of called method |
STYLE |
NP_NULL_ON_SOME_PATH_FROM_RETURN_VALUE |
131 |
Medium |
| Possible null pointer dereference in org.mycore.datamodel.ifs2.MCRMetadataStore.create(MCRContent, int) due to return value of called method |
STYLE |
NP_NULL_ON_SOME_PATH_FROM_RETURN_VALUE |
132 |
Medium |
org.mycore.datamodel.ifs2.MCRNode
| Bug |
Category |
Details |
Line |
Priority |
| Possible null pointer dereference in org.mycore.datamodel.ifs2.MCRNode.getName() due to return value of called method |
STYLE |
NP_NULL_ON_SOME_PATH_FROM_RETURN_VALUE |
72 |
Medium |
org.mycore.datamodel.ifs2.MCRObjectIDDateImpl
| Bug |
Category |
Details |
Line |
Priority |
| org.mycore.datamodel.ifs2.MCRObjectIDDateImpl.getLastModified() may expose internal representation by returning MCRObjectIDDateImpl.lastModified |
MALICIOUS_CODE |
EI_EXPOSE_REP |
42 |
Medium |
| new org.mycore.datamodel.ifs2.MCRObjectIDDateImpl(Date, String) may expose internal representation by storing an externally mutable object into MCRObjectIDDateImpl.lastModified |
MALICIOUS_CODE |
EI_EXPOSE_REP2 |
37 |
Medium |
org.mycore.datamodel.ifs2.MCRPathComparator
| Bug |
Category |
Details |
Line |
Priority |
| Possible null pointer dereference in org.mycore.datamodel.ifs2.MCRPathComparator.compare(Path, Path) due to return value of called method |
STYLE |
NP_NULL_ON_SOME_PATH_FROM_RETURN_VALUE |
29 |
Medium |
| Possible null pointer dereference in org.mycore.datamodel.ifs2.MCRPathComparator.compare(Path, Path) due to return value of called method |
STYLE |
NP_NULL_ON_SOME_PATH_FROM_RETURN_VALUE |
30 |
Medium |
org.mycore.datamodel.ifs2.MCRStore
org.mycore.datamodel.ifs2.MCRStore$1
| Bug |
Category |
Details |
Line |
Priority |
| Possible null pointer dereference in org.mycore.datamodel.ifs2.MCRStore$1.findNextID() due to return value of called method |
STYLE |
NP_NULL_ON_SOME_PATH_FROM_RETURN_VALUE |
330 |
Medium |
org.mycore.datamodel.ifs2.MCRStoreCenter
| Bug |
Category |
Details |
Line |
Priority |
| Public static org.mycore.datamodel.ifs2.MCRStoreCenter.instance() may expose internal representation by returning MCRStoreCenter.instance |
MALICIOUS_CODE |
MS_EXPOSE_REP |
36 |
Medium |
org.mycore.datamodel.ifs2.MCRStoredMetadata
| Bug |
Category |
Details |
Line |
Priority |
| org.mycore.datamodel.ifs2.MCRStoredMetadata.getStore() may expose internal representation by returning MCRStoredMetadata.store |
MALICIOUS_CODE |
EI_EXPOSE_REP |
145 |
Medium |
| Possible null pointer dereference in org.mycore.datamodel.ifs2.MCRStoredMetadata.create(MCRContent) due to return value of called method |
STYLE |
NP_NULL_ON_SOME_PATH_FROM_RETURN_VALUE |
90 |
Medium |
| Possible null pointer dereference in org.mycore.datamodel.ifs2.MCRStoredMetadata.create(MCRContent) due to return value of called method |
STYLE |
NP_NULL_ON_SOME_PATH_FROM_RETURN_VALUE |
91 |
Medium |
org.mycore.datamodel.ifs2.MCRVersionedMetadata
| Bug |
Category |
Details |
Line |
Priority |
| org.mycore.datamodel.ifs2.MCRVersionedMetadata.getStore() may expose internal representation by returning MCRStoredMetadata.store |
MALICIOUS_CODE |
EI_EXPOSE_REP |
99 |
Medium |
org.mycore.datamodel.ifs2.MCRVersioningMetadataStore
| Bug |
Category |
Details |
Line |
Priority |
| Possible null pointer dereference in org.mycore.datamodel.ifs2.MCRVersioningMetadataStore.setupSVN(String) due to return value of called method |
STYLE |
NP_NULL_ON_SOME_PATH_FROM_RETURN_VALUE |
103 |
Medium |
org.mycore.datamodel.language.MCRLanguage
| Bug |
Category |
Details |
Line |
Priority |
| org.mycore.datamodel.language.MCRLanguage.getCodes() may expose internal representation by returning MCRLanguage.codesByType |
MALICIOUS_CODE |
EI_EXPOSE_REP |
70 |
Medium |
| org.mycore.datamodel.language.MCRLanguage.getLabels() may expose internal representation by returning MCRLanguage.labelsByLanguage |
MALICIOUS_CODE |
EI_EXPOSE_REP |
99 |
Medium |
org.mycore.datamodel.language.MCRLanguageFactory
| Bug |
Category |
Details |
Line |
Priority |
| Dead store to session in org.mycore.datamodel.language.MCRLanguageFactory.readLanguageClassification() |
STYLE |
DLS_DEAD_LOCAL_STORE |
232 |
Medium |
| Public static org.mycore.datamodel.language.MCRLanguageFactory.instance() may expose internal representation by returning MCRLanguageFactory.SINGLETON |
MALICIOUS_CODE |
MS_EXPOSE_REP |
94 |
Medium |
org.mycore.datamodel.metadata.MCRBase
| Bug |
Category |
Details |
Line |
Priority |
| org.mycore.datamodel.metadata.MCRBase.getId() may expose internal representation by returning MCRBase.mcrId |
MALICIOUS_CODE |
EI_EXPOSE_REP |
128 |
Medium |
| org.mycore.datamodel.metadata.MCRBase.getService() may expose internal representation by returning MCRBase.mcrService |
MALICIOUS_CODE |
EI_EXPOSE_REP |
156 |
Medium |
| org.mycore.datamodel.metadata.MCRBase.setId(MCRObjectID) may expose internal representation by storing an externally mutable object into MCRBase.mcrId |
MALICIOUS_CODE |
EI_EXPOSE_REP2 |
194 |
Medium |
org.mycore.datamodel.metadata.MCRDerivate
| Bug |
Category |
Details |
Line |
Priority |
| org.mycore.datamodel.metadata.MCRDerivate.getDerivate() may expose internal representation by returning MCRDerivate.mcrDerivate |
MALICIOUS_CODE |
EI_EXPOSE_REP |
99 |
Medium |
| Load of known null value in org.mycore.datamodel.metadata.MCRDerivate.setLabel(String) |
STYLE |
NP_LOAD_OF_KNOWN_NULL_VALUE |
243 |
Medium |
org.mycore.datamodel.metadata.MCRFileMetadata
| Bug |
Category |
Details |
Line |
Priority |
| org.mycore.datamodel.metadata.MCRFileMetadata defines compareTo(MCRFileMetadata) and uses Object.equals() |
BAD_PRACTICE |
EQ_COMPARETO_USE_OBJECT_EQUALS |
142 |
Medium |
org.mycore.datamodel.metadata.MCRMetaAccessRule
| Bug |
Category |
Details |
Line |
Priority |
| org.mycore.datamodel.metadata.MCRMetaAccessRule.getCondition() may expose internal representation by returning MCRMetaAccessRule.condition |
MALICIOUS_CODE |
EI_EXPOSE_REP |
124 |
Medium |
org.mycore.datamodel.metadata.MCRMetaAddress
| Bug |
Category |
Details |
Line |
Priority |
| org.mycore.datamodel.metadata.MCRMetaAddress defines equals but not hashCode |
BAD_PRACTICE |
HE_EQUALS_NO_HASHCODE |
217-221 |
Medium |
org.mycore.datamodel.metadata.MCRMetaBoolean
| Bug |
Category |
Details |
Line |
Priority |
| org.mycore.datamodel.metadata.MCRMetaBoolean defines equals but not hashCode |
BAD_PRACTICE |
HE_EQUALS_NO_HASHCODE |
234-238 |
Medium |
org.mycore.datamodel.metadata.MCRMetaClassification
| Bug |
Category |
Details |
Line |
Priority |
| new org.mycore.datamodel.metadata.MCRMetaClassification(String, int, String, MCRCategoryID) may expose internal representation by storing an externally mutable object into MCRMetaClassification.category |
MALICIOUS_CODE |
EI_EXPOSE_REP2 |
103 |
Medium |
| org.mycore.datamodel.metadata.MCRMetaClassification defines equals but not hashCode |
BAD_PRACTICE |
HE_EQUALS_NO_HASHCODE |
243-247 |
Medium |
org.mycore.datamodel.metadata.MCRMetaDateLangText
| Bug |
Category |
Details |
Line |
Priority |
| org.mycore.datamodel.metadata.MCRMetaDateLangText.getDate() may expose internal representation by returning MCRMetaDateLangText.isoDate |
MALICIOUS_CODE |
EI_EXPOSE_REP |
89 |
Medium |
| org.mycore.datamodel.metadata.MCRMetaDateLangText.setDate(MCRISO8601Date) may expose internal representation by storing an externally mutable object into MCRMetaDateLangText.isoDate |
MALICIOUS_CODE |
EI_EXPOSE_REP2 |
80 |
Medium |
| org.mycore.datamodel.metadata.MCRMetaDateLangText defines equals but not hashCode |
BAD_PRACTICE |
HE_EQUALS_NO_HASHCODE |
196-200 |
Medium |
org.mycore.datamodel.metadata.MCRMetaDerivateLink
| Bug |
Category |
Details |
Line |
Priority |
| org.mycore.datamodel.metadata.MCRMetaDerivateLink doesn't override MCRMetaLink.equals(Object) |
STYLE |
EQ_DOESNT_OVERRIDE_EQUALS |
1 |
Medium |
| org.mycore.datamodel.metadata.MCRMetaDerivateLink.createXML() makes inefficient use of keySet iterator instead of entrySet iterator |
PERFORMANCE |
WMI_WRONG_MAP_ITERATOR |
91 |
Medium |
org.mycore.datamodel.metadata.MCRMetaElement
| Bug |
Category |
Details |
Line |
Priority |
| org.mycore.datamodel.metadata.MCRMetaElement.clone() does not call super.clone() |
BAD_PRACTICE |
CN_IDIOM_NO_SUPER_CALL |
449-460 |
Medium |
org.mycore.datamodel.metadata.MCRMetaEnrichedLinkID
| Bug |
Category |
Details |
Line |
Priority |
| org.mycore.datamodel.metadata.MCRMetaEnrichedLinkID.getContentList() may expose internal representation by returning MCRMetaEnrichedLinkID.contentList |
MALICIOUS_CODE |
EI_EXPOSE_REP |
103 |
Medium |
| org.mycore.datamodel.metadata.MCRMetaEnrichedLinkID.setContentList(List) may expose internal representation by storing an externally mutable object into MCRMetaEnrichedLinkID.contentList |
MALICIOUS_CODE |
EI_EXPOSE_REP2 |
107 |
Medium |
org.mycore.datamodel.metadata.MCRMetaHistoryDate
| Bug |
Category |
Details |
Line |
Priority |
| org.mycore.datamodel.metadata.MCRMetaHistoryDate.getBis() may expose internal representation by returning MCRMetaHistoryDate.bis |
MALICIOUS_CODE |
EI_EXPOSE_REP |
378 |
Medium |
| org.mycore.datamodel.metadata.MCRMetaHistoryDate.getTexts() may expose internal representation by returning MCRMetaHistoryDate.texts |
MALICIOUS_CODE |
EI_EXPOSE_REP |
210 |
Medium |
| org.mycore.datamodel.metadata.MCRMetaHistoryDate.getVon() may expose internal representation by returning MCRMetaHistoryDate.von |
MALICIOUS_CODE |
EI_EXPOSE_REP |
351 |
Medium |
| org.mycore.datamodel.metadata.MCRMetaHistoryDate.setBisDate(Calendar) may expose internal representation by storing an externally mutable object into MCRMetaHistoryDate.bis |
MALICIOUS_CODE |
EI_EXPOSE_REP2 |
312 |
Medium |
| org.mycore.datamodel.metadata.MCRMetaHistoryDate.setVonDate(Calendar) may expose internal representation by storing an externally mutable object into MCRMetaHistoryDate.von |
MALICIOUS_CODE |
EI_EXPOSE_REP2 |
277 |
Medium |
| org.mycore.datamodel.metadata.MCRMetaHistoryDate defines equals but not hashCode |
BAD_PRACTICE |
HE_EQUALS_NO_HASHCODE |
535-541 |
Medium |
org.mycore.datamodel.metadata.MCRMetaHistoryDate$MCRMetaHistoryDateText
| Bug |
Category |
Details |
Line |
Priority |
| org.mycore.datamodel.metadata.MCRMetaHistoryDate$MCRMetaHistoryDateText defines equals(MCRMetaHistoryDate$MCRMetaHistoryDateText) method and uses Object.equals(Object) |
CORRECTNESS |
EQ_SELF_USE_OBJECT |
659 |
Medium |
| org.mycore.datamodel.metadata.MCRMetaHistoryDate$MCRMetaHistoryDateText defines equals and uses Object.hashCode() |
BAD_PRACTICE |
HE_EQUALS_USE_HASHCODE |
659 |
Medium |
| Possible null pointer dereference of clone in org.mycore.datamodel.metadata.MCRMetaHistoryDate$MCRMetaHistoryDateText.clone() on exception path |
CORRECTNESS |
NP_NULL_ON_SOME_PATH_EXCEPTION |
671 |
Medium |
org.mycore.datamodel.metadata.MCRMetaIFS
| Bug |
Category |
Details |
Line |
Priority |
| org.mycore.datamodel.metadata.MCRMetaIFS defines equals but not hashCode |
BAD_PRACTICE |
HE_EQUALS_NO_HASHCODE |
231-235 |
Medium |
org.mycore.datamodel.metadata.MCRMetaISO8601Date
| Bug |
Category |
Details |
Line |
Priority |
| org.mycore.datamodel.metadata.MCRMetaISO8601Date.getMCRISO8601Date() may expose internal representation by returning MCRMetaISO8601Date.isoDate |
MALICIOUS_CODE |
EI_EXPOSE_REP |
201 |
Medium |
| org.mycore.datamodel.metadata.MCRMetaISO8601Date defines equals but not hashCode |
BAD_PRACTICE |
HE_EQUALS_NO_HASHCODE |
257-261 |
Medium |
org.mycore.datamodel.metadata.MCRMetaInstitutionName
| Bug |
Category |
Details |
Line |
Priority |
| org.mycore.datamodel.metadata.MCRMetaInstitutionName defines equals but not hashCode |
BAD_PRACTICE |
HE_EQUALS_NO_HASHCODE |
250-254 |
Medium |
org.mycore.datamodel.metadata.MCRMetaLangText
| Bug |
Category |
Details |
Line |
Priority |
| org.mycore.datamodel.metadata.MCRMetaLangText defines equals but not hashCode |
BAD_PRACTICE |
HE_EQUALS_NO_HASHCODE |
286-290 |
Medium |
org.mycore.datamodel.metadata.MCRMetaNumber
| Bug |
Category |
Details |
Line |
Priority |
| org.mycore.datamodel.metadata.MCRMetaNumber defines equals but not hashCode |
BAD_PRACTICE |
HE_EQUALS_NO_HASHCODE |
352-356 |
Medium |
org.mycore.datamodel.metadata.MCRMetaPersonName
| Bug |
Category |
Details |
Line |
Priority |
| org.mycore.datamodel.metadata.MCRMetaPersonName defines equals but not hashCode |
BAD_PRACTICE |
HE_EQUALS_NO_HASHCODE |
445-449 |
Medium |
org.mycore.datamodel.metadata.MCRMetaSpatial
| Bug |
Category |
Details |
Line |
Priority |
| org.mycore.datamodel.metadata.MCRMetaSpatial.getData() may expose internal representation by returning MCRMetaSpatial.data |
MALICIOUS_CODE |
EI_EXPOSE_REP |
79 |
Medium |
| org.mycore.datamodel.metadata.MCRMetaSpatial.setData(List) may expose internal representation by storing an externally mutable object into MCRMetaSpatial.data |
MALICIOUS_CODE |
EI_EXPOSE_REP2 |
83 |
Medium |
org.mycore.datamodel.metadata.MCRMetaXML
| Bug |
Category |
Details |
Line |
Priority |
| org.mycore.datamodel.metadata.MCRMetaXML.getContent() may expose internal representation by returning MCRMetaXML.content |
MALICIOUS_CODE |
EI_EXPOSE_REP |
85 |
Medium |
| org.mycore.datamodel.metadata.MCRMetaXML defines equals but not hashCode |
BAD_PRACTICE |
HE_EQUALS_NO_HASHCODE |
186-190 |
Medium |
org.mycore.datamodel.metadata.MCRObject
| Bug |
Category |
Details |
Line |
Priority |
| org.mycore.datamodel.metadata.MCRObject.getMetadata() may expose internal representation by returning MCRObject.metadata |
MALICIOUS_CODE |
EI_EXPOSE_REP |
105 |
Medium |
| org.mycore.datamodel.metadata.MCRObject.getStructure() may expose internal representation by returning MCRObject.structure |
MALICIOUS_CODE |
EI_EXPOSE_REP |
115 |
Medium |
| Load of known null value in org.mycore.datamodel.metadata.MCRObject.setLabel(String) |
STYLE |
NP_LOAD_OF_KNOWN_NULL_VALUE |
136 |
Medium |
org.mycore.datamodel.metadata.MCRObjectDerivate
| Bug |
Category |
Details |
Line |
Priority |
| org.mycore.datamodel.metadata.MCRObjectDerivate.getClassifications() may expose internal representation by returning MCRObjectDerivate.classifications |
MALICIOUS_CODE |
EI_EXPOSE_REP |
477 |
Medium |
| org.mycore.datamodel.metadata.MCRObjectDerivate.getInternals() may expose internal representation by returning MCRObjectDerivate.internals |
MALICIOUS_CODE |
EI_EXPOSE_REP |
230 |
Medium |
| org.mycore.datamodel.metadata.MCRObjectDerivate.getMetaLink() may expose internal representation by returning MCRObjectDerivate.linkmeta |
MALICIOUS_CODE |
EI_EXPOSE_REP |
167 |
Medium |
| org.mycore.datamodel.metadata.MCRObjectDerivate.getTitles() may expose internal representation by returning MCRObjectDerivate.titles |
MALICIOUS_CODE |
EI_EXPOSE_REP |
481 |
Medium |
| new org.mycore.datamodel.metadata.MCRObjectDerivate(MCRObjectID) may expose internal representation by storing an externally mutable object into MCRObjectDerivate.derivateID |
MALICIOUS_CODE |
EI_EXPOSE_REP2 |
74 |
Medium |
| org.mycore.datamodel.metadata.MCRObjectDerivate.setInternals(MCRMetaIFS) may expose internal representation by storing an externally mutable object into MCRObjectDerivate.internals |
MALICIOUS_CODE |
EI_EXPOSE_REP2 |
343 |
Medium |
| org.mycore.datamodel.metadata.MCRObjectDerivate.setLinkMeta(MCRMetaLinkID) may expose internal representation by storing an externally mutable object into MCRObjectDerivate.linkmeta |
MALICIOUS_CODE |
EI_EXPOSE_REP2 |
177 |
Medium |
org.mycore.datamodel.metadata.MCRObjectService
| Bug |
Category |
Details |
Line |
Priority |
| org.mycore.datamodel.metadata.MCRObjectService.getState() may expose internal representation by returning MCRObjectService.state |
MALICIOUS_CODE |
EI_EXPOSE_REP |
253 |
Medium |
| org.mycore.datamodel.metadata.MCRObjectService.setState(MCRCategoryID) may expose internal representation by storing an externally mutable object into MCRObjectService.state |
MALICIOUS_CODE |
EI_EXPOSE_REP2 |
359 |
Medium |
| Load of known null value in org.mycore.datamodel.metadata.MCRObjectService.setState(MCRCategoryID) |
STYLE |
NP_LOAD_OF_KNOWN_NULL_VALUE |
359 |
Medium |
org.mycore.datamodel.metadata.MCRObjectStructure
| Bug |
Category |
Details |
Line |
Priority |
| org.mycore.datamodel.metadata.MCRObjectStructure.getChildren() may expose internal representation by returning MCRObjectStructure.children |
MALICIOUS_CODE |
EI_EXPOSE_REP |
232 |
Medium |
| org.mycore.datamodel.metadata.MCRObjectStructure.getDerivates() may expose internal representation by returning MCRObjectStructure.derivates |
MALICIOUS_CODE |
EI_EXPOSE_REP |
301 |
Medium |
| org.mycore.datamodel.metadata.MCRObjectStructure.getParent() may expose internal representation by returning MCRObjectStructure.parent |
MALICIOUS_CODE |
EI_EXPOSE_REP |
111 |
Medium |
| org.mycore.datamodel.metadata.MCRObjectStructure.setParent(MCRMetaLinkID) may expose internal representation by storing an externally mutable object into MCRObjectStructure.parent |
MALICIOUS_CODE |
EI_EXPOSE_REP2 |
134 |
Medium |
org.mycore.datamodel.metadata.history.MCRMetaHistoryItem
| Bug |
Category |
Details |
Line |
Priority |
| org.mycore.datamodel.metadata.history.MCRMetaHistoryItem.getId() may expose internal representation by returning MCRMetaHistoryItem.id |
MALICIOUS_CODE |
EI_EXPOSE_REP |
134 |
Medium |
| org.mycore.datamodel.metadata.history.MCRMetaHistoryItem.setId(MCRObjectID) may expose internal representation by storing an externally mutable object into MCRMetaHistoryItem.id |
MALICIOUS_CODE |
EI_EXPOSE_REP2 |
138 |
Medium |
| Class org.mycore.datamodel.metadata.history.MCRMetaHistoryItem defines non-transient non-serializable instance field id |
BAD_PRACTICE |
SE_BAD_FIELD |
Not available |
High |
org.mycore.datamodel.metadata.history.MCRMetaHistoryItem_
org.mycore.datamodel.metadata.history.MCRMetadataHistoryCommands
| Bug |
Category |
Details |
Line |
Priority |
org.mycore.datamodel.metadata.validator.MCREditorOutValidator
| Bug |
Category |
Details |
Line |
Priority |
| org.mycore.datamodel.metadata.validator.MCREditorOutValidator.generateValidMyCoReObject() may expose internal representation by returning MCREditorOutValidator.input |
MALICIOUS_CODE |
EI_EXPOSE_REP |
297 |
Medium |
| org.mycore.datamodel.metadata.validator.MCREditorOutValidator.getErrorLog() may expose internal representation by returning MCREditorOutValidator.errorlog |
MALICIOUS_CODE |
EI_EXPOSE_REP |
306 |
Medium |
| new org.mycore.datamodel.metadata.validator.MCREditorOutValidator(Document, MCRObjectID) may expose internal representation by storing an externally mutable object into MCREditorOutValidator.id |
MALICIOUS_CODE |
EI_EXPOSE_REP2 |
108 |
Medium |
| new org.mycore.datamodel.metadata.validator.MCREditorOutValidator(Document, MCRObjectID) may expose internal representation by storing an externally mutable object into MCREditorOutValidator.input |
MALICIOUS_CODE |
EI_EXPOSE_REP2 |
107 |
Medium |
| org.mycore.datamodel.metadata.validator.MCREditorOutValidator.setDefaultDerivateACLs(Element) may fail to clean up java.io.InputStream |
EXPERIMENTAL |
OBL_UNSATISFIED_OBLIGATION |
255 |
Medium |
| org.mycore.datamodel.metadata.validator.MCREditorOutValidator.setDefaultObjectACLs(Element) may fail to clean up java.io.InputStream |
EXPERIMENTAL |
OBL_UNSATISFIED_OBLIGATION |
419 |
Medium |
| Exception is caught when Exception is not thrown in org.mycore.datamodel.metadata.validator.MCREditorOutValidator.setDefaultDerivateACLs(Element) |
STYLE |
REC_CATCH_EXCEPTION |
266 |
Medium |
org.mycore.datamodel.niofs.MCRFileAttributes
| Bug |
Category |
Details |
Line |
Priority |
| org.mycore.datamodel.niofs.MCRFileAttributes.creationTime() may expose internal representation by returning MCRFileAttributes.creationTime |
MALICIOUS_CODE |
EI_EXPOSE_REP |
105 |
Medium |
| org.mycore.datamodel.niofs.MCRFileAttributes.lastAccessTime() may expose internal representation by returning MCRFileAttributes.lastAccessTime |
MALICIOUS_CODE |
EI_EXPOSE_REP |
153 |
Medium |
| org.mycore.datamodel.niofs.MCRFileAttributes.lastModifiedTime() may expose internal representation by returning MCRFileAttributes.lastModified |
MALICIOUS_CODE |
EI_EXPOSE_REP |
161 |
Medium |
org.mycore.datamodel.niofs.MCRPathXML
| Bug |
Category |
Details |
Line |
Priority |
| Possible null pointer dereference in org.mycore.datamodel.niofs.MCRPathXML.getDirectoryXML(MCRPath, BasicFileAttributes) due to return value of called method |
STYLE |
NP_NULL_ON_SOME_PATH_FROM_RETURN_VALUE |
77 |
Medium |
| Possible null pointer dereference in org.mycore.datamodel.niofs.MCRPathXML.getDirectoryXML(MCRPath, BasicFileAttributes) due to return value of called method |
STYLE |
NP_NULL_ON_SOME_PATH_FROM_RETURN_VALUE |
79 |
Medium |
| Possible null pointer dereference in org.mycore.datamodel.niofs.MCRPathXML.getDirectoryXML(MCRPath, BasicFileAttributes) due to return value of called method |
STYLE |
NP_NULL_ON_SOME_PATH_FROM_RETURN_VALUE |
137 |
Medium |
| Possible null pointer dereference in org.mycore.datamodel.niofs.MCRPathXML.getDirectoryXML(MCRPath, BasicFileAttributes) due to return value of called method |
STYLE |
NP_NULL_ON_SOME_PATH_FROM_RETURN_VALUE |
145 |
Medium |
| Possible null pointer dereference in org.mycore.datamodel.niofs.MCRPathXML.getFileXML(MCRPath, BasicFileAttributes) due to return value of called method |
STYLE |
NP_NULL_ON_SOME_PATH_FROM_RETURN_VALUE |
178 |
Medium |
org.mycore.datamodel.niofs.MCRUnsupportedContentTypeException
| Bug |
Category |
Details |
Line |
Priority |
| Class org.mycore.datamodel.niofs.MCRUnsupportedContentTypeException is not derived from an Exception, even though it is named as such |
BAD_PRACTICE |
NM_CLASS_NOT_EXCEPTION |
25 |
Medium |
org.mycore.datamodel.niofs.utils.MCRDerivateUtil$1
| Bug |
Category |
Details |
Line |
Priority |
| Possible null pointer dereference in org.mycore.datamodel.niofs.utils.MCRDerivateUtil$1.visitFile(Path, BasicFileAttributes) due to return value of called method |
STYLE |
NP_NULL_ON_SOME_PATH_FROM_RETURN_VALUE |
60 |
Medium |
| Possible null pointer dereference in org.mycore.datamodel.niofs.utils.MCRDerivateUtil$1.visitFile(Path, BasicFileAttributes) due to return value of called method |
STYLE |
NP_NULL_ON_SOME_PATH_FROM_RETURN_VALUE |
75 |
Medium |
org.mycore.datamodel.niofs.utils.MCRFileCollectingFileVisitor
| Bug |
Category |
Details |
Line |
Priority |
| org.mycore.datamodel.niofs.utils.MCRFileCollectingFileVisitor.getPaths() may expose internal representation by returning MCRFileCollectingFileVisitor.paths |
MALICIOUS_CODE |
EI_EXPOSE_REP |
36 |
Medium |
org.mycore.datamodel.niofs.utils.MCRRecursiveDeleter
| Bug |
Category |
Details |
Line |
Priority |
| Load of known null value in org.mycore.datamodel.niofs.utils.MCRRecursiveDeleter.postVisitDirectory(Path, IOException) |
STYLE |
NP_LOAD_OF_KNOWN_NULL_VALUE |
62 |
Medium |
org.mycore.datamodel.niofs.utils.MCRTreeCopier
| Bug |
Category |
Details |
Line |
Priority |
| Possible null pointer dereference in org.mycore.datamodel.niofs.utils.MCRTreeCopier.copyFile(Path, Path) due to return value of called method |
STYLE |
NP_NULL_ON_SOME_PATH_FROM_RETURN_VALUE |
92 |
Medium |
| Possible null pointer dereference in org.mycore.datamodel.niofs.utils.MCRTreeCopier.copyFile(Path, Path) due to return value of called method |
STYLE |
NP_NULL_ON_SOME_PATH_FROM_RETURN_VALUE |
100 |
Medium |
org.mycore.datamodel.objectinfo.MCRObjectQuery
| Bug |
Category |
Details |
Line |
Priority |
| org.mycore.datamodel.objectinfo.MCRObjectQuery.afterId() may expose internal representation by returning MCRObjectQuery.afterId |
MALICIOUS_CODE |
EI_EXPOSE_REP |
76 |
Medium |
| org.mycore.datamodel.objectinfo.MCRObjectQuery.getIncludeCategories() may expose internal representation by returning MCRObjectQuery.includeCategories |
MALICIOUS_CODE |
EI_EXPOSE_REP |
393 |
Medium |
| org.mycore.datamodel.objectinfo.MCRObjectQuery.afterId(MCRObjectID) may expose internal representation by storing an externally mutable object into MCRObjectQuery.afterId |
MALICIOUS_CODE |
EI_EXPOSE_REP2 |
86 |
Medium |
org.mycore.frontend.MCRFrontendUtil
| Bug |
Category |
Details |
Line |
Priority |
| org.mycore.frontend.MCRFrontendUtil.SESSION_NETMASK_IPV4 should be both final and package protected |
MALICIOUS_CODE |
MS_FINAL_PKGPROTECT |
91 |
Medium |
| org.mycore.frontend.MCRFrontendUtil.SESSION_NETMASK_IPV6 should be both final and package protected |
MALICIOUS_CODE |
MS_FINAL_PKGPROTECT |
97 |
Medium |
org.mycore.frontend.MCRLayoutUtilities$DocumentHolder
| Bug |
Category |
Details |
Line |
Priority |
| Invocation of java.net.URL.equals(Object), which blocks to do domain name resolution, in org.mycore.frontend.MCRLayoutUtilities$DocumentHolder.isValid(URL) |
PERFORMANCE |
DMI_BLOCKING_METHODS_ON_URL |
491 |
High |
org.mycore.frontend.MCRURL
| Bug |
Category |
Details |
Line |
Priority |
| org.mycore.frontend.MCRURL.getParameterMap() may expose internal representation by returning MCRURL.parameterMap |
MALICIOUS_CODE |
EI_EXPOSE_REP |
53 |
Medium |
| Exception is caught when Exception is not thrown in org.mycore.frontend.MCRURL.rebuild() |
STYLE |
REC_CATCH_EXCEPTION |
107 |
Medium |
org.mycore.frontend.MCRWebsiteWriteProtection
| Bug |
Category |
Details |
Line |
Priority |
| org.mycore.frontend.MCRWebsiteWriteProtection.setConfiguration(Element) may fail to clean up java.io.OutputStream on checked exception |
EXPERIMENTAL |
OBL_UNSATISFIED_OBLIGATION_EXCEPTION_EDGE |
125 |
Medium |
| Exceptional return value of java.io.File.mkdirs() ignored in org.mycore.frontend.MCRWebsiteWriteProtection.getConfiguration() |
BAD_PRACTICE |
RV_RETURN_VALUE_IGNORED_BAD_PRACTICE |
93 |
Medium |
org.mycore.frontend.basket.MCRBasketEntry
| Bug |
Category |
Details |
Line |
Priority |
| org.mycore.frontend.basket.MCRBasketEntry.getContent() may expose internal representation by returning MCRBasketEntry.content |
MALICIOUS_CODE |
EI_EXPOSE_REP |
88 |
Medium |
org.mycore.frontend.cli.MCRAbstractCommands
| Bug |
Category |
Details |
Line |
Priority |
| org.mycore.frontend.cli.MCRAbstractCommands.getPossibleCommands() may expose internal representation by returning MCRAbstractCommands.command |
MALICIOUS_CODE |
EI_EXPOSE_REP |
65 |
Medium |
org.mycore.frontend.cli.MCRAccessCommands
| Bug |
Category |
Details |
Line |
Priority |
| org.mycore.frontend.cli.MCRAccessCommands.exportAllPermissionsToFile(String) may fail to clean up java.io.OutputStream |
EXPERIMENTAL |
OBL_UNSATISFIED_OBLIGATION |
223 |
Medium |
org.mycore.frontend.cli.MCRCLIExceptionHandler
| Bug |
Category |
Details |
Line |
Priority |
| org.mycore.frontend.cli.MCRCLIExceptionHandler.showActiveLinks(MCRActiveLinkException) makes inefficient use of keySet iterator instead of entrySet iterator |
PERFORMANCE |
WMI_WRONG_MAP_ITERATOR |
61 |
Medium |
org.mycore.frontend.cli.MCRClassification2Commands
| Bug |
Category |
Details |
Line |
Priority |
| Possible null pointer dereference in org.mycore.frontend.cli.MCRClassification2Commands.processFromDirectory(String, boolean) due to return value of called method |
STYLE |
NP_NULL_ON_SOME_PATH_FROM_RETURN_VALUE |
242 |
Medium |
| org.mycore.frontend.cli.MCRClassification2Commands.export(String, String, String) may fail to clean up java.io.OutputStream |
EXPERIMENTAL |
OBL_UNSATISFIED_OBLIGATION |
294 |
Medium |
| Exceptional return value of java.io.File.mkdir() ignored in org.mycore.frontend.cli.MCRClassification2Commands.export(String, String, String) |
BAD_PRACTICE |
RV_RETURN_VALUE_IGNORED_BAD_PRACTICE |
276 |
Medium |
org.mycore.frontend.cli.MCRCommand
| Bug |
Category |
Details |
Line |
Priority |
| org.mycore.frontend.cli.MCRCommand.setMethod(Method) may expose internal representation by storing an externally mutable object into MCRCommand.method |
MALICIOUS_CODE |
EI_EXPOSE_REP2 |
280 |
Medium |
org.mycore.frontend.cli.MCRCommandLineInterface
| Bug |
Category |
Details |
Line |
Priority |
| org.mycore.frontend.cli.MCRCommandLineInterface.commandQueue isn't final but should be |
MALICIOUS_CODE |
MS_SHOULD_BE_FINAL |
79 |
High |
| org.mycore.frontend.cli.MCRCommandLineInterface.failedCommands isn't final but should be |
MALICIOUS_CODE |
MS_SHOULD_BE_FINAL |
81 |
High |
org.mycore.frontend.cli.MCRCommandManager
| Bug |
Category |
Details |
Line |
Priority |
| Public static org.mycore.frontend.cli.MCRCommandManager.getKnownCommands() may expose internal representation by returning MCRCommandManager.knownCommands |
MALICIOUS_CODE |
MS_EXPOSE_REP |
67 |
Medium |
| org.mycore.frontend.cli.MCRCommandManager.knownCommands isn't final but should be |
MALICIOUS_CODE |
MS_SHOULD_BE_FINAL |
49 |
High |
org.mycore.frontend.cli.MCRDerivateCommands
| Bug |
Category |
Details |
Line |
Priority |
| Dead store to oldObjectToDerivateLink in org.mycore.frontend.cli.MCRDerivateCommands.linkDerivateToObject(String, String) |
STYLE |
DLS_DEAD_LOCAL_STORE |
704 |
High |
| Possible null pointer dereference in org.mycore.frontend.cli.MCRDerivateCommands.processFromDirectory(String, boolean) due to return value of called method |
STYLE |
NP_NULL_ON_SOME_PATH_FROM_RETURN_VALUE |
201 |
Medium |
| org.mycore.frontend.cli.MCRDerivateCommands.exportDerivate(File, Transformer, String) may fail to clean up java.io.OutputStream on checked exception |
EXPERIMENTAL |
OBL_UNSATISFIED_OBLIGATION_EXCEPTION_EDGE |
545 |
Medium |
| Exceptional return value of java.io.File.mkdir() ignored in org.mycore.frontend.cli.MCRDerivateCommands.exportDerivate(File, Transformer, String) |
BAD_PRACTICE |
RV_RETURN_VALUE_IGNORED_BAD_PRACTICE |
562 |
Medium |
org.mycore.frontend.cli.MCRObjectCommands
| Bug |
Category |
Details |
Line |
Priority |
| Do not catch NullPointerException like in org.mycore.frontend.cli.MCRObjectCommands.doValidateObjectAgainstSchema(MCRObjectID, Transformer) |
STYLE |
DCN_NULLPOINTER_EXCEPTION |
1291 |
Medium |
| org.mycore.frontend.cli.MCRObjectCommands.exportMCRObject(File, FailableBiConsumer, String) may fail to clean up java.io.OutputStream |
EXPERIMENTAL |
OBL_UNSATISFIED_OBLIGATION |
800 |
Medium |
org.mycore.frontend.fileupload.MCRUploadHandlerIFS
| Bug |
Category |
Details |
Line |
Priority |
| Inconsistent synchronization of org.mycore.frontend.fileupload.MCRUploadHandlerIFS.filesUploaded; locked 85% of time |
MT_CORRECTNESS |
IS2_INCONSISTENT_SYNC |
109 |
Medium |
| Inconsistent synchronization of org.mycore.frontend.fileupload.MCRUploadHandlerIFS.rootDir; locked 70% of time |
MT_CORRECTNESS |
IS2_INCONSISTENT_SYNC |
198 |
Medium |
| Possible null pointer dereference in org.mycore.frontend.fileupload.MCRUploadHandlerIFS.getFile(String) due to return value of called method |
STYLE |
NP_NULL_ON_SOME_PATH_FROM_RETURN_VALUE |
277 |
Medium |
org.mycore.frontend.fileupload.MCRUploadHandlerIFS$MainFileFinder
| Bug |
Category |
Details |
Line |
Priority |
| Possible null pointer dereference in org.mycore.frontend.fileupload.MCRUploadHandlerIFS$MainFileFinder.visitFile(Path, BasicFileAttributes) due to return value of called method |
STYLE |
NP_NULL_ON_SOME_PATH_FROM_RETURN_VALUE |
334 |
Medium |
org.mycore.frontend.fileupload.MCRUploadHandlerManager
| Bug |
Category |
Details |
Line |
Priority |
| org.mycore.frontend.fileupload.MCRUploadHandlerManager.COLLECTION isn't final but should be |
MALICIOUS_CODE |
MS_SHOULD_BE_FINAL |
49 |
High |
| org.mycore.frontend.fileupload.MCRUploadHandlerManager.HANDLERS isn't final but should be |
MALICIOUS_CODE |
MS_SHOULD_BE_FINAL |
48 |
High |
org.mycore.frontend.fileupload.MCRUploadViaFormServlet
| Bug |
Category |
Details |
Line |
Priority |
| Dead store to session in org.mycore.frontend.fileupload.MCRUploadViaFormServlet.handleUploadedFiles(MCRUploadHandler, Collection) |
STYLE |
DLS_DEAD_LOCAL_STORE |
97 |
Medium |
org.mycore.frontend.filter.MCRUserAgentFilter
| Bug |
Category |
Details |
Line |
Priority |
| Write to static field org.mycore.frontend.filter.MCRUserAgentFilter.agentPattern from instance method org.mycore.frontend.filter.MCRUserAgentFilter.init(FilterConfig) |
STYLE |
ST_WRITE_TO_STATIC_FROM_INSTANCE_METHOD |
55 |
Medium |
org.mycore.frontend.jersey.MCRJWTUtil
| Bug |
Category |
Details |
Line |
Priority |
| Write to static field org.mycore.frontend.jersey.MCRJWTUtil.SHARED_SECRET from instance method org.mycore.frontend.jersey.MCRJWTUtil.startUp(ServletContext) |
STYLE |
ST_WRITE_TO_STATIC_FROM_INSTANCE_METHOD |
191 |
Medium |
org.mycore.frontend.jersey.access.MCRRequestScopeACLFilter
| Bug |
Category |
Details |
Line |
Priority |
| org.mycore.frontend.jersey.access.MCRRequestScopeACLFilter.ACL_INSTANT_KEY isn't final but should be |
MALICIOUS_CODE |
MS_SHOULD_BE_FINAL |
31 |
High |
org.mycore.frontend.jersey.filter.MCRDBTransactionFilter
| Bug |
Category |
Details |
Line |
Priority |
| Dead store to session in org.mycore.frontend.jersey.filter.MCRDBTransactionFilter.filter(ContainerRequestContext, ContainerResponseContext) |
STYLE |
DLS_DEAD_LOCAL_STORE |
34 |
Medium |
org.mycore.frontend.jersey.resources.MCRJerseyExceptionMapper$ExceptionTypeAdapter
| Bug |
Category |
Details |
Line |
Priority |
org.mycore.frontend.jersey.resources.MCRJerseyExceptionMapper$RException
| Bug |
Category |
Details |
Line |
Priority |
| Class org.mycore.frontend.jersey.resources.MCRJerseyExceptionMapper$RException is not derived from an Exception, even though it is named as such |
BAD_PRACTICE |
NM_CLASS_NOT_EXCEPTION |
174 |
Medium |
| Unread field: org.mycore.frontend.jersey.resources.MCRJerseyExceptionMapper$RException.cause |
PERFORMANCE |
URF_UNREAD_FIELD |
169 |
Medium |
| Unread field: org.mycore.frontend.jersey.resources.MCRJerseyExceptionMapper$RException.message |
PERFORMANCE |
URF_UNREAD_FIELD |
162 |
Medium |
| Unread field: org.mycore.frontend.jersey.resources.MCRJerseyExceptionMapper$RException.stackTrace |
PERFORMANCE |
URF_UNREAD_FIELD |
164 |
Medium |
org.mycore.frontend.jersey.resources.MCRJerseyExceptionMapper$RStackTraceElement
| Bug |
Category |
Details |
Line |
Priority |
| Unread field: org.mycore.frontend.jersey.resources.MCRJerseyExceptionMapper$RStackTraceElement.className |
PERFORMANCE |
URF_UNREAD_FIELD |
201 |
Medium |
| Unread field: org.mycore.frontend.jersey.resources.MCRJerseyExceptionMapper$RStackTraceElement.file |
PERFORMANCE |
URF_UNREAD_FIELD |
203 |
Medium |
| Unread field: org.mycore.frontend.jersey.resources.MCRJerseyExceptionMapper$RStackTraceElement.line |
PERFORMANCE |
URF_UNREAD_FIELD |
204 |
Medium |
| Unread field: org.mycore.frontend.jersey.resources.MCRJerseyExceptionMapper$RStackTraceElement.method |
PERFORMANCE |
URF_UNREAD_FIELD |
202 |
Medium |
org.mycore.frontend.servlets.MCRContainerLoginServlet$ContainerUserInformation
| Bug |
Category |
Details |
Line |
Priority |
| new org.mycore.frontend.servlets.MCRContainerLoginServlet$ContainerUserInformation(MCRSession) may expose internal representation by storing an externally mutable object into MCRContainerLoginServlet$ContainerUserInformation.session |
MALICIOUS_CODE |
EI_EXPOSE_REP2 |
74 |
Medium |
org.mycore.frontend.servlets.MCRDerivateLinkServlet
| Bug |
Category |
Details |
Line |
Priority |
| org.mycore.frontend.servlets.MCRDerivateLinkServlet.derivateLinkErrorPage isn't final but should be |
MALICIOUS_CODE |
MS_SHOULD_BE_FINAL |
43 |
High |
org.mycore.frontend.servlets.MCRDerivateServlet
| Bug |
Category |
Details |
Line |
Priority |
| Possible null pointer dereference in org.mycore.frontend.servlets.MCRDerivateServlet.moveFile(String, String, String, HttpServletResponse) due to return value of called method |
STYLE |
NP_NULL_ON_SOME_PATH_FROM_RETURN_VALUE |
173 |
Medium |
org.mycore.frontend.servlets.MCRObjectServlet
| Bug |
Category |
Details |
Line |
Priority |
| Class org.mycore.frontend.servlets.MCRObjectServlet defines non-transient non-serializable instance field metadataManager |
BAD_PRACTICE |
SE_BAD_FIELD |
Not available |
Medium |
org.mycore.frontend.servlets.MCRQRCodeServlet
| Bug |
Category |
Details |
Line |
Priority |
| Class org.mycore.frontend.servlets.MCRQRCodeServlet defines non-transient non-serializable instance field pngTools |
BAD_PRACTICE |
SE_BAD_FIELD |
Not available |
Medium |
org.mycore.frontend.servlets.MCRServlet
| Bug |
Category |
Details |
Line |
Priority |
| Dead store to session in org.mycore.frontend.servlets.MCRServlet.doGetPost(HttpServletRequest, HttpServletResponse) |
STYLE |
DLS_DEAD_LOCAL_STORE |
299 |
Medium |
| Dead store to session in org.mycore.frontend.servlets.MCRServlet.processRenderingPhase(MCRServletJob, Exception) |
STYLE |
DLS_DEAD_LOCAL_STORE |
449 |
Medium |
| Dead store to session in org.mycore.frontend.servlets.MCRServlet.processThinkPhase(MCRServletJob) |
STYLE |
DLS_DEAD_LOCAL_STORE |
410 |
Medium |
| Incorrect lazy initialization of static field org.mycore.frontend.servlets.MCRServlet.LAYOUT_SERVICE in org.mycore.frontend.servlets.MCRServlet.init() |
MT_CORRECTNESS |
LI_LAZY_INIT_STATIC |
101-102 |
Medium |
| Write to static field org.mycore.frontend.servlets.MCRServlet.LAYOUT_SERVICE from instance method org.mycore.frontend.servlets.MCRServlet.init() |
STYLE |
ST_WRITE_TO_STATIC_FROM_INSTANCE_METHOD |
102 |
Medium |
org.mycore.frontend.servlets.MCRServletJob
| Bug |
Category |
Details |
Line |
Priority |
| org.mycore.frontend.servlets.MCRServletJob.getResponse() may expose internal representation by returning MCRServletJob.theResponse |
MALICIOUS_CODE |
EI_EXPOSE_REP |
65 |
Medium |
| new org.mycore.frontend.servlets.MCRServletJob(HttpServletRequest, HttpServletResponse) may expose internal representation by storing an externally mutable object into MCRServletJob.theResponse |
MALICIOUS_CODE |
EI_EXPOSE_REP2 |
55 |
Medium |
org.mycore.frontend.support.MCRLogin
| Bug |
Category |
Details |
Line |
Priority |
| org.mycore.frontend.support.MCRLogin.getForm() may expose internal representation by returning MCRLogin.form |
MALICIOUS_CODE |
EI_EXPOSE_REP |
82 |
Medium |
| org.mycore.frontend.support.MCRLogin.setForm(MCRLogin$Form) may expose internal representation by storing an externally mutable object into MCRLogin.form |
MALICIOUS_CODE |
EI_EXPOSE_REP2 |
86 |
Medium |
org.mycore.frontend.support.MCRLogin$Form
| Bug |
Category |
Details |
Line |
Priority |
| org.mycore.frontend.support.MCRLogin$Form.getInput() may expose internal representation by returning MCRLogin$Form.input |
MALICIOUS_CODE |
EI_EXPOSE_REP |
116 |
Medium |
| org.mycore.frontend.support.MCRLogin$Form.setInput(List) may expose internal representation by storing an externally mutable object into MCRLogin$Form.input |
MALICIOUS_CODE |
EI_EXPOSE_REP2 |
120 |
Medium |
org.mycore.parsers.bool.MCRSetCondition
| Bug |
Category |
Details |
Line |
Priority |
| org.mycore.parsers.bool.MCRSetCondition.getChildren() may expose internal representation by returning MCRSetCondition.children |
MALICIOUS_CODE |
EI_EXPOSE_REP |
60 |
Medium |
org.mycore.services.fieldquery.MCRQuery
| Bug |
Category |
Details |
Line |
Priority |
| org.mycore.services.fieldquery.MCRQuery.buildXML() may expose internal representation by returning MCRQuery.doc |
MALICIOUS_CODE |
EI_EXPOSE_REP |
299 |
Medium |
| org.mycore.services.fieldquery.MCRQuery.getReturnFields() may expose internal representation by returning MCRQuery.returnFields |
MALICIOUS_CODE |
EI_EXPOSE_REP |
228 |
Medium |
| org.mycore.services.fieldquery.MCRQuery.getSortBy() may expose internal representation by returning MCRQuery.sortBy |
MALICIOUS_CODE |
EI_EXPOSE_REP |
190 |
Medium |
org.mycore.services.http.MCRIdleConnectionMonitorThread
| Bug |
Category |
Details |
Line |
Priority |
| Naked notify in org.mycore.services.http.MCRIdleConnectionMonitorThread.shutdown() |
MT_CORRECTNESS |
NN_NAKED_NOTIFY |
61 |
Medium |
org.mycore.services.i18n.MCRTranslation
| Bug |
Category |
Details |
Line |
Priority |
| Public static org.mycore.services.i18n.MCRTranslation.getAvailableLanguages() may expose internal representation by returning MCRTranslation.AVAILABLE_LANGUAGES |
MALICIOUS_CODE |
MS_EXPOSE_REP |
273 |
Medium |
| org.mycore.services.i18n.MCRTranslation.loadProperties() may fail to clean up java.io.InputStream |
EXPERIMENTAL |
OBL_UNSATISFIED_OBLIGATION |
355 |
Medium |
| org.mycore.services.i18n.MCRTranslation.loadProperties() may fail to close stream |
BAD_PRACTICE |
OS_OPEN_STREAM |
355 |
Medium |
org.mycore.services.mbeans.MCRJMXBridge
org.mycore.services.packaging.MCRPackerJobAction
| Bug |
Category |
Details |
Line |
Priority |
| org.mycore.services.packaging.MCRPackerJobAction.getPackerInstance() may expose internal representation by returning MCRPackerJobAction.packerInstance |
MALICIOUS_CODE |
EI_EXPOSE_REP |
64 |
Medium |
org.mycore.services.queuedjob.MCRDefaultJobStatusListener
| Bug |
Category |
Details |
Line |
Priority |
| org.mycore.services.queuedjob.MCRDefaultJobStatusListener.LOGGER isn't final but should be |
MALICIOUS_CODE |
MS_SHOULD_BE_FINAL |
31 |
High |
org.mycore.services.queuedjob.MCRJob
| Bug |
Category |
Details |
Line |
Priority |
| org.mycore.services.queuedjob.MCRJob.clone() does not call super.clone() |
BAD_PRACTICE |
CN_IDIOM_NO_SUPER_CALL |
249-260 |
Medium |
| org.mycore.services.queuedjob.MCRJob.getAdded() may expose internal representation by returning MCRJob.added |
MALICIOUS_CODE |
EI_EXPOSE_REP |
144 |
Medium |
| org.mycore.services.queuedjob.MCRJob.getFinished() may expose internal representation by returning MCRJob.finished |
MALICIOUS_CODE |
EI_EXPOSE_REP |
181 |
Medium |
| org.mycore.services.queuedjob.MCRJob.getParameters() may expose internal representation by returning MCRJob.parameters |
MALICIOUS_CODE |
EI_EXPOSE_REP |
203 |
Medium |
| org.mycore.services.queuedjob.MCRJob.getStart() may expose internal representation by returning MCRJob.start |
MALICIOUS_CODE |
EI_EXPOSE_REP |
162 |
Medium |
| org.mycore.services.queuedjob.MCRJob.setAdded(Date) may expose internal representation by storing an externally mutable object into MCRJob.added |
MALICIOUS_CODE |
EI_EXPOSE_REP2 |
152 |
Medium |
| org.mycore.services.queuedjob.MCRJob.setFinished(Date) may expose internal representation by storing an externally mutable object into MCRJob.finished |
MALICIOUS_CODE |
EI_EXPOSE_REP2 |
190 |
Medium |
| org.mycore.services.queuedjob.MCRJob.setParameters(Map) may expose internal representation by storing an externally mutable object into MCRJob.parameters |
MALICIOUS_CODE |
EI_EXPOSE_REP2 |
212 |
Medium |
| org.mycore.services.queuedjob.MCRJob.setStart(Date) may expose internal representation by storing an externally mutable object into MCRJob.start |
MALICIOUS_CODE |
EI_EXPOSE_REP2 |
171 |
Medium |
org.mycore.services.queuedjob.MCRJobAction
| Bug |
Category |
Details |
Line |
Priority |
| new org.mycore.services.queuedjob.MCRJobAction(MCRJob) may expose internal representation by storing an externally mutable object into MCRJobAction.job |
MALICIOUS_CODE |
EI_EXPOSE_REP2 |
42 |
Medium |
org.mycore.services.queuedjob.MCRJobMaster
| Bug |
Category |
Details |
Line |
Priority |
| org.mycore.services.queuedjob.MCRJobMaster.getProcessableCollection() may expose internal representation by returning MCRJobMaster.processableCollection |
MALICIOUS_CODE |
EI_EXPOSE_REP |
344 |
Medium |
| org.mycore.services.queuedjob.MCRJobMaster.run() does not release lock on all exception paths |
MT_CORRECTNESS |
UL_UNRELEASED_LOCK_EXCEPTION_PATH |
189 |
Medium |
org.mycore.services.queuedjob.MCRJobQueue
| Bug |
Category |
Details |
Line |
Priority |
| org.mycore.services.queuedjob.MCRJobQueue.CONFIG_PREFIX isn't final but should be |
MALICIOUS_CODE |
MS_SHOULD_BE_FINAL |
62 |
High |
| org.mycore.services.queuedjob.MCRJobQueue.INSTANCES isn't final but should be |
MALICIOUS_CODE |
MS_SHOULD_BE_FINAL |
60 |
High |
| org.mycore.services.queuedjob.MCRJobQueue.singleQueue isn't final but should be |
MALICIOUS_CODE |
MS_SHOULD_BE_FINAL |
64 |
Medium |
| org.mycore.services.queuedjob.MCRJobQueue.remove(Class, Map) makes inefficient use of keySet iterator instead of entrySet iterator |
PERFORMANCE |
WMI_WRONG_MAP_ITERATOR |
501 |
Medium |
org.mycore.services.queuedjob.MCRJobQueueResource
| Bug |
Category |
Details |
Line |
Priority |
org.mycore.services.queuedjob.MCRJobQueueResource$Job
| Bug |
Category |
Details |
Line |
Priority |
| Unread field: org.mycore.services.queuedjob.MCRJobQueueResource$Job.dates |
PERFORMANCE |
URF_UNREAD_FIELD |
186 |
Medium |
| Unread field: org.mycore.services.queuedjob.MCRJobQueueResource$Job.id |
PERFORMANCE |
URF_UNREAD_FIELD |
168 |
Medium |
| Unread field: org.mycore.services.queuedjob.MCRJobQueueResource$Job.parameters |
PERFORMANCE |
URF_UNREAD_FIELD |
183 |
Medium |
| Unread field: org.mycore.services.queuedjob.MCRJobQueueResource$Job.status |
PERFORMANCE |
URF_UNREAD_FIELD |
169 |
Medium |
org.mycore.services.queuedjob.MCRJobQueueResource$Parameter
| Bug |
Category |
Details |
Line |
Priority |
| Unread field: org.mycore.services.queuedjob.MCRJobQueueResource$Parameter.name |
PERFORMANCE |
URF_UNREAD_FIELD |
220 |
Medium |
| Unread field: org.mycore.services.queuedjob.MCRJobQueueResource$Parameter.value |
PERFORMANCE |
URF_UNREAD_FIELD |
221 |
Medium |
org.mycore.services.queuedjob.MCRJobQueueResource$Queue
| Bug |
Category |
Details |
Line |
Priority |
| Unread field: org.mycore.services.queuedjob.MCRJobQueueResource$Queue.jobs |
PERFORMANCE |
URF_UNREAD_FIELD |
91 |
Medium |
| Unread field: org.mycore.services.queuedjob.MCRJobQueueResource$Queue.name |
PERFORMANCE |
URF_UNREAD_FIELD |
146 |
Medium |
org.mycore.services.queuedjob.MCRJobQueueResource$TypedDate
| Bug |
Category |
Details |
Line |
Priority |
| Unread field: org.mycore.services.queuedjob.MCRJobQueueResource$TypedDate.date |
PERFORMANCE |
URF_UNREAD_FIELD |
204 |
Medium |
| Unread field: org.mycore.services.queuedjob.MCRJobQueueResource$TypedDate.type |
PERFORMANCE |
URF_UNREAD_FIELD |
203 |
Medium |
org.mycore.services.queuedjob.MCRJobThread
| Bug |
Category |
Details |
Line |
Priority |
| new org.mycore.services.queuedjob.MCRJobThread(MCRJob) may expose internal representation by storing an externally mutable object into MCRJobThread.job |
MALICIOUS_CODE |
EI_EXPOSE_REP2 |
60 |
Medium |
org.mycore.services.queuedjob.MCRJob_
org.mycore.services.queuedjob.MCRStalledJobResetter
org.mycore.services.zipper.MCRCompressServlet
| Bug |
Category |
Details |
Line |
Priority |
| org.mycore.services.zipper.MCRCompressServlet.KEY_OBJECT_ID isn't final but should be |
MALICIOUS_CODE |
MS_SHOULD_BE_FINAL |
80 |
High |
| org.mycore.services.zipper.MCRCompressServlet.KEY_PATH isn't final but should be |
MALICIOUS_CODE |
MS_SHOULD_BE_FINAL |
82 |
High |
| Possible null pointer dereference in org.mycore.services.zipper.MCRCompressServlet.getFilename(MCRPath) due to return value of called method |
STYLE |
NP_NULL_ON_SOME_PATH_FROM_RETURN_VALUE |
242 |
Medium |
org.mycore.tools.MCRTopologicalSort
| Bug |
Category |
Details |
Line |
Priority |
| org.mycore.tools.MCRTopologicalSort.getNodes() may expose internal representation by returning MCRTopologicalSort.nodes |
MALICIOUS_CODE |
EI_EXPOSE_REP |
203 |
Medium |
| Switch statement found in org.mycore.tools.MCRTopologicalSort.prepareData(MCRTopologicalSort, String[], Path) where default case is missing |
STYLE |
SF_SWITCH_NO_DEFAULT |
106-136 |
Medium |
| org.mycore.tools.MCRTopologicalSort.prepareData(MCRTopologicalSort, String[], Path) makes inefficient use of keySet iterator instead of entrySet iterator |
PERFORMANCE |
WMI_WRONG_MAP_ITERATOR |
151 |
Medium |
| org.mycore.tools.MCRTopologicalSort.toString() makes inefficient use of keySet iterator instead of entrySet iterator |
PERFORMANCE |
WMI_WRONG_MAP_ITERATOR |
330 |
Medium |
org.mycore.tools.MyCoReWebPageProvider
| Bug |
Category |
Details |
Line |
Priority |
| org.mycore.tools.MyCoReWebPageProvider.getXML() may expose internal representation by returning MyCoReWebPageProvider.xml |
MALICIOUS_CODE |
EI_EXPOSE_REP |
195 |
Medium |
org.mycore.util.concurrent.MCRReadWriteGuard
| Bug |
Category |
Details |
Line |
Priority |
| org.mycore.util.concurrent.MCRReadWriteGuard.lazyLoad(Supplier, Runnable, Supplier) does not release lock on all paths |
MT_CORRECTNESS |
UL_UNRELEASED_LOCK |
77 |
High |
org.mycore.util.concurrent.MCRRunnableComperator
org.mycore.util.concurrent.processing.MCRProcessableSupplier
| Bug |
Category |
Details |
Line |
Priority |
| org.mycore.util.concurrent.processing.MCRProcessableSupplier.getFuture() may expose internal representation by returning MCRProcessableSupplier.future |
MALICIOUS_CODE |
EI_EXPOSE_REP |
116 |
Medium |
