PMD Results
The following document contains the results of PMD 6.49.0.
Violations By Priority
Priority 1
MyCoRe Base Components - org/mycore/datamodel/common/MCRMarkManager.java
| Rule | Violation | Line |
|---|---|---|
| DoubleCheckedLocking | Double checked locking is not thread safe in Java. | 94–104 |
MyCoRe IFS - org/mycore/datamodel/niofs/ifs2/MCRFileSystemUtils.java
| Rule | Violation | Line |
|---|---|---|
| DoubleCheckedLocking | Double checked locking is not thread safe in Java. | 86–102 |
Priority 2
MyCoRe Base Components - org/mycore/datamodel/metadata/validator/MCREditorOutValidator.java
| Rule | Violation | Line |
|---|---|---|
| BrokenNullCheck | Method call on object which may be null | 205–208 |
MyCoRe IView2 - org/mycore/iview2/frontend/MCRIView2Commands.java
| Rule | Violation | Line |
|---|---|---|
| AvoidBranchingStatementAsLastInLoop | Avoid using a branching statement as the last in a loop. | 421 |
Priority 3
MyCoRe ACL - org/mycore/mcr/acl/accesskey/MCRAccessKeyUtils.java
| Rule | Violation | Line |
|---|---|---|
| EmptyCatchBlock | Avoid empty catch blocks | 136–138 |
| EmptyCatchBlock | Avoid empty catch blocks | 144–146 |
| EmptyCatchBlock | Avoid empty catch blocks | 198–200 |
| EmptyCatchBlock | Avoid empty catch blocks | 206–208 |
MyCoRe ACL - org/mycore/mcr/acl/accesskey/model/MCRAccessKey.java
| Rule | Violation | Line |
|---|---|---|
| OverrideBothEqualsAndHashcode | Ensure you override both equals() and hashCode() | 301 |
MyCoRe ACL - org/mycore/mcr/acl/accesskey/restapi/v2/MCRRestDerivateAccessKeys.java
| Rule | Violation | Line |
|---|---|---|
| TooManyStaticImports | Too many static imports may lead to messy code | 19–190 |
MyCoRe Base Components - org/mycore/backend/jpa/access/MCRJPAAccessStore.java
| Rule | Violation | Line |
|---|---|---|
| EmptyCatchBlock | Avoid empty catch blocks | 181–183 |
MyCoRe Base Components - org/mycore/common/MCRSessionMgr.java
| Rule | Violation | Line |
|---|---|---|
| UnusedPrivateMethod | Avoid unused private methods such as 'checkSessionLock()'. | 91 |
MyCoRe Base Components - org/mycore/common/config/MCRConfigurationDir.java
| Rule | Violation | Line |
|---|---|---|
| EmptyCatchBlock | Avoid empty catch blocks | 238–240 |
MyCoRe Base Components - org/mycore/common/content/MCRPathContent.java
| Rule | Violation | Line |
|---|---|---|
| UnusedPrivateField | Avoid unused private fields such as 'LOGGER'. | 47 |
| UnusedPrivateField | Avoid unused private fields such as 'BUFFER_SIZE'. | 53 |
MyCoRe Base Components - org/mycore/common/content/transformer/MCRXSLTransformer.java
| Rule | Violation | Line |
|---|---|---|
| UnusedFormalParameter | Avoid unused method parameters such as 'content'. | 387 |
| EmptyCatchBlock | Avoid empty catch blocks | 423–425 |
MyCoRe Base Components - org/mycore/common/content/util/MCRRestContentHelper.java
| Rule | Violation | Line |
|---|---|---|
| EmptyCatchBlock | Avoid empty catch blocks | 173–175 |
MyCoRe Base Components - org/mycore/common/content/util/MCRServletContentHelper.java
| Rule | Violation | Line |
|---|---|---|
| EmptyCatchBlock | Avoid empty catch blocks | 174–176 |
| CollapsibleIfStatements | These nested if statements could be combined | 267–285 |
| CollapsibleIfStatements | These nested if statements could be combined | 303–308 |
| CollapsibleIfStatements | These nested if statements could be combined | 365–369 |
| EmptyCatchBlock | Avoid empty catch blocks | 426–428 |
MyCoRe Base Components - org/mycore/common/xml/MCRLayoutService.java
| Rule | Violation | Line |
|---|---|---|
| UnusedFormalParameter | Avoid unused method parameters such as 'filename'. | 230 |
MyCoRe Base Components - org/mycore/common/xml/MCRURIResolver.java
| Rule | Violation | Line |
|---|---|---|
| EmptyCatchBlock | Avoid empty catch blocks | 795–797 |
MyCoRe Base Components - org/mycore/common/xsl/MCRParameterCollector.java
| Rule | Violation | Line |
|---|---|---|
| OverrideBothEqualsAndHashcode | Ensure you override both equals() and hashCode() | 357 |
MyCoRe Base Components - org/mycore/datamodel/classifications2/impl/MCRCategoryDAOImpl.java
| Rule | Violation | Line |
|---|---|---|
| EmptyCatchBlock | Avoid empty catch blocks | 144–147 |
MyCoRe Base Components - org/mycore/datamodel/common/MCRDataURL.java
| Rule | Violation | Line |
|---|---|---|
| CollapsibleIfStatements | These nested if statements could be combined | 183–189 |
| UnusedFormalParameter | Avoid unused constructor parameters such as 'mimeType'. | 419 |
MyCoRe Base Components - org/mycore/datamodel/common/MCRISO8601Date.java
| Rule | Violation | Line |
|---|---|---|
| OverrideBothEqualsAndHashcode | Ensure you override both equals() and hashCode() | 282 |
MyCoRe Base Components - org/mycore/datamodel/ifs2/MCRFileCollection.java
| Rule | Violation | Line |
|---|---|---|
| EmptyCatchBlock | Avoid empty catch blocks | 143–145 |
MyCoRe Base Components - org/mycore/datamodel/ifs2/MCRStore.java
| Rule | Violation | Line |
|---|---|---|
| EmptyCatchBlock | Avoid empty catch blocks | 487–489 |
MyCoRe Base Components - org/mycore/datamodel/ifs/MCRFileNodeServlet.java
| Rule | Violation | Line |
|---|---|---|
| UnusedFormalParameter | Avoid unused method parameters such as 'request'. | 160 |
| UnusedFormalParameter | Avoid unused method parameters such as 'response'. | 160 |
MyCoRe Base Components - org/mycore/datamodel/language/MCRLanguageFactory.java
| Rule | Violation | Line |
|---|---|---|
| UnusedLocalVariable | Avoid unused local variables such as 'session'. | 232 |
MyCoRe Base Components - org/mycore/datamodel/metadata/MCRMetaAddress.java
| Rule | Violation | Line |
|---|---|---|
| OverrideBothEqualsAndHashcode | Ensure you override both equals() and hashCode() | 216 |
MyCoRe Base Components - org/mycore/datamodel/metadata/MCRMetaBoolean.java
| Rule | Violation | Line |
|---|---|---|
| UnusedFormalParameter | Avoid unused constructor parameters such as 'lang'. | 74 |
| OverrideBothEqualsAndHashcode | Ensure you override both equals() and hashCode() | 233 |
MyCoRe Base Components - org/mycore/datamodel/metadata/MCRMetaClassification.java
| Rule | Violation | Line |
|---|---|---|
| OverrideBothEqualsAndHashcode | Ensure you override both equals() and hashCode() | 242 |
MyCoRe Base Components - org/mycore/datamodel/metadata/MCRMetaDateLangText.java
| Rule | Violation | Line |
|---|---|---|
| OverrideBothEqualsAndHashcode | Ensure you override both equals() and hashCode() | 195 |
MyCoRe Base Components - org/mycore/datamodel/metadata/MCRMetaHistoryDate.java
| Rule | Violation | Line |
|---|---|---|
| OverrideBothEqualsAndHashcode | Ensure you override both equals() and hashCode() | 534 |
| EmptyCatchBlock | Avoid empty catch blocks | 667–669 |
MyCoRe Base Components - org/mycore/datamodel/metadata/MCRMetaIFS.java
| Rule | Violation | Line |
|---|---|---|
| OverrideBothEqualsAndHashcode | Ensure you override both equals() and hashCode() | 230 |
MyCoRe Base Components - org/mycore/datamodel/metadata/MCRMetaISO8601Date.java
| Rule | Violation | Line |
|---|---|---|
| OverrideBothEqualsAndHashcode | Ensure you override both equals() and hashCode() | 256 |
MyCoRe Base Components - org/mycore/datamodel/metadata/MCRMetaInstitutionName.java
| Rule | Violation | Line |
|---|---|---|
| OverrideBothEqualsAndHashcode | Ensure you override both equals() and hashCode() | 249 |
MyCoRe Base Components - org/mycore/datamodel/metadata/MCRMetaLangText.java
| Rule | Violation | Line |
|---|---|---|
| OverrideBothEqualsAndHashcode | Ensure you override both equals() and hashCode() | 285 |
MyCoRe Base Components - org/mycore/datamodel/metadata/MCRMetaLink.java
| Rule | Violation | Line |
|---|---|---|
| CollapsibleIfStatements | These nested if statements could be combined | 238–240 |
| CollapsibleIfStatements | These nested if statements could be combined | 408–410 |
| CollapsibleIfStatements | These nested if statements could be combined | 432–434 |
MyCoRe Base Components - org/mycore/datamodel/metadata/MCRMetaLinkID.java
| Rule | Violation | Line |
|---|---|---|
| OverrideBothEqualsAndHashcode | Ensure you override both equals() and hashCode() | 241 |
MyCoRe Base Components - org/mycore/datamodel/metadata/MCRMetaNumber.java
| Rule | Violation | Line |
|---|---|---|
| BigIntegerInstantiation | Dont create instances of already existing BigInteger and BigDecimal (ZERO, ONE, TEN) | 105 |
| OverrideBothEqualsAndHashcode | Ensure you override both equals() and hashCode() | 351 |
MyCoRe Base Components - org/mycore/datamodel/metadata/MCRMetaPersonName.java
| Rule | Violation | Line |
|---|---|---|
| OverrideBothEqualsAndHashcode | Ensure you override both equals() and hashCode() | 444 |
MyCoRe Base Components - org/mycore/datamodel/metadata/MCRMetaXML.java
| Rule | Violation | Line |
|---|---|---|
| OverrideBothEqualsAndHashcode | Ensure you override both equals() and hashCode() | 185 |
MyCoRe Base Components - org/mycore/datamodel/niofs/MCRPathUtils.java
| Rule | Violation | Line |
|---|---|---|
| EmptyCatchBlock | Avoid empty catch blocks | 64–66 |
MyCoRe Base Components - org/mycore/datamodel/niofs/utils/MCRTreeCopier.java
| Rule | Violation | Line |
|---|---|---|
| EmptyCatchBlock | Avoid empty catch blocks | 78–81 |
MyCoRe Base Components - org/mycore/frontend/MCRFrontendUtil.java
| Rule | Violation | Line |
|---|---|---|
| AvoidUsingHardCodedIP | Do not hard code the IP address | 72 |
| AvoidUsingHardCodedIP | Do not hard code the IP address | 75 |
MyCoRe Base Components - org/mycore/frontend/cli/MCRBatchEditorCommands.java
| Rule | Violation | Line |
|---|---|---|
| CollapsibleIfStatements | These nested if statements could be combined | 140–142 |
MyCoRe Base Components - org/mycore/frontend/cli/MCRCommandLineInterface.java
| Rule | Violation | Line |
|---|---|---|
| AvoidUsingHardCodedIP | Do not hard code the IP address | 175 |
| UnusedFormalParameter | Avoid unused method parameters such as 'session'. | 233 |
MyCoRe Base Components - org/mycore/frontend/fileupload/MCRUploadViaFormServlet.java
| Rule | Violation | Line |
|---|---|---|
| UnusedLocalVariable | Avoid unused local variables such as 'session'. | 97 |
MyCoRe Base Components - org/mycore/frontend/filter/MCRSecureTokenV2Filter.java
| Rule | Violation | Line |
|---|---|---|
| CollapsibleIfStatements | These nested if statements could be combined | 85–89 |
MyCoRe Base Components - org/mycore/frontend/jersey/filter/MCRDBTransactionFilter.java
| Rule | Violation | Line |
|---|---|---|
| UnusedLocalVariable | Avoid unused local variables such as 'session'. | 34 |
MyCoRe Base Components - org/mycore/frontend/servlets/MCRObjectServlet.java
| Rule | Violation | Line |
|---|---|---|
| UnusedPrivateField | Avoid unused private fields such as 'REV_CURRENT'. | 50 |
MyCoRe Base Components - org/mycore/frontend/servlets/MCRServlet.java
| Rule | Violation | Line |
|---|---|---|
| UnusedFormalParameter | Avoid unused method parameters such as 'context'. | 122 |
| UnusedLocalVariable | Avoid unused local variables such as 'session'. | 299 |
| UnusedLocalVariable | Avoid unused local variables such as 'session'. | 410 |
| UnusedLocalVariable | Avoid unused local variables such as 'session'. | 449 |
MyCoRe Base Components - org/mycore/frontend/servlets/MCRServletJob.java
| Rule | Violation | Line |
|---|---|---|
| AvoidUsingHardCodedIP | Do not hard code the IP address | 75 |
MyCoRe Base Components - org/mycore/services/i18n/MCRTranslation.java
| Rule | Violation | Line |
|---|---|---|
| EmptyCatchBlock | Avoid empty catch blocks | 173–174 |
MyCoRe Base Components - org/mycore/services/queuedjob/MCRJobMaster.java
| Rule | Violation | Line |
|---|---|---|
| AvoidThreadGroup | Avoid using java.lang.ThreadGroup; it is not thread safe | 156 |
MyCoRe Base Components - org/mycore/tools/MCRTopologicalSort.java
| Rule | Violation | Line |
|---|---|---|
| CollapsibleIfStatements | These nested if statements could be combined | 306–309 |
MyCoRe Classification Editor - org/mycore/frontend/classeditor/MCRCategoryListTypeAdapter.java
| Rule | Violation | Line |
|---|---|---|
| TooManyStaticImports | Too many static imports may lead to messy code | 19–106 |
MyCoRe Classification Editor - org/mycore/frontend/classeditor/MCRCategoryTypeAdapter.java
| Rule | Violation | Line |
|---|---|---|
| TooManyStaticImports | Too many static imports may lead to messy code | 19–129 |
MyCoRe FO - org/mycore/component/fo/common/fo/MCRFoFormatterFOP.java
| Rule | Violation | Line |
|---|---|---|
| EmptyCatchBlock | Avoid empty catch blocks | 127–128 |
MyCoRe IIIF - org/mycore/iiif/image/model/MCRIIIFImageSourceRegion.java
| Rule | Violation | Line |
|---|---|---|
| OverrideBothEqualsAndHashcode | Ensure you override both equals() and hashCode() | 54 |
MyCoRe IIIF - org/mycore/iiif/image/model/MCRIIIFImageTargetRotation.java
| Rule | Violation | Line |
|---|---|---|
| OverrideBothEqualsAndHashcode | Ensure you override both equals() and hashCode() | 46 |
MyCoRe IIIF - org/mycore/iiif/image/model/MCRIIIFImageTargetSize.java
| Rule | Violation | Line |
|---|---|---|
| OverrideBothEqualsAndHashcode | Ensure you override both equals() and hashCode() | 43 |
MyCoRe IIIF - org/mycore/iiif/image/resources/MCRIIIFImageResource.java
| Rule | Violation | Line |
|---|---|---|
| TooManyStaticImports | Too many static imports may lead to messy code | 19–215 |
MyCoRe IView2 - org/mycore/iview2/services/MCRImageTiler.java
| Rule | Violation | Line |
|---|---|---|
| AvoidThreadGroup | Avoid using java.lang.ThreadGroup; it is not thread safe | 131 |
MyCoRe Linked Open Data - org/mycore/lod/MCRJerseyLodApp.java
| Rule | Violation | Line |
|---|---|---|
| EmptyCatchBlock | Avoid empty catch blocks | 121–123 |
MyCoRe migration tools - org/mycore/migration/cli/MCRMigrationCommands.java
| Rule | Violation | Line |
|---|---|---|
| UnusedFormalParameter | Avoid unused method parameters such as 'href'. | 221 |
MyCoRe MODS - org/mycore/mods/MCRMODSWrapper.java
| Rule | Violation | Line |
|---|---|---|
| EmptyCatchBlock | Avoid empty catch blocks | 151–153 |
MyCoRe MODS - org/mycore/mods/enrichment/MCRDataSourceCall.java
| Rule | Violation | Line |
|---|---|---|
| SimplifiedTernary | Ternary operators that can be simplified with || or && | 96 |
MyCoRe MODS - org/mycore/mods/merger/MCRExtentMerger.java
| Rule | Violation | Line |
|---|---|---|
| UselessOverridingMethod | Overriding method merely calls super | 31–33 |
MyCoRe MODS - org/mycore/mods/merger/MCRIdentifierMerger.java
| Rule | Violation | Line |
|---|---|---|
| UselessOverridingMethod | Overriding method merely calls super | 37–39 |
MyCoRe MODS - org/mycore/mods/merger/MCRMerger.java
| Rule | Violation | Line |
|---|---|---|
| OverrideBothEqualsAndHashcode | Ensure you override both equals() and hashCode() | 73 |
MyCoRe MODS - org/mycore/mods/merger/MCRRelatedItemMerger.java
| Rule | Violation | Line |
|---|---|---|
| UselessOverridingMethod | Overriding method merely calls super | 32–34 |
MyCoRe MODS - org/mycore/mods/merger/MCRUniqueMerger.java
| Rule | Violation | Line |
|---|---|---|
| UselessOverridingMethod | Overriding method merely calls super | 31–33 |
MyCoRe MODS - org/mycore/mods/merger/MCRUniqueTypeMerger.java
| Rule | Violation | Line |
|---|---|---|
| UselessOverridingMethod | Overriding method merely calls super | 32–34 |
MyCoRe OAI-PMH 2.0 Data Provider - org/mycore/oai/MCROAISetManager.java
| Rule | Violation | Line |
|---|---|---|
| CollapsibleIfStatements | These nested if statements could be combined | 229–231 |
MyCoRe Persistent Identifier - org/mycore/pi/doi/MCRCrossrefService.java
| Rule | Violation | Line |
|---|---|---|
| UnusedPrivateField | Avoid unused private fields such as 'LOGGER'. | 66 |
MyCoRe Persistent Identifier - org/mycore/pi/doi/MCRDOIBaseService.java
| Rule | Violation | Line |
|---|---|---|
| UnusedLocalVariable | Avoid unused local variables such as 'transformer'. | 84 |
MyCoRe Persistent Identifier - org/mycore/pi/exceptions/MCRIdentifierUnresolvableException.java
| Rule | Violation | Line |
|---|---|---|
| UnusedPrivateField | Avoid unused private fields such as 'identifier'. | 23 |
MyCoRe Persistent Identifier - org/mycore/pi/urn/MCRURNOAIService.java
| Rule | Violation | Line |
|---|---|---|
| UnusedPrivateField | Avoid unused private fields such as 'LOGGER'. | 34 |
MyCoRe REST API - org/mycore/restapi/MCRNormalizeMCRObjectIDsFilter.java
| Rule | Violation | Line |
|---|---|---|
| EmptyCatchBlock | Avoid empty catch blocks | 105–108 |
| EmptyCatchBlock | Avoid empty catch blocks | 130–132 |
MyCoRe REST API - org/mycore/restapi/MCRTransactionFilter.java
| Rule | Violation | Line |
|---|---|---|
| UnusedLocalVariable | Avoid unused local variables such as 'mcrSession'. | 47 |
MyCoRe REST API - org/mycore/restapi/v1/MCRRestAPIClassifications.java
| Rule | Violation | Line |
|---|---|---|
| EmptyCatchBlock | Avoid empty catch blocks | 267–269 |
| EmptyCatchBlock | Avoid empty catch blocks | 296–298 |
MyCoRe REST API - org/mycore/restapi/v1/MCRRestAPIMessages.java
| Rule | Violation | Line |
|---|---|---|
| EmptyCatchBlock | Avoid empty catch blocks | 130–132 |
| EmptyCatchBlock | Avoid empty catch blocks | 188–190 |
MyCoRe REST API - org/mycore/restapi/v1/utils/MCRRestAPIObjectsHelper.java
| Rule | Violation | Line |
|---|---|---|
| EmptyCatchBlock | Avoid empty catch blocks | 293–295 |
| EmptyCatchBlock | Avoid empty catch blocks | 427–429 |
MyCoRe REST API - org/mycore/restapi/v2/MCRRestDerivateContents.java
| Rule | Violation | Line |
|---|---|---|
| UnusedLocalVariable | Avoid unused local variables such as 'mcrSession'. | 154 |
MyCoRe REST API - org/mycore/restapi/v2/MCRRestDerivates.java
| Rule | Violation | Line |
|---|---|---|
| EmptyCatchBlock | Avoid empty catch blocks | 225–227 |
MyCoRe REST API - org/mycore/restapi/v2/MCRRestObjects.java
| Rule | Violation | Line |
|---|---|---|
| EmptyCatchBlock | Avoid empty catch blocks | 620–622 |
| EmptyCatchBlock | Avoid empty catch blocks | 687–689 |
MyCoRe Solr Support - org/mycore/solr/commands/MCRSolrCommands.java
| Rule | Violation | Line |
|---|---|---|
| TooManyStaticImports | Too many static imports may lead to messy code | 19–305 |
MyCoRe Solr Support - org/mycore/solr/index/handlers/content/MCRSolrMCRContentMapIndexHandler.java
| Rule | Violation | Line |
|---|---|---|
| UnusedFormalParameter | Avoid unused constructor parameters such as 'solrClient'. | 61 |
MyCoRe Solr Support - org/mycore/solr/search/MCRSolrSearchServlet.java
| Rule | Violation | Line |
|---|---|---|
| UselessOverridingMethod | Overriding method merely calls super | 278–280 |
MyCoRe SWORD Interface - org/mycore/sword/MCRSwordUtil.java
| Rule | Violation | Line |
|---|---|---|
| UnusedLocalVariable | Avoid unused local variables such as 'currentSession'. | 182 |
| UnusedLocalVariable | Avoid unused local variables such as 'currentSession'. | 227 |
| UnusedLocalVariable | Avoid unused local variables such as 'currentSession'. | 285 |
MyCoRe SWORD Interface - org/mycore/sword/manager/MCRSwordServiceDocumentManager.java
| Rule | Violation | Line |
|---|---|---|
| UnusedFormalParameter | Avoid unused method parameters such as 'auth'. | 66 |
MyCoRe New User System - org/mycore/user2/MCRRole.java
| Rule | Violation | Line |
|---|---|---|
| UnusedPrivateMethod | Avoid unused private methods such as 'getLabelsArray()'. | 104 |
MyCoRe New User System - org/mycore/user2/MCRUser.java
| Rule | Violation | Line |
|---|---|---|
| SimplifiedTernary | Ternary operators that can be simplified with || or && | 204 |
| SimplifiedTernary | Ternary operators that can be simplified with || or && | 219 |
| UnusedPrivateMethod | Avoid unused private methods such as 'getEMail()'. | 400 |
| UnusedPrivateMethod | Avoid unused private methods such as 'getOwnerId()'. | 728 |
MyCoRe New User System - org/mycore/user2/MCRUserServlet.java
| Rule | Violation | Line |
|---|---|---|
| UnusedFormalParameter | Avoid unused method parameters such as 'req'. | 119 |
MyCoRe Viewer - org/mycore/viewer/resources/MCREpubZipResource.java
| Rule | Violation | Line |
|---|---|---|
| EmptyCatchBlock | Avoid empty catch blocks | 162–164 |
MyCoRe XEditor - org/mycore/frontend/xeditor/MCRPostProcessorXSL.java
| Rule | Violation | Line |
|---|---|---|
| EmptyCatchBlock | Avoid empty catch blocks | 73–75 |
Priority 4
MyCoRe ACL - org/mycore/mcr/acl/accesskey/MCRAccessKeyManager.java
| Rule | Violation | Line |
|---|---|---|
| UselessParentheses | Useless parentheses. | 89 |
MyCoRe ACL - org/mycore/mcr/acl/accesskey/restapi/v2/MCRRestAccessKeyExceptionMapper.java
| Rule | Violation | Line |
|---|---|---|
| UselessParentheses | Useless parentheses. | 59 |
MyCoRe ACL - org/mycore/mcr/acl/accesskey/strategy/MCRAccessKeyStrategyHelper.java
| Rule | Violation | Line |
|---|---|---|
| UselessParentheses | Useless parentheses. | 67–68 |
MyCoRe Base Components - org/mycore/access/mcrimpl/MCRGroupClause.java
| Rule | Violation | Line |
|---|---|---|
| UselessParentheses | Useless parentheses. | 62 |
MyCoRe Base Components - org/mycore/access/mcrimpl/MCRRuleParser.java
| Rule | Violation | Line |
|---|---|---|
| UnnecessaryFullyQualifiedName | Unnecessary use of fully qualified name 'java.text.ParseException' due to existing import 'java.text.ParseException' | 43 |
MyCoRe Base Components - org/mycore/access/mcrimpl/MCRUserClause.java
| Rule | Violation | Line |
|---|---|---|
| UselessParentheses | Useless parentheses. | 85 |
MyCoRe Base Components - org/mycore/common/MCRCalendar.java
| Rule | Violation | Line |
|---|---|---|
| UselessParentheses | Useless parentheses. | 283 |
| UselessParentheses | Useless parentheses. | 286 |
| UselessParentheses | Useless parentheses. | 286 |
| UselessParentheses | Useless parentheses. | 288 |
| UselessParentheses | Useless parentheses. | 288 |
| UselessParentheses | Useless parentheses. | 808 |
| UselessParentheses | Useless parentheses. | 855 |
MyCoRe Base Components - org/mycore/common/MCRConstants.java
| Rule | Violation | Line |
|---|---|---|
| UselessParentheses | Useless parentheses. | 157 |
MyCoRe Base Components - org/mycore/common/MCRExceptionCauseFinder.java
| Rule | Violation | Line |
|---|---|---|
| UselessParentheses | Useless parentheses. | 36 |
| UselessParentheses | Useless parentheses. | 41 |
MyCoRe Base Components - org/mycore/common/MCRGeoUtilities.java
| Rule | Violation | Line |
|---|---|---|
| UselessParentheses | Useless parentheses. | 35 |
| UselessParentheses | Useless parentheses. | 35 |
| UselessParentheses | Useless parentheses. | 44 |
| UselessParentheses | Useless parentheses. | 61 |
| UselessParentheses | Useless parentheses. | 61 |
| UselessParentheses | Useless parentheses. | 84 |
MyCoRe Base Components - org/mycore/common/MCRMailer.java
| Rule | Violation | Line |
|---|---|---|
| UselessParentheses | Useless parentheses. | 395 |
| UnnecessaryFullyQualifiedName | Unnecessary use of fully qualified name 'jakarta.mail.Authenticator' due to existing import 'jakarta.mail.Authenticator' | 778 |
MyCoRe Base Components - org/mycore/common/content/transformer/MCRToPrettyXML.java
| Rule | Violation | Line |
|---|---|---|
| UselessParentheses | Useless parentheses. | 41 |
MyCoRe Base Components - org/mycore/common/content/transformer/MCRXSLTransformer.java
| Rule | Violation | Line |
|---|---|---|
| UselessParentheses | Useless parentheses. | 367 |
MyCoRe Base Components - org/mycore/common/events/MCRServletContainerInitializer.java
| Rule | Violation | Line |
|---|---|---|
| UselessParentheses | Useless parentheses. | 95 |
MyCoRe Base Components - org/mycore/common/xml/MCRAttributeValueFilter.java
| Rule | Violation | Line |
|---|---|---|
| UselessParentheses | Useless parentheses. | 49 |
MyCoRe Base Components - org/mycore/common/xml/MCRNodeBuilder.java
| Rule | Violation | Line |
|---|---|---|
| UselessParentheses | Useless parentheses. | 203 |
| UselessParentheses | Useless parentheses. | 203 |
| UselessParentheses | Useless parentheses. | 205 |
| UselessParentheses | Useless parentheses. | 205 |
| UselessParentheses | Useless parentheses. | 252 |
| UselessParentheses | Useless parentheses. | 252 |
| UselessParentheses | Useless parentheses. | 262 |
MyCoRe Base Components - org/mycore/common/xml/MCRURIResolver.java
| Rule | Violation | Line |
|---|---|---|
| UnnecessaryFullyQualifiedName | Unnecessary use of fully qualified name 'org.apache.logging.log4j.Logger' due to existing import 'org.apache.logging.log4j.Logger' | 451 |
MyCoRe Base Components - org/mycore/common/xml/MCRXPathBuilder.java
| Rule | Violation | Line |
|---|---|---|
| UselessParentheses | Useless parentheses. | 85 |
| UselessParentheses | Useless parentheses. | 85 |
| UselessParentheses | Useless parentheses. | 111 |
| UselessParentheses | Useless parentheses. | 120 |
| UselessParentheses | Useless parentheses. | 120 |
MyCoRe Base Components - org/mycore/common/xsl/MCRParameterCollector.java
| Rule | Violation | Line |
|---|---|---|
| UselessParentheses | Useless parentheses. | 168 |
MyCoRe Base Components - org/mycore/crypt/MCRAESCipher.java
| Rule | Violation | Line |
|---|---|---|
| UselessParentheses | Useless parentheses. | 96 |
MyCoRe Base Components - org/mycore/datamodel/classifications2/impl/MCRCategLinkServiceImpl.java
| Rule | Violation | Line |
|---|---|---|
| UnnecessaryFullyQualifiedName | Unnecessary use of fully qualified name 'jakarta.persistence.Query' due to existing import 'jakarta.persistence.Query' | 157 |
MyCoRe Base Components - org/mycore/datamodel/common/MCRDefaultXMLMetadataManager.java
| Rule | Violation | Line |
|---|---|---|
| UselessParentheses | Useless parentheses. | 180 |
MyCoRe Base Components - org/mycore/datamodel/ifs2/MCRVersioningMetadataStore.java
| Rule | Violation | Line |
|---|---|---|
| UselessParentheses | Useless parentheses. | 103 |
MyCoRe Base Components - org/mycore/datamodel/language/MCRLanguageFactory.java
| Rule | Violation | Line |
|---|---|---|
| UselessParentheses | Useless parentheses. | 119 |
| UselessParentheses | Useless parentheses. | 162 |
| UselessParentheses | Useless parentheses. | 163 |
MyCoRe Base Components - org/mycore/datamodel/language/MCRLanguageXML.java
| Rule | Violation | Line |
|---|---|---|
| UselessParentheses | Useless parentheses. | 54 |
| UselessParentheses | Useless parentheses. | 58 |
MyCoRe Base Components - org/mycore/datamodel/metadata/MCRMetaElement.java
| Rule | Violation | Line |
|---|---|---|
| UselessParentheses | Useless parentheses. | 129 |
| UselessParentheses | Useless parentheses. | 129 |
| UselessParentheses | Useless parentheses. | 252 |
| UselessParentheses | Useless parentheses. | 252 |
| UselessParentheses | Useless parentheses. | 355 |
| UselessParentheses | Useless parentheses. | 386 |
| UselessParentheses | Useless parentheses. | 456 |
MyCoRe Base Components - org/mycore/datamodel/metadata/MCRMetaEnrichedLinkID.java
| Rule | Violation | Line |
|---|---|---|
| UselessParentheses | Useless parentheses. | 181–182 |
MyCoRe Base Components - org/mycore/datamodel/metadata/MCRMetaHistoryDate.java
| Rule | Violation | Line |
|---|---|---|
| UselessParentheses | Useless parentheses. | 229 |
MyCoRe Base Components - org/mycore/datamodel/metadata/MCRMetadataManager.java
| Rule | Violation | Line |
|---|---|---|
| UselessParentheses | Useless parentheses. | 854 |
MyCoRe Base Components - org/mycore/datamodel/metadata/MCRObjectDerivate.java
| Rule | Violation | Line |
|---|---|---|
| UselessParentheses | Useless parentheses. | 195 |
| UselessParentheses | Useless parentheses. | 195 |
| UselessParentheses | Useless parentheses. | 217 |
| UselessParentheses | Useless parentheses. | 217 |
| UselessParentheses | Useless parentheses. | 459 |
| UselessParentheses | Useless parentheses. | 459 |
MyCoRe Base Components - org/mycore/datamodel/metadata/MCRObjectID.java
| Rule | Violation | Line |
|---|---|---|
| UselessParentheses | Useless parentheses. | 403 |
MyCoRe Base Components - org/mycore/datamodel/niofs/MCRPath.java
| Rule | Violation | Line |
|---|---|---|
| UselessParentheses | Useless parentheses. | 319 |
| UselessParentheses | Useless parentheses. | 523 |
MyCoRe Base Components - org/mycore/datamodel/niofs/MCRPathXML.java
| Rule | Violation | Line |
|---|---|---|
| UselessParentheses | Useless parentheses. | 79 |
MyCoRe Base Components - org/mycore/datamodel/niofs/MCRPaths.java
| Rule | Violation | Line |
|---|---|---|
| UselessParentheses | Useless parentheses. | 60 |
MyCoRe Base Components - org/mycore/frontend/MCRFrontendUtil.java
| Rule | Violation | Line |
|---|---|---|
| UselessParentheses | Useless parentheses. | 265 |
| UselessParentheses | Useless parentheses. | 268 |
MyCoRe Base Components - org/mycore/frontend/MCRLayoutUtilities.java
| Rule | Violation | Line |
|---|---|---|
| UselessParentheses | Useless parentheses. | 512 |
MyCoRe Base Components - org/mycore/frontend/basket/MCRBasket.java
| Rule | Violation | Line |
|---|---|---|
| UselessParentheses | Useless parentheses. | 208 |
| UselessParentheses | Useless parentheses. | 256 |
| UselessParentheses | Useless parentheses. | 256 |
MyCoRe Base Components - org/mycore/frontend/basket/MCRBasketEntry.java
| Rule | Violation | Line |
|---|---|---|
| UselessParentheses | Useless parentheses. | 78 |
MyCoRe Base Components - org/mycore/frontend/basket/MCRBasketManager.java
| Rule | Violation | Line |
|---|---|---|
| UselessParentheses | Useless parentheses. | 80 |
MyCoRe Base Components - org/mycore/frontend/cli/MCRDeveloperCommands.java
| Rule | Violation | Line |
|---|---|---|
| UselessParentheses | Useless parentheses. | 55 |
MyCoRe Base Components - org/mycore/frontend/export/MCRExportCollection.java
| Rule | Violation | Line |
|---|---|---|
| UselessParentheses | Useless parentheses. | 54 |
| UselessParentheses | Useless parentheses. | 54 |
MyCoRe Base Components - org/mycore/frontend/export/MCRExportServlet.java
| Rule | Violation | Line |
|---|---|---|
| UselessParentheses | Useless parentheses. | 120 |
MyCoRe Base Components - org/mycore/frontend/fileupload/MCRUploadHandlerIFS.java
| Rule | Violation | Line |
|---|---|---|
| UselessParentheses | Useless parentheses. | 302–303 |
| UselessParentheses | Useless parentheses. | 302 |
| UselessParentheses | Useless parentheses. | 302–303 |
| UselessParentheses | Useless parentheses. | 304 |
MyCoRe Base Components - org/mycore/frontend/jersey/resources/MCRLocaleResource.java
| Rule | Violation | Line |
|---|---|---|
| UselessParentheses | Useless parentheses. | 54 |
MyCoRe Base Components - org/mycore/frontend/servlets/MCRDerivateServlet.java
| Rule | Violation | Line |
|---|---|---|
| UselessParentheses | Useless parentheses. | 62 |
MyCoRe Base Components - org/mycore/frontend/servlets/MCRDisplayHideDerivateServlet.java
| Rule | Violation | Line |
|---|---|---|
| UselessParentheses | Useless parentheses. | 48 |
MyCoRe Base Components - org/mycore/frontend/servlets/MCRStaticXMLFileServlet.java
| Rule | Violation | Line |
|---|---|---|
| UnnecessaryFullyQualifiedName | Unnecessary use of fully qualified name 'java.io.IOException' due to existing import 'java.io.IOException' | 58 |
MyCoRe Base Components - org/mycore/parsers/bool/MCRBooleanClauseParser.java
| Rule | Violation | Line |
|---|---|---|
| UselessParentheses | Useless parentheses. | 232 |
| UselessParentheses | Useless parentheses. | 232 |
MyCoRe Base Components - org/mycore/services/i18n/MCRTranslation.java
| Rule | Violation | Line |
|---|---|---|
| UnnecessaryFullyQualifiedName | Unnecessary use of fully qualified name 'java.util.MissingResourceException' due to existing import 'java.util.MissingResourceException' | 173 |
MyCoRe Base Components - org/mycore/services/packaging/MCRPackerServlet.java
| Rule | Violation | Line |
|---|---|---|
| UselessParentheses | Useless parentheses. | 83 |
MyCoRe Base Components - org/mycore/services/queuedjob/MCRJobMaster.java
| Rule | Violation | Line |
|---|---|---|
| UselessParentheses | Useless parentheses. | 326 |
MyCoRe Base Components - org/mycore/services/queuedjob/MCRJobQueue.java
| Rule | Violation | Line |
|---|---|---|
| UselessParentheses | Useless parentheses. | 208 |
| UselessParentheses | Useless parentheses. | 208 |
MyCoRe Classification Browser - org/mycore/frontend/servlets/MCRClassificationBrowser2.java
| Rule | Violation | Line |
|---|---|---|
| UselessParentheses | Useless parentheses. | 116 |
| UselessParentheses | Useless parentheses. | 116 |
| UselessParentheses | Useless parentheses. | 145 |
| UselessParentheses | Useless parentheses. | 177 |
| UselessParentheses | Useless parentheses. | 199 |
| UselessParentheses | Useless parentheses. | 201 |
| UselessParentheses | Useless parentheses. | 201 |
MyCoRe FO - org/mycore/component/fo/common/fo/MCRFoFormatterFOP.java
| Rule | Violation | Line |
|---|---|---|
| UselessParentheses | Useless parentheses. | 124 |
| UselessParentheses | Useless parentheses. | 124 |
MyCoRe IFS - org/mycore/datamodel/niofs/ifs2/MCRDirectoryStreamHelper.java
| Rule | Violation | Line |
|---|---|---|
| UselessParentheses | Useless parentheses. | 66 |
MyCoRe IIIF - org/mycore/iiif/image/impl/MCRIIIFImageImpl.java
| Rule | Violation | Line |
|---|---|---|
| UselessParentheses | Useless parentheses. | 51 |
MyCoRe IIIF - org/mycore/iiif/image/model/MCRIIIFImageSourceRegion.java
| Rule | Violation | Line |
|---|---|---|
| UselessParentheses | Useless parentheses. | 55 |
MyCoRe IIIF - org/mycore/iiif/presentation/impl/MCRIIIFPresentationImpl.java
| Rule | Violation | Line |
|---|---|---|
| UselessParentheses | Useless parentheses. | 44 |
MyCoRe Sitemap Protocol support - org/mycore/frontend/indexbrowser/MCRGoogleSitemapCommon.java
| Rule | Violation | Line |
|---|---|---|
| UselessParentheses | Useless parentheses. | 139 |
| UselessParentheses | Useless parentheses. | 139 |
| UselessParentheses | Useless parentheses. | 275 |
| UselessParentheses | Useless parentheses. | 275 |
| UselessParentheses | Useless parentheses. | 306 |
MyCoRe IView2 - org/mycore/iview2/events/MCRThumbnailForPdfEventHandler.java
| Rule | Violation | Line |
|---|---|---|
| UselessParentheses | Useless parentheses. | 115 |
MyCoRe IView2 - org/mycore/iview2/frontend/MCRIView2XSLFunctionsAdapter.java
| Rule | Violation | Line |
|---|---|---|
| UselessParentheses | Useless parentheses. | 62 |
MyCoRe IView2 - org/mycore/iview2/frontend/resources/MCRIViewZipResource.java
| Rule | Violation | Line |
|---|---|---|
| UselessParentheses | Useless parentheses. | 116 |
MyCoRe IView2 - org/mycore/iview2/iiif/MCRIVIEWIIIFImageImpl.java
| Rule | Violation | Line |
|---|---|---|
| UselessParentheses | Useless parentheses. | 181 |
| UselessParentheses | Useless parentheses. | 182 |
MyCoRe IView2 - org/mycore/iview2/services/MCRIView2Tools.java
| Rule | Violation | Line |
|---|---|---|
| UselessParentheses | Useless parentheses. | 226 |
| UselessParentheses | Useless parentheses. | 231–232 |
| UselessParentheses | Useless parentheses. | 233–234 |
MyCoRe IView2 - org/mycore/iview2/services/MCRImageThumbnailGenerator.java
| Rule | Violation | Line |
|---|---|---|
| UselessParentheses | Useless parentheses. | 67 |
MyCoRe METS - org/mycore/mets/iiif/MCRMetsMods2IIIFConverter.java
| Rule | Violation | Line |
|---|---|---|
| UselessParentheses | Useless parentheses. | 161 |
MyCoRe METS - org/mycore/mets/model/MCRMETSDefaultGenerator.java
| Rule | Violation | Line |
|---|---|---|
| UselessParentheses | Useless parentheses. | 185 |
MyCoRe METS - org/mycore/mets/servlets/MCRMETSServlet.java
| Rule | Violation | Line |
|---|---|---|
| UselessParentheses | Useless parentheses. | 154 |
| UselessParentheses | Useless parentheses. | 169 |
MyCoRe MODS - org/mycore/mods/MCRMODSDateHelper.java
| Rule | Violation | Line |
|---|---|---|
| UselessParentheses | Useless parentheses. | 47 |
MyCoRe MODS - org/mycore/mods/MCRMODSPagesHelper.java
| Rule | Violation | Line |
|---|---|---|
| UselessParentheses | Useless parentheses. | 110 |
| UselessParentheses | Useless parentheses. | 110 |
MyCoRe MODS - org/mycore/mods/MCRMODSWrapper.java
| Rule | Violation | Line |
|---|---|---|
| UselessParentheses | Useless parentheses. | 215 |
| UselessParentheses | Useless parentheses. | 329 |
| UselessParentheses | Useless parentheses. | 337 |
MyCoRe MODS - org/mycore/mods/access/facts/condition/MCRMODSCollectionCondition.java
| Rule | Violation | Line |
|---|---|---|
| UselessParentheses | Useless parentheses. | 62 |
MyCoRe MODS - org/mycore/mods/access/facts/condition/MCRMODSGenreCondition.java
| Rule | Violation | Line |
|---|---|---|
| UselessParentheses | Useless parentheses. | 62 |
MyCoRe MODS - org/mycore/mods/bibtex/MCRUnsupportedFieldTransformer.java
| Rule | Violation | Line |
|---|---|---|
| UselessParentheses | Useless parentheses. | 56 |
MyCoRe MODS - org/mycore/mods/classification/MCRTypeOfResource.java
| Rule | Violation | Line |
|---|---|---|
| UselessParentheses | Useless parentheses. | 76 |
MyCoRe MODS - org/mycore/mods/enrichment/MCRIdentifier.java
| Rule | Violation | Line |
|---|---|---|
| UselessParentheses | Useless parentheses. | 52 |
MyCoRe MODS - org/mycore/mods/merger/MCRExtentMerger.java
| Rule | Violation | Line |
|---|---|---|
| UselessParentheses | Useless parentheses. | 37 |
| UselessParentheses | Useless parentheses. | 49 |
MyCoRe MODS - org/mycore/mods/merger/MCRUniqueMerger.java
| Rule | Violation | Line |
|---|---|---|
| UselessParentheses | Useless parentheses. | 37 |
MyCoRe MODS - org/mycore/mods/rss/MCRRSSFeedImporter.java
| Rule | Violation | Line |
|---|---|---|
| UselessParentheses | Useless parentheses. | 156 |
| UselessParentheses | Useless parentheses. | 156 |
| UselessParentheses | Useless parentheses. | 215 |
MyCoRe OAI-PMH 2.0 Data Provider - org/mycore/oai/MCROAISearchManager.java
| Rule | Violation | Line |
|---|---|---|
| UselessParentheses | Useless parentheses. | 100 |
MyCoRe OAI-PMH 2.0 Data Provider - org/mycore/oai/MCROAISetManager.java
| Rule | Violation | Line |
|---|---|---|
| UnnecessaryFullyQualifiedName | Unnecessary use of fully qualified name 'OAIConstants.NS_OAI' due to existing static import 'org.mycore.oai.pmh.OAIConstants.NS_OAI' | 225 |
MyCoRe ORCID Integration - org/mycore/orcid/oauth/MCROAuthServlet.java
| Rule | Violation | Line |
|---|---|---|
| UselessParentheses | Useless parentheses. | 76 |
| UselessParentheses | Useless parentheses. | 78 |
MyCoRe ORCID Integration - org/mycore/orcid/oauth/MCRReadPublicTokenFactory.java
| Rule | Violation | Line |
|---|---|---|
| UselessParentheses | Useless parentheses. | 50 |
MyCoRe ORCID Integration - org/mycore/orcid/user/MCRORCIDSession.java
| Rule | Violation | Line |
|---|---|---|
| UselessParentheses | Useless parentheses. | 39 |
MyCoRe ORCID Integration - org/mycore/orcid/user/MCRORCIDUser.java
| Rule | Violation | Line |
|---|---|---|
| UselessParentheses | Useless parentheses. | 93 |
| UselessParentheses | Useless parentheses. | 93 |
MyCoRe ORCID Integration - org/mycore/orcid/works/MCRWorkSource.java
| Rule | Violation | Line |
|---|---|---|
| UselessParentheses | Useless parentheses. | 60 |
MyCoRe ORCID Integration - org/mycore/orcid/works/MCRWorksFetcher.java
| Rule | Violation | Line |
|---|---|---|
| UselessParentheses | Useless parentheses. | 166 |
MyCoRe Persistent Identifier - org/mycore/pi/frontend/MCRIdentifierXSLUtils.java
| Rule | Violation | Line |
|---|---|---|
| UselessParentheses | Useless parentheses. | 89–117 |
MyCoRe REST API - org/mycore/restapi/MCRSessionFilter.java
| Rule | Violation | Line |
|---|---|---|
| UselessParentheses | Useless parentheses. | 109–111 |
MyCoRe REST API - org/mycore/restapi/converter/MCRWrappedXMLWriter.java
| Rule | Violation | Line |
|---|---|---|
| UselessParentheses | Useless parentheses. | 81 |
| UselessParentheses | Useless parentheses. | 129 |
MyCoRe REST API - org/mycore/restapi/v1/utils/MCRRestAPIUtil.java
| Rule | Violation | Line |
|---|---|---|
| UselessParentheses | Useless parentheses. | 58 |
| UselessParentheses | Useless parentheses. | 58 |
| UselessParentheses | Useless parentheses. | 58 |
| UselessParentheses | Useless parentheses. | 58 |
MyCoRe REST API - org/mycore/restapi/v2/MCRExceptionMapper.java
| Rule | Violation | Line |
|---|---|---|
| UselessParentheses | Useless parentheses. | 49 |
| UselessParentheses | Useless parentheses. | 77 |
MyCoRe REST API - org/mycore/restapi/v2/MCRRestDerivateContents.java
| Rule | Violation | Line |
|---|---|---|
| UselessParentheses | Useless parentheses. | 487 |
| UselessParentheses | Useless parentheses. | 498 |
MyCoRe Solr Support - org/mycore/solr/index/handlers/MCRSolrOptimizeIndexHandler.java
| Rule | Violation | Line |
|---|---|---|
| UselessParentheses | Useless parentheses. | 41 |
MyCoRe Solr Support - org/mycore/solr/index/statistic/MCRSolrIndexStatistic.java
| Rule | Violation | Line |
|---|---|---|
| UselessParentheses | Useless parentheses. | 76 |
MyCoRe Solr Support - org/mycore/solr/schema/MCRSolrConfigReloader.java
| Rule | Violation | Line |
|---|---|---|
| UselessParentheses | Useless parentheses. | 311–312 |
| UselessParentheses | Useless parentheses. | 312 |
MyCoRe Solr Support - org/mycore/solr/search/MCRConditionTransformer.java
| Rule | Violation | Line |
|---|---|---|
| UselessParentheses | Useless parentheses. | 208 |
| UselessParentheses | Useless parentheses. | 211 |
| UselessParentheses | Useless parentheses. | 374 |
MyCoRe Solr Support - org/mycore/solr/search/MCRQLSearchUtils.java
| Rule | Violation | Line |
|---|---|---|
| UselessParentheses | Useless parentheses. | 186 |
MyCoRe Solr Support - org/mycore/solr/search/MCRSolrQueryAdapter.java
| Rule | Violation | Line |
|---|---|---|
| UselessParentheses | Useless parentheses. | 123 |
| UselessParentheses | Useless parentheses. | 123 |
| UselessParentheses | Useless parentheses. | 127 |
| UselessParentheses | Useless parentheses. | 127 |
MyCoRe New User System - org/mycore/user2/MCRUserAttributeMapper.java
| Rule | Violation | Line |
|---|---|---|
| UselessParentheses | Useless parentheses. | 157 |
MyCoRe New User System - org/mycore/user2/MCRUserManager.java
| Rule | Violation | Line |
|---|---|---|
| UselessParentheses | Useless parentheses. | 684 |
MyCoRe New User System - org/mycore/user2/MCRUserServlet.java
| Rule | Violation | Line |
|---|---|---|
| UselessParentheses | Useless parentheses. | 91 |
| UselessParentheses | Useless parentheses. | 91 |
| UselessParentheses | Useless parentheses. | 207 |
| UselessParentheses | Useless parentheses. | 207 |
| UselessParentheses | Useless parentheses. | 273 |
| UselessParentheses | Useless parentheses. | 273 |
| UselessParentheses | Useless parentheses. | 287 |
| UselessParentheses | Useless parentheses. | 287 |
| UselessParentheses | Useless parentheses. | 368 |
| UselessParentheses | Useless parentheses. | 368 |
| UselessParentheses | Useless parentheses. | 374 |
| UselessParentheses | Useless parentheses. | 374 |
| UselessParentheses | Useless parentheses. | 473 |
| UselessParentheses | Useless parentheses. | 487 |
| UselessParentheses | Useless parentheses. | 487 |
| UselessParentheses | Useless parentheses. | 510 |
| UselessParentheses | Useless parentheses. | 510 |
MyCoRe New User System - org/mycore/user2/login/MCRCASServlet.java
| Rule | Violation | Line |
|---|---|---|
| UselessParentheses | Useless parentheses. | 102 |
| UselessParentheses | Useless parentheses. | 102 |
MyCoRe New User System - org/mycore/user2/login/MCRLDAPClient.java
| Rule | Violation | Line |
|---|---|---|
| UselessParentheses | Useless parentheses. | 147 |
| UselessParentheses | Useless parentheses. | 147 |
| UselessParentheses | Useless parentheses. | 147 |
| UselessParentheses | Useless parentheses. | 174 |
| UselessParentheses | Useless parentheses. | 180 |
| UselessParentheses | Useless parentheses. | 187 |
| UselessParentheses | Useless parentheses. | 187 |
| UselessParentheses | Useless parentheses. | 187 |
MyCoRe New User System - org/mycore/user2/login/MCRLoginServlet.java
| Rule | Violation | Line |
|---|---|---|
| UselessParentheses | Useless parentheses. | 149 |
| UnnecessaryFullyQualifiedName | Unnecessary use of fully qualified name 'org.mycore.frontend.support.MCRLogin.InputField' due to existing import 'org.mycore.frontend.support.MCRLogin.InputField' | 221 |
| UselessParentheses | Useless parentheses. | 241 |
| UselessParentheses | Useless parentheses. | 252 |
| UselessParentheses | Useless parentheses. | 289 |
| UselessParentheses | Useless parentheses. | 289 |
MyCoRe New User System - org/mycore/user2/package-info.java
| Rule | Violation | Line |
|---|---|---|
| UnnecessaryFullyQualifiedName | Unnecessary use of fully qualified name 'org.mycore.user2.utils.MCRDateXMLAdapter' due to existing same package import 'org.mycore.user2.*' | 21 |
MyCoRe WCMS 2 - org/mycore/wcms2/navigation/MCRWCMSContentManager.java
| Rule | Violation | Line |
|---|---|---|
| UselessParentheses | Useless parentheses. | 175–176 |
MyCoRe Workflow Components - org/mycore/wfc/actionmapping/MCRCategoryCondition.java
| Rule | Violation | Line |
|---|---|---|
| UselessParentheses | Useless parentheses. | 77 |
MyCoRe XEditor - org/mycore/frontend/xeditor/MCREditorSession.java
| Rule | Violation | Line |
|---|---|---|
| UselessParentheses | Useless parentheses. | 197 |
MyCoRe XEditor - org/mycore/frontend/xeditor/MCREditorSubmission.java
| Rule | Violation | Line |
|---|---|---|
| UselessParentheses | Useless parentheses. | 106 |
| UselessParentheses | Useless parentheses. | 106 |
MyCoRe XEditor - org/mycore/frontend/xeditor/MCRIncludeHandler.java
| Rule | Violation | Line |
|---|---|---|
| UselessParentheses | Useless parentheses. | 121 |
| UselessParentheses | Useless parentheses. | 217 |
MyCoRe XEditor - org/mycore/frontend/xeditor/MCRXEditorTransformer.java
| Rule | Violation | Line |
|---|---|---|
| UselessParentheses | Useless parentheses. | 133–135 |
| UselessParentheses | Useless parentheses. | 291 |
| UselessParentheses | Useless parentheses. | 330 |
| UselessParentheses | Useless parentheses. | 369 |
MyCoRe XEditor - org/mycore/frontend/xeditor/MCRXMLCleaner.java
| Rule | Violation | Line |
|---|---|---|
| UselessParentheses | Useless parentheses. | 108 |
MyCoRe XEditor - org/mycore/frontend/xeditor/target/MCRLayoutServiceTarget.java
| Rule | Violation | Line |
|---|---|---|
| UselessParentheses | Useless parentheses. | 47 |
| UselessParentheses | Useless parentheses. | 47 |
MyCoRe XEditor - org/mycore/frontend/xeditor/target/MCRSubselectReturnTarget.java
| Rule | Violation | Line |
|---|---|---|
| UselessParentheses | Useless parentheses. | 68 |
MyCoRe XEditor - org/mycore/frontend/xeditor/validation/MCRDateValidator.java
| Rule | Violation | Line |
|---|---|---|
| UselessParentheses | Useless parentheses. | 51 |
MyCoRe XEditor - org/mycore/frontend/xeditor/validation/MCRDecimalConverter.java
| Rule | Violation | Line |
|---|---|---|
| UselessParentheses | Useless parentheses. | 52 |
| UselessParentheses | Useless parentheses. | 67 |
MyCoRe XEditor - org/mycore/frontend/xeditor/validation/MCRValidator.java
| Rule | Violation | Line |
|---|---|---|
| UselessParentheses | Useless parentheses. | 69 |
Files
MyCoRe ACL - org/mycore/mcr/acl/accesskey/MCRAccessKeyManager.java
| Rule | Violation | Priority | Line |
|---|---|---|---|
| UselessParentheses | Useless parentheses. | 4 | 89 |
MyCoRe ACL - org/mycore/mcr/acl/accesskey/MCRAccessKeyUtils.java
| Rule | Violation | Priority | Line |
|---|---|---|---|
| EmptyCatchBlock | Avoid empty catch blocks | 3 | 136–138 |
| EmptyCatchBlock | Avoid empty catch blocks | 3 | 144–146 |
| EmptyCatchBlock | Avoid empty catch blocks | 3 | 198–200 |
| EmptyCatchBlock | Avoid empty catch blocks | 3 | 206–208 |
MyCoRe ACL - org/mycore/mcr/acl/accesskey/model/MCRAccessKey.java
| Rule | Violation | Priority | Line |
|---|---|---|---|
| OverrideBothEqualsAndHashcode | Ensure you override both equals() and hashCode() | 3 | 301 |
MyCoRe ACL - org/mycore/mcr/acl/accesskey/restapi/v2/MCRRestAccessKeyExceptionMapper.java
| Rule | Violation | Priority | Line |
|---|---|---|---|
| UselessParentheses | Useless parentheses. | 4 | 59 |
MyCoRe ACL - org/mycore/mcr/acl/accesskey/restapi/v2/MCRRestDerivateAccessKeys.java
| Rule | Violation | Priority | Line |
|---|---|---|---|
| TooManyStaticImports | Too many static imports may lead to messy code | 3 | 19–190 |
MyCoRe ACL - org/mycore/mcr/acl/accesskey/strategy/MCRAccessKeyStrategyHelper.java
| Rule | Violation | Priority | Line |
|---|---|---|---|
| UselessParentheses | Useless parentheses. | 4 | 67–68 |
MyCoRe Base Components - org/mycore/access/mcrimpl/MCRGroupClause.java
| Rule | Violation | Priority | Line |
|---|---|---|---|
| UselessParentheses | Useless parentheses. | 4 | 62 |
MyCoRe Base Components - org/mycore/access/mcrimpl/MCRRuleParser.java
| Rule | Violation | Priority | Line |
|---|---|---|---|
| UnnecessaryFullyQualifiedName | Unnecessary use of fully qualified name 'java.text.ParseException' due to existing import 'java.text.ParseException' | 4 | 43 |
MyCoRe Base Components - org/mycore/access/mcrimpl/MCRUserClause.java
| Rule | Violation | Priority | Line |
|---|---|---|---|
| UselessParentheses | Useless parentheses. | 4 | 85 |
MyCoRe Base Components - org/mycore/backend/jpa/access/MCRJPAAccessStore.java
| Rule | Violation | Priority | Line |
|---|---|---|---|
| EmptyCatchBlock | Avoid empty catch blocks | 3 | 181–183 |
MyCoRe Base Components - org/mycore/common/MCRCalendar.java
| Rule | Violation | Priority | Line |
|---|---|---|---|
| UselessParentheses | Useless parentheses. | 4 | 283 |
| UselessParentheses | Useless parentheses. | 4 | 286 |
| UselessParentheses | Useless parentheses. | 4 | 286 |
| UselessParentheses | Useless parentheses. | 4 | 288 |
| UselessParentheses | Useless parentheses. | 4 | 288 |
| UselessParentheses | Useless parentheses. | 4 | 808 |
| UselessParentheses | Useless parentheses. | 4 | 855 |
MyCoRe Base Components - org/mycore/common/MCRConstants.java
| Rule | Violation | Priority | Line |
|---|---|---|---|
| UselessParentheses | Useless parentheses. | 4 | 157 |
MyCoRe Base Components - org/mycore/common/MCRExceptionCauseFinder.java
| Rule | Violation | Priority | Line |
|---|---|---|---|
| UselessParentheses | Useless parentheses. | 4 | 36 |
| UselessParentheses | Useless parentheses. | 4 | 41 |
MyCoRe Base Components - org/mycore/common/MCRGeoUtilities.java
| Rule | Violation | Priority | Line |
|---|---|---|---|
| UselessParentheses | Useless parentheses. | 4 | 35 |
| UselessParentheses | Useless parentheses. | 4 | 35 |
| UselessParentheses | Useless parentheses. | 4 | 44 |
| UselessParentheses | Useless parentheses. | 4 | 61 |
| UselessParentheses | Useless parentheses. | 4 | 61 |
| UselessParentheses | Useless parentheses. | 4 | 84 |
MyCoRe Base Components - org/mycore/common/MCRMailer.java
| Rule | Violation | Priority | Line |
|---|---|---|---|
| UselessParentheses | Useless parentheses. | 4 | 395 |
| UnnecessaryFullyQualifiedName | Unnecessary use of fully qualified name 'jakarta.mail.Authenticator' due to existing import 'jakarta.mail.Authenticator' | 4 | 778 |
MyCoRe Base Components - org/mycore/common/MCRSessionMgr.java
| Rule | Violation | Priority | Line |
|---|---|---|---|
| UnusedPrivateMethod | Avoid unused private methods such as 'checkSessionLock()'. | 3 | 91 |
MyCoRe Base Components - org/mycore/common/config/MCRConfigurationDir.java
| Rule | Violation | Priority | Line |
|---|---|---|---|
| EmptyCatchBlock | Avoid empty catch blocks | 3 | 238–240 |
MyCoRe Base Components - org/mycore/common/content/MCRPathContent.java
| Rule | Violation | Priority | Line |
|---|---|---|---|
| UnusedPrivateField | Avoid unused private fields such as 'LOGGER'. | 3 | 47 |
| UnusedPrivateField | Avoid unused private fields such as 'BUFFER_SIZE'. | 3 | 53 |
MyCoRe Base Components - org/mycore/common/content/transformer/MCRToPrettyXML.java
| Rule | Violation | Priority | Line |
|---|---|---|---|
| UselessParentheses | Useless parentheses. | 4 | 41 |
MyCoRe Base Components - org/mycore/common/content/transformer/MCRXSLTransformer.java
| Rule | Violation | Priority | Line |
|---|---|---|---|
| UselessParentheses | Useless parentheses. | 4 | 367 |
| UnusedFormalParameter | Avoid unused method parameters such as 'content'. | 3 | 387 |
| EmptyCatchBlock | Avoid empty catch blocks | 3 | 423–425 |
MyCoRe Base Components - org/mycore/common/content/util/MCRRestContentHelper.java
| Rule | Violation | Priority | Line |
|---|---|---|---|
| EmptyCatchBlock | Avoid empty catch blocks | 3 | 173–175 |
MyCoRe Base Components - org/mycore/common/content/util/MCRServletContentHelper.java
| Rule | Violation | Priority | Line |
|---|---|---|---|
| EmptyCatchBlock | Avoid empty catch blocks | 3 | 174–176 |
| CollapsibleIfStatements | These nested if statements could be combined | 3 | 267–285 |
| CollapsibleIfStatements | These nested if statements could be combined | 3 | 303–308 |
| CollapsibleIfStatements | These nested if statements could be combined | 3 | 365–369 |
| EmptyCatchBlock | Avoid empty catch blocks | 3 | 426–428 |
MyCoRe Base Components - org/mycore/common/events/MCRServletContainerInitializer.java
| Rule | Violation | Priority | Line |
|---|---|---|---|
| UselessParentheses | Useless parentheses. | 4 | 95 |
MyCoRe Base Components - org/mycore/common/xml/MCRAttributeValueFilter.java
| Rule | Violation | Priority | Line |
|---|---|---|---|
| UselessParentheses | Useless parentheses. | 4 | 49 |
MyCoRe Base Components - org/mycore/common/xml/MCRLayoutService.java
| Rule | Violation | Priority | Line |
|---|---|---|---|
| UnusedFormalParameter | Avoid unused method parameters such as 'filename'. | 3 | 230 |
MyCoRe Base Components - org/mycore/common/xml/MCRNodeBuilder.java
| Rule | Violation | Priority | Line |
|---|---|---|---|
| UselessParentheses | Useless parentheses. | 4 | 203 |
| UselessParentheses | Useless parentheses. | 4 | 203 |
| UselessParentheses | Useless parentheses. | 4 | 205 |
| UselessParentheses | Useless parentheses. | 4 | 205 |
| UselessParentheses | Useless parentheses. | 4 | 252 |
| UselessParentheses | Useless parentheses. | 4 | 252 |
| UselessParentheses | Useless parentheses. | 4 | 262 |
MyCoRe Base Components - org/mycore/common/xml/MCRURIResolver.java
| Rule | Violation | Priority | Line |
|---|---|---|---|
| UnnecessaryFullyQualifiedName | Unnecessary use of fully qualified name 'org.apache.logging.log4j.Logger' due to existing import 'org.apache.logging.log4j.Logger' | 4 | 451 |
| EmptyCatchBlock | Avoid empty catch blocks | 3 | 795–797 |
MyCoRe Base Components - org/mycore/common/xml/MCRXPathBuilder.java
| Rule | Violation | Priority | Line |
|---|---|---|---|
| UselessParentheses | Useless parentheses. | 4 | 85 |
| UselessParentheses | Useless parentheses. | 4 | 85 |
| UselessParentheses | Useless parentheses. | 4 | 111 |
| UselessParentheses | Useless parentheses. | 4 | 120 |
| UselessParentheses | Useless parentheses. | 4 | 120 |
MyCoRe Base Components - org/mycore/common/xsl/MCRParameterCollector.java
| Rule | Violation | Priority | Line |
|---|---|---|---|
| UselessParentheses | Useless parentheses. | 4 | 168 |
| OverrideBothEqualsAndHashcode | Ensure you override both equals() and hashCode() | 3 | 357 |
MyCoRe Base Components - org/mycore/crypt/MCRAESCipher.java
| Rule | Violation | Priority | Line |
|---|---|---|---|
| UselessParentheses | Useless parentheses. | 4 | 96 |
MyCoRe Base Components - org/mycore/datamodel/classifications2/impl/MCRCategLinkServiceImpl.java
| Rule | Violation | Priority | Line |
|---|---|---|---|
| UnnecessaryFullyQualifiedName | Unnecessary use of fully qualified name 'jakarta.persistence.Query' due to existing import 'jakarta.persistence.Query' | 4 | 157 |
MyCoRe Base Components - org/mycore/datamodel/classifications2/impl/MCRCategoryDAOImpl.java
| Rule | Violation | Priority | Line |
|---|---|---|---|
| EmptyCatchBlock | Avoid empty catch blocks | 3 | 144–147 |
MyCoRe Base Components - org/mycore/datamodel/common/MCRDataURL.java
| Rule | Violation | Priority | Line |
|---|---|---|---|
| CollapsibleIfStatements | These nested if statements could be combined | 3 | 183–189 |
| UnusedFormalParameter | Avoid unused constructor parameters such as 'mimeType'. | 3 | 419 |
MyCoRe Base Components - org/mycore/datamodel/common/MCRDefaultXMLMetadataManager.java
| Rule | Violation | Priority | Line |
|---|---|---|---|
| UselessParentheses | Useless parentheses. | 4 | 180 |
MyCoRe Base Components - org/mycore/datamodel/common/MCRISO8601Date.java
| Rule | Violation | Priority | Line |
|---|---|---|---|
| OverrideBothEqualsAndHashcode | Ensure you override both equals() and hashCode() | 3 | 282 |
MyCoRe Base Components - org/mycore/datamodel/common/MCRMarkManager.java
| Rule | Violation | Priority | Line |
|---|---|---|---|
| DoubleCheckedLocking | Double checked locking is not thread safe in Java. | 1 | 94–104 |
MyCoRe Base Components - org/mycore/datamodel/ifs2/MCRFileCollection.java
| Rule | Violation | Priority | Line |
|---|---|---|---|
| EmptyCatchBlock | Avoid empty catch blocks | 3 | 143–145 |
MyCoRe Base Components - org/mycore/datamodel/ifs2/MCRStore.java
| Rule | Violation | Priority | Line |
|---|---|---|---|
| EmptyCatchBlock | Avoid empty catch blocks | 3 | 487–489 |
MyCoRe Base Components - org/mycore/datamodel/ifs2/MCRVersioningMetadataStore.java
| Rule | Violation | Priority | Line |
|---|---|---|---|
| UselessParentheses | Useless parentheses. | 4 | 103 |
MyCoRe Base Components - org/mycore/datamodel/ifs/MCRFileNodeServlet.java
| Rule | Violation | Priority | Line |
|---|---|---|---|
| UnusedFormalParameter | Avoid unused method parameters such as 'request'. | 3 | 160 |
| UnusedFormalParameter | Avoid unused method parameters such as 'response'. | 3 | 160 |
MyCoRe Base Components - org/mycore/datamodel/language/MCRLanguageFactory.java
| Rule | Violation | Priority | Line |
|---|---|---|---|
| UselessParentheses | Useless parentheses. | 4 | 119 |
| UselessParentheses | Useless parentheses. | 4 | 162 |
| UselessParentheses | Useless parentheses. | 4 | 163 |
| UnusedLocalVariable | Avoid unused local variables such as 'session'. | 3 | 232 |
MyCoRe Base Components - org/mycore/datamodel/language/MCRLanguageXML.java
| Rule | Violation | Priority | Line |
|---|---|---|---|
| UselessParentheses | Useless parentheses. | 4 | 54 |
| UselessParentheses | Useless parentheses. | 4 | 58 |
MyCoRe Base Components - org/mycore/datamodel/metadata/MCRMetaAddress.java
| Rule | Violation | Priority | Line |
|---|---|---|---|
| OverrideBothEqualsAndHashcode | Ensure you override both equals() and hashCode() | 3 | 216 |
MyCoRe Base Components - org/mycore/datamodel/metadata/MCRMetaBoolean.java
| Rule | Violation | Priority | Line |
|---|---|---|---|
| UnusedFormalParameter | Avoid unused constructor parameters such as 'lang'. | 3 | 74 |
| OverrideBothEqualsAndHashcode | Ensure you override both equals() and hashCode() | 3 | 233 |
MyCoRe Base Components - org/mycore/datamodel/metadata/MCRMetaClassification.java
| Rule | Violation | Priority | Line |
|---|---|---|---|
| OverrideBothEqualsAndHashcode | Ensure you override both equals() and hashCode() | 3 | 242 |
MyCoRe Base Components - org/mycore/datamodel/metadata/MCRMetaDateLangText.java
| Rule | Violation | Priority | Line |
|---|---|---|---|
| OverrideBothEqualsAndHashcode | Ensure you override both equals() and hashCode() | 3 | 195 |
MyCoRe Base Components - org/mycore/datamodel/metadata/MCRMetaElement.java
| Rule | Violation | Priority | Line |
|---|---|---|---|
| UselessParentheses | Useless parentheses. | 4 | 129 |
| UselessParentheses | Useless parentheses. | 4 | 129 |
| UselessParentheses | Useless parentheses. | 4 | 252 |
| UselessParentheses | Useless parentheses. | 4 | 252 |
| UselessParentheses | Useless parentheses. | 4 | 355 |
| UselessParentheses | Useless parentheses. | 4 | 386 |
| UselessParentheses | Useless parentheses. | 4 | 456 |
MyCoRe Base Components - org/mycore/datamodel/metadata/MCRMetaEnrichedLinkID.java
| Rule | Violation | Priority | Line |
|---|---|---|---|
| UselessParentheses | Useless parentheses. | 4 | 181–182 |
MyCoRe Base Components - org/mycore/datamodel/metadata/MCRMetaHistoryDate.java
| Rule | Violation | Priority | Line |
|---|---|---|---|
| UselessParentheses | Useless parentheses. | 4 | 229 |
| OverrideBothEqualsAndHashcode | Ensure you override both equals() and hashCode() | 3 | 534 |
| EmptyCatchBlock | Avoid empty catch blocks | 3 | 667–669 |
MyCoRe Base Components - org/mycore/datamodel/metadata/MCRMetaIFS.java
| Rule | Violation | Priority | Line |
|---|---|---|---|
| OverrideBothEqualsAndHashcode | Ensure you override both equals() and hashCode() | 3 | 230 |
MyCoRe Base Components - org/mycore/datamodel/metadata/MCRMetaISO8601Date.java
| Rule | Violation | Priority | Line |
|---|---|---|---|
| OverrideBothEqualsAndHashcode | Ensure you override both equals() and hashCode() | 3 | 256 |
MyCoRe Base Components - org/mycore/datamodel/metadata/MCRMetaInstitutionName.java
| Rule | Violation | Priority | Line |
|---|---|---|---|
| OverrideBothEqualsAndHashcode | Ensure you override both equals() and hashCode() | 3 | 249 |
MyCoRe Base Components - org/mycore/datamodel/metadata/MCRMetaLangText.java
| Rule | Violation | Priority | Line |
|---|---|---|---|
| OverrideBothEqualsAndHashcode | Ensure you override both equals() and hashCode() | 3 | 285 |
MyCoRe Base Components - org/mycore/datamodel/metadata/MCRMetaLink.java
| Rule | Violation | Priority | Line |
|---|---|---|---|
| CollapsibleIfStatements | These nested if statements could be combined | 3 | 238–240 |
| CollapsibleIfStatements | These nested if statements could be combined | 3 | 408–410 |
| CollapsibleIfStatements | These nested if statements could be combined | 3 | 432–434 |
MyCoRe Base Components - org/mycore/datamodel/metadata/MCRMetaLinkID.java
| Rule | Violation | Priority | Line |
|---|---|---|---|
| OverrideBothEqualsAndHashcode | Ensure you override both equals() and hashCode() | 3 | 241 |
MyCoRe Base Components - org/mycore/datamodel/metadata/MCRMetaNumber.java
| Rule | Violation | Priority | Line |
|---|---|---|---|
| BigIntegerInstantiation | Dont create instances of already existing BigInteger and BigDecimal (ZERO, ONE, TEN) | 3 | 105 |
| OverrideBothEqualsAndHashcode | Ensure you override both equals() and hashCode() | 3 | 351 |
MyCoRe Base Components - org/mycore/datamodel/metadata/MCRMetaPersonName.java
| Rule | Violation | Priority | Line |
|---|---|---|---|
| OverrideBothEqualsAndHashcode | Ensure you override both equals() and hashCode() | 3 | 444 |
MyCoRe Base Components - org/mycore/datamodel/metadata/MCRMetaXML.java
| Rule | Violation | Priority | Line |
|---|---|---|---|
| OverrideBothEqualsAndHashcode | Ensure you override both equals() and hashCode() | 3 | 185 |
MyCoRe Base Components - org/mycore/datamodel/metadata/MCRMetadataManager.java
| Rule | Violation | Priority | Line |
|---|---|---|---|
| UselessParentheses | Useless parentheses. | 4 | 854 |
MyCoRe Base Components - org/mycore/datamodel/metadata/MCRObjectDerivate.java
| Rule | Violation | Priority | Line |
|---|---|---|---|
| UselessParentheses | Useless parentheses. | 4 | 195 |
| UselessParentheses | Useless parentheses. | 4 | 195 |
| UselessParentheses | Useless parentheses. | 4 | 217 |
| UselessParentheses | Useless parentheses. | 4 | 217 |
| UselessParentheses | Useless parentheses. | 4 | 459 |
| UselessParentheses | Useless parentheses. | 4 | 459 |
MyCoRe Base Components - org/mycore/datamodel/metadata/MCRObjectID.java
| Rule | Violation | Priority | Line |
|---|---|---|---|
| UselessParentheses | Useless parentheses. | 4 | 403 |
MyCoRe Base Components - org/mycore/datamodel/metadata/validator/MCREditorOutValidator.java
| Rule | Violation | Priority | Line |
|---|---|---|---|
| BrokenNullCheck | Method call on object which may be null | 2 | 205–208 |
MyCoRe Base Components - org/mycore/datamodel/niofs/MCRPath.java
| Rule | Violation | Priority | Line |
|---|---|---|---|
| UselessParentheses | Useless parentheses. | 4 | 319 |
| UselessParentheses | Useless parentheses. | 4 | 523 |
MyCoRe Base Components - org/mycore/datamodel/niofs/MCRPathUtils.java
| Rule | Violation | Priority | Line |
|---|---|---|---|
| EmptyCatchBlock | Avoid empty catch blocks | 3 | 64–66 |
MyCoRe Base Components - org/mycore/datamodel/niofs/MCRPathXML.java
| Rule | Violation | Priority | Line |
|---|---|---|---|
| UselessParentheses | Useless parentheses. | 4 | 79 |
MyCoRe Base Components - org/mycore/datamodel/niofs/MCRPaths.java
| Rule | Violation | Priority | Line |
|---|---|---|---|
| UselessParentheses | Useless parentheses. | 4 | 60 |
MyCoRe Base Components - org/mycore/datamodel/niofs/utils/MCRTreeCopier.java
| Rule | Violation | Priority | Line |
|---|---|---|---|
| EmptyCatchBlock | Avoid empty catch blocks | 3 | 78–81 |
MyCoRe Base Components - org/mycore/frontend/MCRFrontendUtil.java
| Rule | Violation | Priority | Line |
|---|---|---|---|
| AvoidUsingHardCodedIP | Do not hard code the IP address | 3 | 72 |
| AvoidUsingHardCodedIP | Do not hard code the IP address | 3 | 75 |
| UselessParentheses | Useless parentheses. | 4 | 265 |
| UselessParentheses | Useless parentheses. | 4 | 268 |
MyCoRe Base Components - org/mycore/frontend/MCRLayoutUtilities.java
| Rule | Violation | Priority | Line |
|---|---|---|---|
| UselessParentheses | Useless parentheses. | 4 | 512 |
MyCoRe Base Components - org/mycore/frontend/basket/MCRBasket.java
| Rule | Violation | Priority | Line |
|---|---|---|---|
| UselessParentheses | Useless parentheses. | 4 | 208 |
| UselessParentheses | Useless parentheses. | 4 | 256 |
| UselessParentheses | Useless parentheses. | 4 | 256 |
MyCoRe Base Components - org/mycore/frontend/basket/MCRBasketEntry.java
| Rule | Violation | Priority | Line |
|---|---|---|---|
| UselessParentheses | Useless parentheses. | 4 | 78 |
MyCoRe Base Components - org/mycore/frontend/basket/MCRBasketManager.java
| Rule | Violation | Priority | Line |
|---|---|---|---|
| UselessParentheses | Useless parentheses. | 4 | 80 |
MyCoRe Base Components - org/mycore/frontend/cli/MCRBatchEditorCommands.java
| Rule | Violation | Priority | Line |
|---|---|---|---|
| CollapsibleIfStatements | These nested if statements could be combined | 3 | 140–142 |
MyCoRe Base Components - org/mycore/frontend/cli/MCRCommandLineInterface.java
| Rule | Violation | Priority | Line |
|---|---|---|---|
| AvoidUsingHardCodedIP | Do not hard code the IP address | 3 | 175 |
| UnusedFormalParameter | Avoid unused method parameters such as 'session'. | 3 | 233 |
MyCoRe Base Components - org/mycore/frontend/cli/MCRDeveloperCommands.java
| Rule | Violation | Priority | Line |
|---|---|---|---|
| UselessParentheses | Useless parentheses. | 4 | 55 |
MyCoRe Base Components - org/mycore/frontend/export/MCRExportCollection.java
| Rule | Violation | Priority | Line |
|---|---|---|---|
| UselessParentheses | Useless parentheses. | 4 | 54 |
| UselessParentheses | Useless parentheses. | 4 | 54 |
MyCoRe Base Components - org/mycore/frontend/export/MCRExportServlet.java
| Rule | Violation | Priority | Line |
|---|---|---|---|
| UselessParentheses | Useless parentheses. | 4 | 120 |
MyCoRe Base Components - org/mycore/frontend/fileupload/MCRUploadHandlerIFS.java
| Rule | Violation | Priority | Line |
|---|---|---|---|
| UselessParentheses | Useless parentheses. | 4 | 302–303 |
| UselessParentheses | Useless parentheses. | 4 | 302 |
| UselessParentheses | Useless parentheses. | 4 | 302–303 |
| UselessParentheses | Useless parentheses. | 4 | 304 |
MyCoRe Base Components - org/mycore/frontend/fileupload/MCRUploadViaFormServlet.java
| Rule | Violation | Priority | Line |
|---|---|---|---|
| UnusedLocalVariable | Avoid unused local variables such as 'session'. | 3 | 97 |
MyCoRe Base Components - org/mycore/frontend/filter/MCRSecureTokenV2Filter.java
| Rule | Violation | Priority | Line |
|---|---|---|---|
| CollapsibleIfStatements | These nested if statements could be combined | 3 | 85–89 |
MyCoRe Base Components - org/mycore/frontend/jersey/filter/MCRDBTransactionFilter.java
| Rule | Violation | Priority | Line |
|---|---|---|---|
| UnusedLocalVariable | Avoid unused local variables such as 'session'. | 3 | 34 |
MyCoRe Base Components - org/mycore/frontend/jersey/resources/MCRLocaleResource.java
| Rule | Violation | Priority | Line |
|---|---|---|---|
| UselessParentheses | Useless parentheses. | 4 | 54 |
MyCoRe Base Components - org/mycore/frontend/servlets/MCRDerivateServlet.java
| Rule | Violation | Priority | Line |
|---|---|---|---|
| UselessParentheses | Useless parentheses. | 4 | 62 |
MyCoRe Base Components - org/mycore/frontend/servlets/MCRDisplayHideDerivateServlet.java
| Rule | Violation | Priority | Line |
|---|---|---|---|
| UselessParentheses | Useless parentheses. | 4 | 48 |
MyCoRe Base Components - org/mycore/frontend/servlets/MCRObjectServlet.java
| Rule | Violation | Priority | Line |
|---|---|---|---|
| UnusedPrivateField | Avoid unused private fields such as 'REV_CURRENT'. | 3 | 50 |
MyCoRe Base Components - org/mycore/frontend/servlets/MCRServlet.java
| Rule | Violation | Priority | Line |
|---|---|---|---|
| UnusedFormalParameter | Avoid unused method parameters such as 'context'. | 3 | 122 |
| UnusedLocalVariable | Avoid unused local variables such as 'session'. | 3 | 299 |
| UnusedLocalVariable | Avoid unused local variables such as 'session'. | 3 | 410 |
| UnusedLocalVariable | Avoid unused local variables such as 'session'. | 3 | 449 |
MyCoRe Base Components - org/mycore/frontend/servlets/MCRServletJob.java
| Rule | Violation | Priority | Line |
|---|---|---|---|
| AvoidUsingHardCodedIP | Do not hard code the IP address | 3 | 75 |
MyCoRe Base Components - org/mycore/frontend/servlets/MCRStaticXMLFileServlet.java
| Rule | Violation | Priority | Line |
|---|---|---|---|
| UnnecessaryFullyQualifiedName | Unnecessary use of fully qualified name 'java.io.IOException' due to existing import 'java.io.IOException' | 4 | 58 |
MyCoRe Base Components - org/mycore/parsers/bool/MCRBooleanClauseParser.java
| Rule | Violation | Priority | Line |
|---|---|---|---|
| UselessParentheses | Useless parentheses. | 4 | 232 |
| UselessParentheses | Useless parentheses. | 4 | 232 |
MyCoRe Base Components - org/mycore/services/i18n/MCRTranslation.java
| Rule | Violation | Priority | Line |
|---|---|---|---|
| UnnecessaryFullyQualifiedName | Unnecessary use of fully qualified name 'java.util.MissingResourceException' due to existing import 'java.util.MissingResourceException' | 4 | 173 |
| EmptyCatchBlock | Avoid empty catch blocks | 3 | 173–174 |
MyCoRe Base Components - org/mycore/services/packaging/MCRPackerServlet.java
| Rule | Violation | Priority | Line |
|---|---|---|---|
| UselessParentheses | Useless parentheses. | 4 | 83 |
MyCoRe Base Components - org/mycore/services/queuedjob/MCRJobMaster.java
| Rule | Violation | Priority | Line |
|---|---|---|---|
| AvoidThreadGroup | Avoid using java.lang.ThreadGroup; it is not thread safe | 3 | 156 |
| UselessParentheses | Useless parentheses. | 4 | 326 |
MyCoRe Base Components - org/mycore/services/queuedjob/MCRJobQueue.java
| Rule | Violation | Priority | Line |
|---|---|---|---|
| UselessParentheses | Useless parentheses. | 4 | 208 |
| UselessParentheses | Useless parentheses. | 4 | 208 |
MyCoRe Base Components - org/mycore/tools/MCRTopologicalSort.java
| Rule | Violation | Priority | Line |
|---|---|---|---|
| CollapsibleIfStatements | These nested if statements could be combined | 3 | 306–309 |
MyCoRe Classification Browser - org/mycore/frontend/servlets/MCRClassificationBrowser2.java
| Rule | Violation | Priority | Line |
|---|---|---|---|
| UselessParentheses | Useless parentheses. | 4 | 116 |
| UselessParentheses | Useless parentheses. | 4 | 116 |
| UselessParentheses | Useless parentheses. | 4 | 145 |
| UselessParentheses | Useless parentheses. | 4 | 177 |
| UselessParentheses | Useless parentheses. | 4 | 199 |
| UselessParentheses | Useless parentheses. | 4 | 201 |
| UselessParentheses | Useless parentheses. | 4 | 201 |
MyCoRe Classification Editor - org/mycore/frontend/classeditor/MCRCategoryListTypeAdapter.java
| Rule | Violation | Priority | Line |
|---|---|---|---|
| TooManyStaticImports | Too many static imports may lead to messy code | 3 | 19–106 |
MyCoRe Classification Editor - org/mycore/frontend/classeditor/MCRCategoryTypeAdapter.java
| Rule | Violation | Priority | Line |
|---|---|---|---|
| TooManyStaticImports | Too many static imports may lead to messy code | 3 | 19–129 |
MyCoRe FO - org/mycore/component/fo/common/fo/MCRFoFormatterFOP.java
| Rule | Violation | Priority | Line |
|---|---|---|---|
| UselessParentheses | Useless parentheses. | 4 | 124 |
| UselessParentheses | Useless parentheses. | 4 | 124 |
| EmptyCatchBlock | Avoid empty catch blocks | 3 | 127–128 |
MyCoRe IFS - org/mycore/datamodel/niofs/ifs2/MCRDirectoryStreamHelper.java
| Rule | Violation | Priority | Line |
|---|---|---|---|
| UselessParentheses | Useless parentheses. | 4 | 66 |
MyCoRe IFS - org/mycore/datamodel/niofs/ifs2/MCRFileSystemUtils.java
| Rule | Violation | Priority | Line |
|---|---|---|---|
| DoubleCheckedLocking | Double checked locking is not thread safe in Java. | 1 | 86–102 |
MyCoRe IIIF - org/mycore/iiif/image/impl/MCRIIIFImageImpl.java
| Rule | Violation | Priority | Line |
|---|---|---|---|
| UselessParentheses | Useless parentheses. | 4 | 51 |
MyCoRe IIIF - org/mycore/iiif/image/model/MCRIIIFImageSourceRegion.java
| Rule | Violation | Priority | Line |
|---|---|---|---|
| OverrideBothEqualsAndHashcode | Ensure you override both equals() and hashCode() | 3 | 54 |
| UselessParentheses | Useless parentheses. | 4 | 55 |
MyCoRe IIIF - org/mycore/iiif/image/model/MCRIIIFImageTargetRotation.java
| Rule | Violation | Priority | Line |
|---|---|---|---|
| OverrideBothEqualsAndHashcode | Ensure you override both equals() and hashCode() | 3 | 46 |
MyCoRe IIIF - org/mycore/iiif/image/model/MCRIIIFImageTargetSize.java
| Rule | Violation | Priority | Line |
|---|---|---|---|
| OverrideBothEqualsAndHashcode | Ensure you override both equals() and hashCode() | 3 | 43 |
MyCoRe IIIF - org/mycore/iiif/image/resources/MCRIIIFImageResource.java
| Rule | Violation | Priority | Line |
|---|---|---|---|
| TooManyStaticImports | Too many static imports may lead to messy code | 3 | 19–215 |
MyCoRe IIIF - org/mycore/iiif/presentation/impl/MCRIIIFPresentationImpl.java
| Rule | Violation | Priority | Line |
|---|---|---|---|
| UselessParentheses | Useless parentheses. | 4 | 44 |
MyCoRe Sitemap Protocol support - org/mycore/frontend/indexbrowser/MCRGoogleSitemapCommon.java
| Rule | Violation | Priority | Line |
|---|---|---|---|
| UselessParentheses | Useless parentheses. | 4 | 139 |
| UselessParentheses | Useless parentheses. | 4 | 139 |
| UselessParentheses | Useless parentheses. | 4 | 275 |
| UselessParentheses | Useless parentheses. | 4 | 275 |
| UselessParentheses | Useless parentheses. | 4 | 306 |
MyCoRe IView2 - org/mycore/iview2/events/MCRThumbnailForPdfEventHandler.java
| Rule | Violation | Priority | Line |
|---|---|---|---|
| UselessParentheses | Useless parentheses. | 4 | 115 |
MyCoRe IView2 - org/mycore/iview2/frontend/MCRIView2Commands.java
| Rule | Violation | Priority | Line |
|---|---|---|---|
| AvoidBranchingStatementAsLastInLoop | Avoid using a branching statement as the last in a loop. | 2 | 421 |
MyCoRe IView2 - org/mycore/iview2/frontend/MCRIView2XSLFunctionsAdapter.java
| Rule | Violation | Priority | Line |
|---|---|---|---|
| UselessParentheses | Useless parentheses. | 4 | 62 |
MyCoRe IView2 - org/mycore/iview2/frontend/resources/MCRIViewZipResource.java
| Rule | Violation | Priority | Line |
|---|---|---|---|
| UselessParentheses | Useless parentheses. | 4 | 116 |
MyCoRe IView2 - org/mycore/iview2/iiif/MCRIVIEWIIIFImageImpl.java
| Rule | Violation | Priority | Line |
|---|---|---|---|
| UselessParentheses | Useless parentheses. | 4 | 181 |
| UselessParentheses | Useless parentheses. | 4 | 182 |
MyCoRe IView2 - org/mycore/iview2/services/MCRIView2Tools.java
| Rule | Violation | Priority | Line |
|---|---|---|---|
| UselessParentheses | Useless parentheses. | 4 | 226 |
| UselessParentheses | Useless parentheses. | 4 | 231–232 |
| UselessParentheses | Useless parentheses. | 4 | 233–234 |
MyCoRe IView2 - org/mycore/iview2/services/MCRImageThumbnailGenerator.java
| Rule | Violation | Priority | Line |
|---|---|---|---|
| UselessParentheses | Useless parentheses. | 4 | 67 |
MyCoRe IView2 - org/mycore/iview2/services/MCRImageTiler.java
| Rule | Violation | Priority | Line |
|---|---|---|---|
| AvoidThreadGroup | Avoid using java.lang.ThreadGroup; it is not thread safe | 3 | 131 |
MyCoRe Linked Open Data - org/mycore/lod/MCRJerseyLodApp.java
| Rule | Violation | Priority | Line |
|---|---|---|---|
| EmptyCatchBlock | Avoid empty catch blocks | 3 | 121–123 |
MyCoRe METS - org/mycore/mets/iiif/MCRMetsMods2IIIFConverter.java
| Rule | Violation | Priority | Line |
|---|---|---|---|
| UselessParentheses | Useless parentheses. | 4 | 161 |
MyCoRe METS - org/mycore/mets/model/MCRMETSDefaultGenerator.java
| Rule | Violation | Priority | Line |
|---|---|---|---|
| UselessParentheses | Useless parentheses. | 4 | 185 |
MyCoRe METS - org/mycore/mets/servlets/MCRMETSServlet.java
| Rule | Violation | Priority | Line |
|---|---|---|---|
| UselessParentheses | Useless parentheses. | 4 | 154 |
| UselessParentheses | Useless parentheses. | 4 | 169 |
MyCoRe migration tools - org/mycore/migration/cli/MCRMigrationCommands.java
| Rule | Violation | Priority | Line |
|---|---|---|---|
| UnusedFormalParameter | Avoid unused method parameters such as 'href'. | 3 | 221 |
MyCoRe MODS - org/mycore/mods/MCRMODSDateHelper.java
| Rule | Violation | Priority | Line |
|---|---|---|---|
| UselessParentheses | Useless parentheses. | 4 | 47 |
MyCoRe MODS - org/mycore/mods/MCRMODSPagesHelper.java
| Rule | Violation | Priority | Line |
|---|---|---|---|
| UselessParentheses | Useless parentheses. | 4 | 110 |
| UselessParentheses | Useless parentheses. | 4 | 110 |
MyCoRe MODS - org/mycore/mods/MCRMODSWrapper.java
| Rule | Violation | Priority | Line |
|---|---|---|---|
| EmptyCatchBlock | Avoid empty catch blocks | 3 | 151–153 |
| UselessParentheses | Useless parentheses. | 4 | 215 |
| UselessParentheses | Useless parentheses. | 4 | 329 |
| UselessParentheses | Useless parentheses. | 4 | 337 |
MyCoRe MODS - org/mycore/mods/access/facts/condition/MCRMODSCollectionCondition.java
| Rule | Violation | Priority | Line |
|---|---|---|---|
| UselessParentheses | Useless parentheses. | 4 | 62 |
MyCoRe MODS - org/mycore/mods/access/facts/condition/MCRMODSGenreCondition.java
| Rule | Violation | Priority | Line |
|---|---|---|---|
| UselessParentheses | Useless parentheses. | 4 | 62 |
MyCoRe MODS - org/mycore/mods/bibtex/MCRUnsupportedFieldTransformer.java
| Rule | Violation | Priority | Line |
|---|---|---|---|
| UselessParentheses | Useless parentheses. | 4 | 56 |
MyCoRe MODS - org/mycore/mods/classification/MCRTypeOfResource.java
| Rule | Violation | Priority | Line |
|---|---|---|---|
| UselessParentheses | Useless parentheses. | 4 | 76 |
MyCoRe MODS - org/mycore/mods/enrichment/MCRDataSourceCall.java
| Rule | Violation | Priority | Line |
|---|---|---|---|
| SimplifiedTernary | Ternary operators that can be simplified with || or && | 3 | 96 |
MyCoRe MODS - org/mycore/mods/enrichment/MCRIdentifier.java
| Rule | Violation | Priority | Line |
|---|---|---|---|
| UselessParentheses | Useless parentheses. | 4 | 52 |
MyCoRe MODS - org/mycore/mods/merger/MCRExtentMerger.java
| Rule | Violation | Priority | Line |
|---|---|---|---|
| UselessOverridingMethod | Overriding method merely calls super | 3 | 31–33 |
| UselessParentheses | Useless parentheses. | 4 | 37 |
| UselessParentheses | Useless parentheses. | 4 | 49 |
MyCoRe MODS - org/mycore/mods/merger/MCRIdentifierMerger.java
| Rule | Violation | Priority | Line |
|---|---|---|---|
| UselessOverridingMethod | Overriding method merely calls super | 3 | 37–39 |
MyCoRe MODS - org/mycore/mods/merger/MCRMerger.java
| Rule | Violation | Priority | Line |
|---|---|---|---|
| OverrideBothEqualsAndHashcode | Ensure you override both equals() and hashCode() | 3 | 73 |
MyCoRe MODS - org/mycore/mods/merger/MCRRelatedItemMerger.java
| Rule | Violation | Priority | Line |
|---|---|---|---|
| UselessOverridingMethod | Overriding method merely calls super | 3 | 32–34 |
MyCoRe MODS - org/mycore/mods/merger/MCRUniqueMerger.java
| Rule | Violation | Priority | Line |
|---|---|---|---|
| UselessOverridingMethod | Overriding method merely calls super | 3 | 31–33 |
| UselessParentheses | Useless parentheses. | 4 | 37 |
MyCoRe MODS - org/mycore/mods/merger/MCRUniqueTypeMerger.java
| Rule | Violation | Priority | Line |
|---|---|---|---|
| UselessOverridingMethod | Overriding method merely calls super | 3 | 32–34 |
MyCoRe MODS - org/mycore/mods/rss/MCRRSSFeedImporter.java
| Rule | Violation | Priority | Line |
|---|---|---|---|
| UselessParentheses | Useless parentheses. | 4 | 156 |
| UselessParentheses | Useless parentheses. | 4 | 156 |
| UselessParentheses | Useless parentheses. | 4 | 215 |
MyCoRe OAI-PMH 2.0 Data Provider - org/mycore/oai/MCROAISearchManager.java
| Rule | Violation | Priority | Line |
|---|---|---|---|
| UselessParentheses | Useless parentheses. | 4 | 100 |
MyCoRe OAI-PMH 2.0 Data Provider - org/mycore/oai/MCROAISetManager.java
| Rule | Violation | Priority | Line |
|---|---|---|---|
| UnnecessaryFullyQualifiedName | Unnecessary use of fully qualified name 'OAIConstants.NS_OAI' due to existing static import 'org.mycore.oai.pmh.OAIConstants.NS_OAI' | 4 | 225 |
| CollapsibleIfStatements | These nested if statements could be combined | 3 | 229–231 |
MyCoRe ORCID Integration - org/mycore/orcid/oauth/MCROAuthServlet.java
| Rule | Violation | Priority | Line |
|---|---|---|---|
| UselessParentheses | Useless parentheses. | 4 | 76 |
| UselessParentheses | Useless parentheses. | 4 | 78 |
MyCoRe ORCID Integration - org/mycore/orcid/oauth/MCRReadPublicTokenFactory.java
| Rule | Violation | Priority | Line |
|---|---|---|---|
| UselessParentheses | Useless parentheses. | 4 | 50 |
MyCoRe ORCID Integration - org/mycore/orcid/user/MCRORCIDSession.java
| Rule | Violation | Priority | Line |
|---|---|---|---|
| UselessParentheses | Useless parentheses. | 4 | 39 |
MyCoRe ORCID Integration - org/mycore/orcid/user/MCRORCIDUser.java
| Rule | Violation | Priority | Line |
|---|---|---|---|
| UselessParentheses | Useless parentheses. | 4 | 93 |
| UselessParentheses | Useless parentheses. | 4 | 93 |
MyCoRe ORCID Integration - org/mycore/orcid/works/MCRWorkSource.java
| Rule | Violation | Priority | Line |
|---|---|---|---|
| UselessParentheses | Useless parentheses. | 4 | 60 |
MyCoRe ORCID Integration - org/mycore/orcid/works/MCRWorksFetcher.java
| Rule | Violation | Priority | Line |
|---|---|---|---|
| UselessParentheses | Useless parentheses. | 4 | 166 |
MyCoRe Persistent Identifier - org/mycore/pi/doi/MCRCrossrefService.java
| Rule | Violation | Priority | Line |
|---|---|---|---|
| UnusedPrivateField | Avoid unused private fields such as 'LOGGER'. | 3 | 66 |
MyCoRe Persistent Identifier - org/mycore/pi/doi/MCRDOIBaseService.java
| Rule | Violation | Priority | Line |
|---|---|---|---|
| UnusedLocalVariable | Avoid unused local variables such as 'transformer'. | 3 | 84 |
MyCoRe Persistent Identifier - org/mycore/pi/exceptions/MCRIdentifierUnresolvableException.java
| Rule | Violation | Priority | Line |
|---|---|---|---|
| UnusedPrivateField | Avoid unused private fields such as 'identifier'. | 3 | 23 |
MyCoRe Persistent Identifier - org/mycore/pi/frontend/MCRIdentifierXSLUtils.java
| Rule | Violation | Priority | Line |
|---|---|---|---|
| UselessParentheses | Useless parentheses. | 4 | 89–117 |
MyCoRe Persistent Identifier - org/mycore/pi/urn/MCRURNOAIService.java
| Rule | Violation | Priority | Line |
|---|---|---|---|
| UnusedPrivateField | Avoid unused private fields such as 'LOGGER'. | 3 | 34 |
MyCoRe REST API - org/mycore/restapi/MCRNormalizeMCRObjectIDsFilter.java
| Rule | Violation | Priority | Line |
|---|---|---|---|
| EmptyCatchBlock | Avoid empty catch blocks | 3 | 105–108 |
| EmptyCatchBlock | Avoid empty catch blocks | 3 | 130–132 |
MyCoRe REST API - org/mycore/restapi/MCRSessionFilter.java
| Rule | Violation | Priority | Line |
|---|---|---|---|
| UselessParentheses | Useless parentheses. | 4 | 109–111 |
MyCoRe REST API - org/mycore/restapi/MCRTransactionFilter.java
| Rule | Violation | Priority | Line |
|---|---|---|---|
| UnusedLocalVariable | Avoid unused local variables such as 'mcrSession'. | 3 | 47 |
MyCoRe REST API - org/mycore/restapi/converter/MCRWrappedXMLWriter.java
| Rule | Violation | Priority | Line |
|---|---|---|---|
| UselessParentheses | Useless parentheses. | 4 | 81 |
| UselessParentheses | Useless parentheses. | 4 | 129 |
MyCoRe REST API - org/mycore/restapi/v1/MCRRestAPIClassifications.java
| Rule | Violation | Priority | Line |
|---|---|---|---|
| EmptyCatchBlock | Avoid empty catch blocks | 3 | 267–269 |
| EmptyCatchBlock | Avoid empty catch blocks | 3 | 296–298 |
MyCoRe REST API - org/mycore/restapi/v1/MCRRestAPIMessages.java
| Rule | Violation | Priority | Line |
|---|---|---|---|
| EmptyCatchBlock | Avoid empty catch blocks | 3 | 130–132 |
| EmptyCatchBlock | Avoid empty catch blocks | 3 | 188–190 |
MyCoRe REST API - org/mycore/restapi/v1/utils/MCRRestAPIObjectsHelper.java
| Rule | Violation | Priority | Line |
|---|---|---|---|
| EmptyCatchBlock | Avoid empty catch blocks | 3 | 293–295 |
| EmptyCatchBlock | Avoid empty catch blocks | 3 | 427–429 |
MyCoRe REST API - org/mycore/restapi/v1/utils/MCRRestAPIUtil.java
| Rule | Violation | Priority | Line |
|---|---|---|---|
| UselessParentheses | Useless parentheses. | 4 | 58 |
| UselessParentheses | Useless parentheses. | 4 | 58 |
| UselessParentheses | Useless parentheses. | 4 | 58 |
| UselessParentheses | Useless parentheses. | 4 | 58 |
MyCoRe REST API - org/mycore/restapi/v2/MCRExceptionMapper.java
| Rule | Violation | Priority | Line |
|---|---|---|---|
| UselessParentheses | Useless parentheses. | 4 | 49 |
| UselessParentheses | Useless parentheses. | 4 | 77 |
MyCoRe REST API - org/mycore/restapi/v2/MCRRestDerivateContents.java
| Rule | Violation | Priority | Line |
|---|---|---|---|
| UnusedLocalVariable | Avoid unused local variables such as 'mcrSession'. | 3 | 154 |
| UselessParentheses | Useless parentheses. | 4 | 487 |
| UselessParentheses | Useless parentheses. | 4 | 498 |
MyCoRe REST API - org/mycore/restapi/v2/MCRRestDerivates.java
| Rule | Violation | Priority | Line |
|---|---|---|---|
| EmptyCatchBlock | Avoid empty catch blocks | 3 | 225–227 |
MyCoRe REST API - org/mycore/restapi/v2/MCRRestObjects.java
| Rule | Violation | Priority | Line |
|---|---|---|---|
| EmptyCatchBlock | Avoid empty catch blocks | 3 | 620–622 |
| EmptyCatchBlock | Avoid empty catch blocks | 3 | 687–689 |
MyCoRe Solr Support - org/mycore/solr/commands/MCRSolrCommands.java
| Rule | Violation | Priority | Line |
|---|---|---|---|
| TooManyStaticImports | Too many static imports may lead to messy code | 3 | 19–305 |
MyCoRe Solr Support - org/mycore/solr/index/handlers/MCRSolrOptimizeIndexHandler.java
| Rule | Violation | Priority | Line |
|---|---|---|---|
| UselessParentheses | Useless parentheses. | 4 | 41 |
MyCoRe Solr Support - org/mycore/solr/index/handlers/content/MCRSolrMCRContentMapIndexHandler.java
| Rule | Violation | Priority | Line |
|---|---|---|---|
| UnusedFormalParameter | Avoid unused constructor parameters such as 'solrClient'. | 3 | 61 |
MyCoRe Solr Support - org/mycore/solr/index/statistic/MCRSolrIndexStatistic.java
| Rule | Violation | Priority | Line |
|---|---|---|---|
| UselessParentheses | Useless parentheses. | 4 | 76 |
MyCoRe Solr Support - org/mycore/solr/schema/MCRSolrConfigReloader.java
| Rule | Violation | Priority | Line |
|---|---|---|---|
| UselessParentheses | Useless parentheses. | 4 | 311–312 |
| UselessParentheses | Useless parentheses. | 4 | 312 |
MyCoRe Solr Support - org/mycore/solr/search/MCRConditionTransformer.java
| Rule | Violation | Priority | Line |
|---|---|---|---|
| UselessParentheses | Useless parentheses. | 4 | 208 |
| UselessParentheses | Useless parentheses. | 4 | 211 |
| UselessParentheses | Useless parentheses. | 4 | 374 |
MyCoRe Solr Support - org/mycore/solr/search/MCRQLSearchUtils.java
| Rule | Violation | Priority | Line |
|---|---|---|---|
| UselessParentheses | Useless parentheses. | 4 | 186 |
MyCoRe Solr Support - org/mycore/solr/search/MCRSolrQueryAdapter.java
| Rule | Violation | Priority | Line |
|---|---|---|---|
| UselessParentheses | Useless parentheses. | 4 | 123 |
| UselessParentheses | Useless parentheses. | 4 | 123 |
| UselessParentheses | Useless parentheses. | 4 | 127 |
| UselessParentheses | Useless parentheses. | 4 | 127 |
MyCoRe Solr Support - org/mycore/solr/search/MCRSolrSearchServlet.java
| Rule | Violation | Priority | Line |
|---|---|---|---|
| UselessOverridingMethod | Overriding method merely calls super | 3 | 278–280 |
MyCoRe SWORD Interface - org/mycore/sword/MCRSwordUtil.java
| Rule | Violation | Priority | Line |
|---|---|---|---|
| UnusedLocalVariable | Avoid unused local variables such as 'currentSession'. | 3 | 182 |
| UnusedLocalVariable | Avoid unused local variables such as 'currentSession'. | 3 | 227 |
| UnusedLocalVariable | Avoid unused local variables such as 'currentSession'. | 3 | 285 |
MyCoRe SWORD Interface - org/mycore/sword/manager/MCRSwordServiceDocumentManager.java
| Rule | Violation | Priority | Line |
|---|---|---|---|
| UnusedFormalParameter | Avoid unused method parameters such as 'auth'. | 3 | 66 |
MyCoRe New User System - org/mycore/user2/MCRRole.java
| Rule | Violation | Priority | Line |
|---|---|---|---|
| UnusedPrivateMethod | Avoid unused private methods such as 'getLabelsArray()'. | 3 | 104 |
MyCoRe New User System - org/mycore/user2/MCRUser.java
| Rule | Violation | Priority | Line |
|---|---|---|---|
| SimplifiedTernary | Ternary operators that can be simplified with || or && | 3 | 204 |
| SimplifiedTernary | Ternary operators that can be simplified with || or && | 3 | 219 |
| UnusedPrivateMethod | Avoid unused private methods such as 'getEMail()'. | 3 | 400 |
| UnusedPrivateMethod | Avoid unused private methods such as 'getOwnerId()'. | 3 | 728 |
MyCoRe New User System - org/mycore/user2/MCRUserAttributeMapper.java
| Rule | Violation | Priority | Line |
|---|---|---|---|
| UselessParentheses | Useless parentheses. | 4 | 157 |
MyCoRe New User System - org/mycore/user2/MCRUserManager.java
| Rule | Violation | Priority | Line |
|---|---|---|---|
| UselessParentheses | Useless parentheses. | 4 | 684 |
MyCoRe New User System - org/mycore/user2/MCRUserServlet.java
| Rule | Violation | Priority | Line |
|---|---|---|---|
| UselessParentheses | Useless parentheses. | 4 | 91 |
| UselessParentheses | Useless parentheses. | 4 | 91 |
| UnusedFormalParameter | Avoid unused method parameters such as 'req'. | 3 | 119 |
| UselessParentheses | Useless parentheses. | 4 | 207 |
| UselessParentheses | Useless parentheses. | 4 | 207 |
| UselessParentheses | Useless parentheses. | 4 | 273 |
| UselessParentheses | Useless parentheses. | 4 | 273 |
| UselessParentheses | Useless parentheses. | 4 | 287 |
| UselessParentheses | Useless parentheses. | 4 | 287 |
| UselessParentheses | Useless parentheses. | 4 | 368 |
| UselessParentheses | Useless parentheses. | 4 | 368 |
| UselessParentheses | Useless parentheses. | 4 | 374 |
| UselessParentheses | Useless parentheses. | 4 | 374 |
| UselessParentheses | Useless parentheses. | 4 | 473 |
| UselessParentheses | Useless parentheses. | 4 | 487 |
| UselessParentheses | Useless parentheses. | 4 | 487 |
| UselessParentheses | Useless parentheses. | 4 | 510 |
| UselessParentheses | Useless parentheses. | 4 | 510 |
MyCoRe New User System - org/mycore/user2/login/MCRCASServlet.java
| Rule | Violation | Priority | Line |
|---|---|---|---|
| UselessParentheses | Useless parentheses. | 4 | 102 |
| UselessParentheses | Useless parentheses. | 4 | 102 |
MyCoRe New User System - org/mycore/user2/login/MCRLDAPClient.java
| Rule | Violation | Priority | Line |
|---|---|---|---|
| UselessParentheses | Useless parentheses. | 4 | 147 |
| UselessParentheses | Useless parentheses. | 4 | 147 |
| UselessParentheses | Useless parentheses. | 4 | 147 |
| UselessParentheses | Useless parentheses. | 4 | 174 |
| UselessParentheses | Useless parentheses. | 4 | 180 |
| UselessParentheses | Useless parentheses. | 4 | 187 |
| UselessParentheses | Useless parentheses. | 4 | 187 |
| UselessParentheses | Useless parentheses. | 4 | 187 |
MyCoRe New User System - org/mycore/user2/login/MCRLoginServlet.java
| Rule | Violation | Priority | Line |
|---|---|---|---|
| UselessParentheses | Useless parentheses. | 4 | 149 |
| UnnecessaryFullyQualifiedName | Unnecessary use of fully qualified name 'org.mycore.frontend.support.MCRLogin.InputField' due to existing import 'org.mycore.frontend.support.MCRLogin.InputField' | 4 | 221 |
| UselessParentheses | Useless parentheses. | 4 | 241 |
| UselessParentheses | Useless parentheses. | 4 | 252 |
| UselessParentheses | Useless parentheses. | 4 | 289 |
| UselessParentheses | Useless parentheses. | 4 | 289 |
MyCoRe New User System - org/mycore/user2/package-info.java
| Rule | Violation | Priority | Line |
|---|---|---|---|
| UnnecessaryFullyQualifiedName | Unnecessary use of fully qualified name 'org.mycore.user2.utils.MCRDateXMLAdapter' due to existing same package import 'org.mycore.user2.*' | 4 | 21 |
MyCoRe Viewer - org/mycore/viewer/resources/MCREpubZipResource.java
| Rule | Violation | Priority | Line |
|---|---|---|---|
| EmptyCatchBlock | Avoid empty catch blocks | 3 | 162–164 |
MyCoRe WCMS 2 - org/mycore/wcms2/navigation/MCRWCMSContentManager.java
| Rule | Violation | Priority | Line |
|---|---|---|---|
| UselessParentheses | Useless parentheses. | 4 | 175–176 |
MyCoRe Workflow Components - org/mycore/wfc/actionmapping/MCRCategoryCondition.java
| Rule | Violation | Priority | Line |
|---|---|---|---|
| UselessParentheses | Useless parentheses. | 4 | 77 |
MyCoRe XEditor - org/mycore/frontend/xeditor/MCREditorSession.java
| Rule | Violation | Priority | Line |
|---|---|---|---|
| UselessParentheses | Useless parentheses. | 4 | 197 |
MyCoRe XEditor - org/mycore/frontend/xeditor/MCREditorSubmission.java
| Rule | Violation | Priority | Line |
|---|---|---|---|
| UselessParentheses | Useless parentheses. | 4 | 106 |
| UselessParentheses | Useless parentheses. | 4 | 106 |
MyCoRe XEditor - org/mycore/frontend/xeditor/MCRIncludeHandler.java
| Rule | Violation | Priority | Line |
|---|---|---|---|
| UselessParentheses | Useless parentheses. | 4 | 121 |
| UselessParentheses | Useless parentheses. | 4 | 217 |
MyCoRe XEditor - org/mycore/frontend/xeditor/MCRPostProcessorXSL.java
| Rule | Violation | Priority | Line |
|---|---|---|---|
| EmptyCatchBlock | Avoid empty catch blocks | 3 | 73–75 |
MyCoRe XEditor - org/mycore/frontend/xeditor/MCRXEditorTransformer.java
| Rule | Violation | Priority | Line |
|---|---|---|---|
| UselessParentheses | Useless parentheses. | 4 | 133–135 |
| UselessParentheses | Useless parentheses. | 4 | 291 |
| UselessParentheses | Useless parentheses. | 4 | 330 |
| UselessParentheses | Useless parentheses. | 4 | 369 |
MyCoRe XEditor - org/mycore/frontend/xeditor/MCRXMLCleaner.java
| Rule | Violation | Priority | Line |
|---|---|---|---|
| UselessParentheses | Useless parentheses. | 4 | 108 |
MyCoRe XEditor - org/mycore/frontend/xeditor/target/MCRLayoutServiceTarget.java
| Rule | Violation | Priority | Line |
|---|---|---|---|
| UselessParentheses | Useless parentheses. | 4 | 47 |
| UselessParentheses | Useless parentheses. | 4 | 47 |
MyCoRe XEditor - org/mycore/frontend/xeditor/target/MCRSubselectReturnTarget.java
| Rule | Violation | Priority | Line |
|---|---|---|---|
| UselessParentheses | Useless parentheses. | 4 | 68 |
MyCoRe XEditor - org/mycore/frontend/xeditor/validation/MCRDateValidator.java
| Rule | Violation | Priority | Line |
|---|---|---|---|
| UselessParentheses | Useless parentheses. | 4 | 51 |
MyCoRe XEditor - org/mycore/frontend/xeditor/validation/MCRDecimalConverter.java
| Rule | Violation | Priority | Line |
|---|---|---|---|
| UselessParentheses | Useless parentheses. | 4 | 52 |
| UselessParentheses | Useless parentheses. | 4 | 67 |
MyCoRe XEditor - org/mycore/frontend/xeditor/validation/MCRValidator.java
| Rule | Violation | Priority | Line |
|---|---|---|---|
| UselessParentheses | Useless parentheses. | 4 | 69 |
Suppressed Violations
| Filename | Rule message | Suppression type | Reason |
|---|---|---|---|
| org/mycore/iview2/frontend/MCRIView2Commands.java | Avoid unused local variables such as 'entry'. | annotation | |
| org/mycore/user2/MCRRole.java | Avoid unused private methods such as 'setLabelsArray(MCRLabel)'. | annotation | |
| org/mycore/user2/MCRUser.java | Avoid unused private methods such as 'setRoles(MCRRole)'. | annotation | |
| org/mycore/user2/MCRUser.java | Avoid unused private methods such as 'setOwnerId(UserIdentifier)'. | annotation |